From: Yizhou Tang <tangyeechou@gmail.com>
To: Yu Kuai <yukuai1@huaweicloud.com>
Cc: Tang Yizhou <yizhou.tang@shopee.com>,
axboe@kernel.dk, linux-block@vger.kernel.org,
linux-kernel@vger.kernel.org, "yukuai (C)" <yukuai3@huawei.com>
Subject: Re: [PATCH] blk-wbt: Cleanup some comments
Date: Thu, 13 Feb 2025 11:03:45 +0800 [thread overview]
Message-ID: <CAOB9oObJ6O374EnThRs4FSchTZeJ3v_153mVHCgXK8EOOGpCnQ@mail.gmail.com> (raw)
In-Reply-To: <e8de697b-e098-97cd-fe3c-800b59b2c7cf@huaweicloud.com>
On Thu, Feb 13, 2025 at 10:56 AM Yu Kuai <yukuai1@huaweicloud.com> wrote:
>
> Hi,
>
> 在 2025/02/12 11:00, Tang Yizhou 写道:
> > From: Tang Yizhou <yizhou.tang@shopee.com>
> >
> > wbt_wait() no longer uses a spinlock as a parameter. Update the
> > function comments accordingly.
> >
> > Additionally, revise other comments to ensure they align with the
> > actual implementation.
> >
> > Signed-off-by: Tang Yizhou <yizhou.tang@shopee.com>
> > ---
> > block/blk-wbt.c | 17 +++++++----------
> > 1 file changed, 7 insertions(+), 10 deletions(-)
> >
> > diff --git a/block/blk-wbt.c b/block/blk-wbt.c
> > index 6dfc659d22e2..f1754d07f7e0 100644
> > --- a/block/blk-wbt.c
> > +++ b/block/blk-wbt.c
> > @@ -136,8 +136,9 @@ enum {
> > RWB_MIN_WRITE_SAMPLES = 3,
> >
> > /*
> > - * If we have this number of consecutive windows with not enough
> > - * information to scale up or down, scale up.
> > + * If we have this number of consecutive windows without enough
> > + * information to scale up or down, slowly return to center state
> > + * (step == 0).
> > */
> > RWB_UNKNOWN_BUMP = 5,
> > };
> > @@ -446,9 +447,9 @@ static void wb_timer_fn(struct blk_stat_callback *cb)
> > break;
> > case LAT_UNKNOWN_WRITES:
> > /*
> > - * We started a the center step, but don't have a valid
> > - * read/write sample, but we do have writes going on.
> > - * Allow step to go negative, to increase write perf.
> > + * We don't have a valid read/write sample, but we do have
> > + * writes going on. Allow step to go negative, to increase
> > + * write performance.
>
> Other than this clean up, the others are actually fix. Can you remove
> this one and change the title to "Fix some comments"?
>
> Thanks,
> Kuai
>
Will do.
Thanks
Yi
> > */
> > scale_up(rwb);
> > break;
> > @@ -638,11 +639,7 @@ static void wbt_cleanup(struct rq_qos *rqos, struct bio *bio)
> > __wbt_done(rqos, flags);
> > }
> >
> > -/*
> > - * May sleep, if we have exceeded the writeback limits. Caller can pass
> > - * in an irq held spinlock, if it holds one when calling this function.
> > - * If we do sleep, we'll release and re-grab it.
> > - */
> > +/* May sleep, if we have exceeded the writeback limits. */
> > static void wbt_wait(struct rq_qos *rqos, struct bio *bio)
> > {
> > struct rq_wb *rwb = RQWB(rqos);
> >
>
>
prev parent reply other threads:[~2025-02-13 3:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-12 3:00 Tang Yizhou
2025-02-13 2:56 ` Yu Kuai
2025-02-13 3:03 ` Yizhou Tang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAOB9oObJ6O374EnThRs4FSchTZeJ3v_153mVHCgXK8EOOGpCnQ@mail.gmail.com \
--to=tangyeechou@gmail.com \
--cc=axboe@kernel.dk \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=yizhou.tang@shopee.com \
--cc=yukuai1@huaweicloud.com \
--cc=yukuai3@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®