From: Jeffrey Hugo <jeffrey.l.hugo@gmail.com>
To: Lee Jones <lee.jones@linaro.org>
Cc: bjorn.andersson@linaro.org, Andy Gross <andy.gross@linaro.org>,
David Brown <david.brown@linaro.org>,
robh+dt@kernel.org, mark.rutland@arm.com,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] arm64: dts: qcom: Add Lenovo Miix 630
Date: Mon, 1 Apr 2019 08:13:38 -0600 [thread overview]
Message-ID: <CAOCk7Np53o69xQw83V1sfO2uv1-NFSGtbsTqH-5K1m1Rdaf-GA@mail.gmail.com> (raw)
In-Reply-To: <20190401105153.GE4187@dell>
Hi Lee.
On Mon, Apr 1, 2019 at 4:52 AM Lee Jones <lee.jones@linaro.org> wrote:
>
> On Tue, 26 Mar 2019, Jeffrey Hugo wrote:
>
> > This adds the initial DT for the Lenovo Miix 630 laptop. Supported
> > functionality includes USB (host), microSD-card, keyboard, and trackpad.
> >
> > Signed-off-by: Jeffrey Hugo <jeffrey.l.hugo@gmail.com>
> > ---
> > arch/arm64/boot/dts/qcom/Makefile | 1 +
> > arch/arm64/boot/dts/qcom/msm8998-cls.dtsi | 278 ++++++++++++++++++
>
> What is cls?
Clamshell. I left a comment in the file that is intended to clarify
this. If one does some digging, they should find a fair number of
"cls" references within the firmware and windows.
>
> How much of this will be reusable with the other laptops?
The intent is that all the common stuff, which I expect is >90%, is in
the cls.dtsi so that we don't have multiple copies of it. Variances,
such as the SD detect GPIO stuff we've discovered would be in the
individual dtb. Or at-least, that is the idea. I'm open to
suggestions.
I'm unable to post dts files based on the HP/Asus at this time, but
hopefully that changes soon. Otherwise, Its my goal that this
provides a good framework for adding those devices.
>
> > .../boot/dts/qcom/msm8998-lenovo-miix-630.dts | 33 +++
> > 3 files changed, 312 insertions(+)
> > create mode 100644 arch/arm64/boot/dts/qcom/msm8998-cls.dtsi
> > create mode 100644 arch/arm64/boot/dts/qcom/msm8998-lenovo-miix-630.dts
>
> --
> Lee Jones [李琼斯]
> Linaro Services Technical Lead
> Linaro.org │ Open source software for ARM SoCs
> Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2019-04-01 14:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-26 18:55 Jeffrey Hugo
2019-04-01 10:51 ` Lee Jones
2019-04-01 14:13 ` Jeffrey Hugo [this message]
2019-04-08 11:03 ` Mark Rutland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAOCk7Np53o69xQw83V1sfO2uv1-NFSGtbsTqH-5K1m1Rdaf-GA@mail.gmail.com \
--to=jeffrey.l.hugo@gmail.com \
--cc=andy.gross@linaro.org \
--cc=bjorn.andersson@linaro.org \
--cc=david.brown@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=lee.jones@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®