From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752498AbdLGKWZ (ORCPT ); Thu, 7 Dec 2017 05:22:25 -0500 Received: from mail-wm0-f65.google.com ([74.125.82.65]:34927 "EHLO mail-wm0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752659AbdLGKUo (ORCPT ); Thu, 7 Dec 2017 05:20:44 -0500 X-Google-Smtp-Source: AGs4zMbR1FY7LWeP/1IsXVW+VJO+PX/vJPP5tREckdR2ZleKz0vw8ne1UsOkt1LJIselhk6+wX6ygXe6Q3YU/4icqew= MIME-Version: 1.0 In-Reply-To: <20171205174310.15799-1-bjorn.andersson@linaro.org> References: <20171205174310.15799-1-bjorn.andersson@linaro.org> From: Philippe Ombredanne Date: Thu, 7 Dec 2017 11:20:02 +0100 Message-ID: Subject: Re: [PATCH v5 0/5] In-kernel QMI helpers and sysmon To: Bjorn Andersson Cc: Andy Gross , Ohad Ben-Cohen , Arun Kumar Neelakantam , Chris Lew , LKML , linux-arm-msm@vger.kernel.org, linux-soc@vger.kernel.org, linux-remoteproc@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Dec 5, 2017 at 6:43 PM, Bjorn Andersson wrote: > This series introduces a helper library for drivers that needs to implement > clients or services in the kernel for communicating with QMI encoded messages. > > This is used by a set of drivers in order to implement control signaling that > needs to happen between a driver and a service on a remote processor, such as > the synchronization of states during a remoteproc shutdown/restart; as seen in > the sysmon implementation. > > Finally a sample driver provides an implementation of the "test" protocol, > which is a service typically implemented by Qualcomm remoteproc firmware. > > Changes since v4: > - Use SPDX headers > > Changes since v3: > - Don't call QMI handler for response type messages without known txn > - Kerneldoc updates > - Style updates > > Changes since v2: > - Fix reported typos > - Checkpatch fixes > - Use non-gpl EXPORT_SYMBOL > > Changes since v1: > - Lot of modifications to QMI interface, from feedback and implementation and > testing of sysmon. > - Added sysmon driver. > - Added patch for remoteproc to pass gracefulness on subdev remove. > - QRTR patches part of v1 was merged separately > > Bjorn Andersson (5): > soc: qcom: Introduce QMI encoder/decoder > soc: qcom: Introduce QMI helpers > remoteproc: Pass type of shutdown to subdev remove > remoteproc: qcom: Introduce sysmon > samples: Introduce Qualcomm QMI sample client > > drivers/remoteproc/Kconfig | 17 + > drivers/remoteproc/Makefile | 1 + > drivers/remoteproc/qcom_adsp_pil.c | 12 + > drivers/remoteproc/qcom_common.c | 6 +- > drivers/remoteproc/qcom_common.h | 21 + > drivers/remoteproc/qcom_q6v5_pil.c | 3 + > drivers/remoteproc/qcom_sysmon.c | 579 ++++++++++++++++++++++++ > drivers/remoteproc/qcom_wcnss.c | 4 + > drivers/remoteproc/remoteproc_core.c | 18 +- > drivers/soc/qcom/Kconfig | 9 + > drivers/soc/qcom/Makefile | 2 + > drivers/soc/qcom/qmi_encdec.c | 816 +++++++++++++++++++++++++++++++++ > drivers/soc/qcom/qmi_interface.c | 848 +++++++++++++++++++++++++++++++++++ > include/linux/remoteproc.h | 4 +- > include/linux/soc/qcom/qmi.h | 271 +++++++++++ > samples/Kconfig | 9 + > samples/Makefile | 2 +- > samples/qmi/Makefile | 1 + > samples/qmi/qmi_sample_client.c | 622 +++++++++++++++++++++++++ > 19 files changed, 3230 insertions(+), 15 deletions(-) > create mode 100644 drivers/remoteproc/qcom_sysmon.c > create mode 100644 drivers/soc/qcom/qmi_encdec.c > create mode 100644 drivers/soc/qcom/qmi_interface.c > create mode 100644 include/linux/soc/qcom/qmi.h > create mode 100644 samples/qmi/Makefile > create mode 100644 samples/qmi/qmi_sample_client.c > > -- > 2.15.0 > For this patch series and the use of SPDX ids: Thanks! Acked-by: Philippe Ombredanne