From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933138AbeBLJQs (ORCPT ); Mon, 12 Feb 2018 04:16:48 -0500 Received: from mail-wm0-f68.google.com ([74.125.82.68]:40693 "EHLO mail-wm0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933054AbeBLJQp (ORCPT ); Mon, 12 Feb 2018 04:16:45 -0500 X-Google-Smtp-Source: AH8x224LMJLYFFgqi7t2S+taId3OQDofhwMqwFhFnF9FS1IZdah6L/ToVOkxvehH05LJx0QlhilwcfEd4BG/8QTN6Rw= MIME-Version: 1.0 In-Reply-To: References: <20180203154942.63566-1-icenowy@aosc.io> <20180203154942.63566-6-icenowy@aosc.io> From: Philippe Ombredanne Date: Mon, 12 Feb 2018 10:16:03 +0100 Message-ID: Subject: Re: [linux-sunxi] [PATCH v2 5/6] arm64: allwinner: h6: add the basical Allwinner H6 DTSI file To: =?UTF-8?Q?Andr=C3=A9_Przywara?= Cc: Icenowy Zheng , Rob Herring , Maxime Ripard , Chen-Yu Tsai , Linus Walleij , linux-clk@vger.kernel.org, "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" , LKML , linux-gpio@vger.kernel.org, linux-sunxi@googlegroups.com Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id w1C9Gw8j017793 Icenowy, On Mon, Feb 12, 2018 at 12:26 AM, André Przywara wrote: > Hi, > > On 03/02/18 15:49, Icenowy Zheng wrote: >> Allwinner H6 is a new SoC with Cortex-A53 cores from Allwinner, with its >> memory map fully reworked and some high-speed peripherals (PCIe, USB >> 3.0) introduced. >> >> This commit adds the basical DTSI file of it, including the clock >> support and UART support. > > Checked the MMIO addresses and the interrupt numbers against the manual. > >> Signed-off-by: Icenowy Zheng > > Reviewed-by: Andre Przywara > > Thanks! > Andre. > >> --- >> Changes in v2: >> - Add APB1 clock as PIO's APB clock. >> - Switched to SPDX license identifier. >> >> arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi | 178 +++++++++++++++++++++++++++ >> 1 file changed, 178 insertions(+) >> create mode 100644 arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi >> >> diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi b/arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi >> new file mode 100644 >> index 000000000000..d4697bb42496 >> --- /dev/null >> +++ b/arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi >> @@ -0,0 +1,178 @@ >> +/* >> + * Copyright (C) 2017 Icenowy Zheng >> + * >> + * SPDX-License-Identifier: (GPL-2.0+ or MIT) >> + */ Thank you for using SPDX ids: this needs to be on the first line though! [1] and eventually some special comments style. [1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/license-rules.rst -- Cordially Philippe Ombredanne