From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752813Ab3KNIYV (ORCPT ); Thu, 14 Nov 2013 03:24:21 -0500 Received: from mail-wg0-f51.google.com ([74.125.82.51]:43126 "EHLO mail-wg0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751438Ab3KNIYS (ORCPT ); Thu, 14 Nov 2013 03:24:18 -0500 MIME-Version: 1.0 In-Reply-To: <20131113235708.GC25344@anatevka.fc.hp.com> References: <1384222558-38527-1-git-send-email-jerry.hoemann@hp.com> <20131113224503.GB25344@anatevka.fc.hp.com> <52840206.5020006@zytor.com> <20131113235708.GC25344@anatevka.fc.hp.com> Date: Thu, 14 Nov 2013 10:24:17 +0200 X-Google-Sender-Auth: Q4TJkbbMjR4eLqvjLax4pVikm9w Message-ID: Subject: Re: [PATCH 0/3] Early use of boot service memory From: Pekka Enberg To: Jerry Hoemann Cc: "H. Peter Anvin" , Rob Landley , Thomas Gleixner , Ingo Molnar , x86 maintainers , Matt Fleming , Yinghai Lu , Andrew Morton , "list@ebiederm.org:DOCUMENTATION , list@ebiederm.org:MEMORY MANAGEMENT ," , linux-efi@vger.kernel.org, Vivek Goyal , LKML Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Jerry, On Thu, Nov 14, 2013 at 1:57 AM, wrote: > I will still point out that as currently used, efi_reserve_boot_services > is wrong. A work around for firmware bugs on one platform shouldn't be > breaking platforms that don't have that bug. Its just much less likely > to cause problems with higher crash kernel allocation. Wrong in what way exactly? We need efi_reserve_boot_services on _some_ platforms and it's only practical to do it on all platforms to be able to boot a generic kernel. Likewise, it would be more practical to fix crashkernel on all platforms instead of adding a new code path in the kernel that won't receive as much testing coverage (we need to reserve boot services by default). And frankly, I don't understand why 'violating the UEFI specification' is even brought up. It's shipped firmware that matters here no matter how broken it is. As long as there's a reasonable solution for crashkernel that works on all platforms, we should go for it instead of special-casing for 'proper firmware' because it makes testing the kernel more difficult. Pekka