From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755459Ab3EFPpt (ORCPT ); Mon, 6 May 2013 11:45:49 -0400 Received: from muin.pair.com ([209.68.1.55]:56155 "EHLO muin.pair.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753830Ab3EFPps (ORCPT ); Mon, 6 May 2013 11:45:48 -0400 MIME-Version: 1.0 In-Reply-To: <1367444087-18336-1-git-send-email-mark.langsdorf@calxeda.com> References: <1367444087-18336-1-git-send-email-mark.langsdorf@calxeda.com> Date: Mon, 6 May 2013 10:45:45 -0500 Message-ID: Subject: Re: [PATCH] ata: increase retry count but shorten duration for Calxeda controller From: Timur Tabi To: Mark Langsdorf Cc: lkml , linux-ide@vger.kernel.org, Jeff Garzik Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 1, 2013 at 4:34 PM, Mark Langsdorf wrote: > > - const unsigned long *timing = sata_ehc_deb_timing(&link->eh_context); > + unsigned long timing[] = { 5, 100, 500}; Why are you dropping the 'const'? Assuming it works, this should be more efficient: static const unsigned long timing[] = {5, 100, 500};