From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f175.google.com (mail-pl1-f175.google.com [209.85.214.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 431833043CF for ; Thu, 16 Jul 2026 02:45:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=pass smtp.client-ip=209.85.214.175 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784169907; cv=pass; b=grENgIv5sBRh4ydHpTstW/Gf1wNmlxgZOKn/1GEQfiIqavl8QXHNO2EfDr1p3aFp4pTV2LUMXJiXuPYV8x/24UGzmzoKXEgWdlbN/rYxxRc7e/Qr1G9/7eq4KdWlmffDafoHxFOweIMdyFp+8S0tgowfewS1jyYAX5kb3cCb7fo= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784169907; c=relaxed/simple; bh=FjX6PU2BP+ECnJIc7+9RJ4ml17iGk5ZNrnS3+lm95u0=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=brcB+U33/y0OgFqf8opV0lQpb/IbmLRU8oPIIg0TUZM2Qi/HheZjbPxbi2shiLk86dqhlOCUv95MKe6I5s9Iy8xrUR43q2Us/8BTCX6TGcF00KeUbhptbB6BEhO9/7K1wjsa8fRaRvy4g5utq3nEdBbKLSWMrxjI20oPhuKfCac= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=GkFoQeIb; arc=pass smtp.client-ip=209.85.214.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="GkFoQeIb" Received: by mail-pl1-f175.google.com with SMTP id d9443c01a7336-2cab97c86bdso42045ad.1 for ; Wed, 15 Jul 2026 19:45:06 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1784169905; cv=none; d=google.com; s=arc-20260327; b=Twi7Z+Ps66ztkr3c+xWMlomMi/3+t5XiUOM01vvn8flS39r/1NkDWFCZ6QOMSN0Wg6 istma0m/TSlA+JmexpIqaGDqLfaLWmfG0Zt8fqeYyNtxgov5osJp14aAsfF8j2EtyUFu hzR2La6XkX94dvOCMczqKpspu5cld0u7dqZ7jdowxJM+ZlKW6E98aLeqgWukglAzhC7C Kka4lG8G+wsE0rCVCv2ZfdU3Y52M2w+/1XW3ca/wJvZJWnZWK0LGQKz1JPg7k6eZaM8v LppDXC4JbygiKDI8ae1WLBBmWtvWN8j1sLlO3Qy4sy4D8D06KJSF0ZY8DY3AHqSXeXdv SHwA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=w9M4uT3MAj/sBxvep8cpJ1JC82mQWUFhrOmRXPihQxs=; fh=S++2x8w1bOSvxgRRlzaxQhCkxpQoBRJCXmiLdNPT6rQ=; b=ZGKGeqjpCUflHMmAC1HqY225PE5qfSZbtkYNGi3j2+hXXn7df8v9uEv/4+oJ2juOpH q2ZUrZCF8g1c2l+ekY5FJFdDmLyqQxJfqcbDkGOGvfyTQCkHdubuAcnMIpv6pR0y3XkJ PMZzsZaJM3C9X7vd9RCwb2/E/voZ/xRSzz2KjInpdWgykTQP17lEXqpBj0p5izKLjerE F83YkishLODqJP2PD7BuDQ893daskkVqoxycBJdioE+uizzUpg0hM0ZR3BwDeFvch/sW O/3HxCnnJVfMqWRaWZuzJA7UZtJejDDkdz5VTfDldrqA51QSK2Y+y2sq4KFtGbxLVXaV 6GYQ==; darn=vger.kernel.org ARC-Authentication-Results: i=1; mx.google.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1784169905; x=1784774705; darn=vger.kernel.org; h=content-transfer-encoding:content-type:cc:to:subject:message-id :date:from:in-reply-to:references:mime-version:from:to:cc:subject :date:message-id:reply-to:content-type; bh=w9M4uT3MAj/sBxvep8cpJ1JC82mQWUFhrOmRXPihQxs=; b=GkFoQeIb8dFAIySxKfT045ud5wKNaeHUIpYcixDyyL0kTz1AfNqAOBs1JoZz8vthAl bIQzKcSg5xbUMubuz9v5eewysztTk/8rkR8D4n6BerfpuwiiJ/lXEH5fYy4IJa4fvX+D tkuvNJ1HFeMP8POogI0tp+SBa+DIFMtX7cUw0s+ijb+gUct+eEC/pVO5j5kKzRvNFrGi JnViWNIaHWrHb78VDQ0ClabBOpADP2FyZWAIyodwtAZZ9U9s22sAeHRWUy22Aj6Y/cpz UPRzJRxnckFhHsnsqmC2/pmfb0xwtazLmuLMjjZ9P5bndT7lAtPncIrEtzPaf3ZMsn/I ccTg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784169905; x=1784774705; h=content-transfer-encoding:content-type:cc:to:subject:message-id :date:from:in-reply-to:references:mime-version:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=w9M4uT3MAj/sBxvep8cpJ1JC82mQWUFhrOmRXPihQxs=; b=AQwQX49v5SqK/7xo+9vzON+B5sVP/iw6cSZ1TzlI7OBiQIFv6KxeYYsSCuXaY0zECu Ev0Bkv9K6nIs47bogRU5sl+H0gYKwuFddJ0d/TLItp8/A/WSI7Ussu0PvjqUhDUhGaDC 1Jh8rLV7Y+JY3CPs3xna257Nl5SZnjeqxNomhA/tEHaqdkRmh6loqj0v6tXSxZIwL4e2 stjlKy4c173T9sNZXiD3cdKiqR/WJdznfnB063++crm5W/fXUEW660Aqm+Al31K3+kco 3QxKJRbdYenXaIcxm8A1ZfCGGnqOyqCyGbV7KsXHOmYVlNVDagoAoILVf1qBZfJl37PU bTqg== X-Forwarded-Encrypted: i=1; AHgh+RpVS4Iyhq1Qkbs+iWVsaLVTjudB8yIxAtm68yKueJJLpHd2JiA7oSJy44oi8uwMRI4XDk7UVcbk2xiqfUA=@vger.kernel.org X-Gm-Message-State: AOJu0YxIwX2BKm2C9BrfsNpJXrferS08Es3zkrUG1kQVYw6KvGtc2nvB J/CiBo/0/GLVdZthcbhQhVZFa95pllSJ4LmEf/wZoHy/VslvYW3s8eDQpYiZ4chMQPab5JHDueW aHEDPlByEJ3wza59ej9R1ihFK03QDWkn8d/7H4F9V X-Gm-Gg: AfdE7cnP4gpTNAkIHKjU0DryhiKFIjJgIR5W4bqA26N+qjU0eI34JKTU77WknQtXDhF g3ghz1vn9hIsusNvbpygqa5jDVvQ2k322qZ2E1axWKlr9dwqf7H8v4/CL613gdh7kE9KjAuDRBX as7tJb9qkqqrQfigeXK6j594L1Owwe/TvTSqhhg7g7R2XRfA/0lJY7AzDN72MwbHHEqRvEZ/1fI mpb9UaIySRmxrTK/rPVW/4rtZe3eiR4+lb96m2/5R6JkewaovIt4DYn6BVfYiE= X-Received: by 2002:a17:902:ec8f:b0:2c0:defb:557e with SMTP id d9443c01a7336-2cf1d9d9ae6mr997675ad.1.1784169905101; Wed, 15 Jul 2026 19:45:05 -0700 (PDT) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20260716004336.2731086-1-namhyung@kernel.org> In-Reply-To: <20260716004336.2731086-1-namhyung@kernel.org> From: Ian Rogers Date: Wed, 15 Jul 2026 19:44:53 -0700 X-Gm-Features: AUfX_mx5ra8fLJGpPa-h2CMVw_HCcIOVxVNEgQ-Fp8nDEFTK8bVr0JeUuTqsYzo Message-ID: Subject: Re: [PATCH] perf build: Fix a compiler error in util/libbfd.c To: Namhyung Kim Cc: Arnaldo Carvalho de Melo , Jiri Olsa , Adrian Hunter , James Clark , Peter Zijlstra , Ingo Molnar , LKML , linux-perf-users@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Wed, Jul 15, 2026 at 5:43=E2=80=AFPM Namhyung Kim = wrote: > > The bfd_boolean type was gone and converted to the standard bool type > but we have some old code that uses the type. It caused a failure in > the build test. > > util/libbfd.c: In function 'slurp_symtab': > util/libbfd.c:94:9: error: unknown type name 'bfd_boolean' > 94 | bfd_boolean dynamic =3D FALSE; > | ^~~~~~~~~~~ > util/libbfd.c:94:31: error: 'FALSE' undeclared (first use in this funct= ion) > 94 | bfd_boolean dynamic =3D FALSE; > | ^~~~~ > util/libbfd.c:94:31: note: each undeclared identifier is reported only = once for each function it appears in > util/libbfd.c:102:27: error: 'TRUE' undeclared (first use in this funct= ion) > 102 | dynamic =3D TRUE; > | ^~~~ > > Fix it with standard bool type and constants. > > Link: https://sourceware.org/pipermail/binutils-cvs/2021-March/056231.htm= l > Signed-off-by: Namhyung Kim Reviewed-by: Ian Rogers Should we add a fixes tag for backports? It's not clear we can provide a sensible SHA. Thanks, Ian > --- > tools/perf/util/libbfd.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/tools/perf/util/libbfd.c b/tools/perf/util/libbfd.c > index c1c12308cc12ffea..d8241c7caac50836 100644 > --- a/tools/perf/util/libbfd.c > +++ b/tools/perf/util/libbfd.c > @@ -91,7 +91,7 @@ static int slurp_symtab(bfd *abfd, struct a2l_data *a2l= ) > long storage; > long symcount; > asymbol **syms; > - bfd_boolean dynamic =3D FALSE; > + bool dynamic =3D false; > > if ((bfd_get_file_flags(abfd) & HAS_SYMS) =3D=3D 0) > return bfd_error(bfd_get_filename(abfd)); > @@ -99,7 +99,7 @@ static int slurp_symtab(bfd *abfd, struct a2l_data *a2l= ) > storage =3D bfd_get_symtab_upper_bound(abfd); > if (storage =3D=3D 0L) { > storage =3D bfd_get_dynamic_symtab_upper_bound(abfd); > - dynamic =3D TRUE; > + dynamic =3D true; > } > if (storage < 0L) > return bfd_error(bfd_get_filename(abfd)); > -- > 2.55.0.141.g00534a21ce-goog >