mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Ian Rogers <irogers@google.com>
To: Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: linux-kernel@vger.kernel.org,
	Andrew Morton <akpm@linux-foundation.org>,
	 Randy Dunlap <rdunlap@infradead.org>,
	Adrian Hunter <adrian.hunter@intel.com>,
	 James Clark <james.clark@linaro.org>,
	Jiri Olsa <jolsa@kernel.org>,  Namhyung Kim <namhyung@kernel.org>,
	linux-perf-users@vger.kernel.org
Subject: Re: [PATCH 1/1 fyi] tools headers: Syncronize linux/build_bug.h with the kernel sources
Date: Wed, 18 Mar 2026 13:48:36 -0700	[thread overview]
Message-ID: <CAP-5=fV6_1_4oEDa2VG6uSegpASa_fqm2crs_LB1Toft7YA7wQ@mail.gmail.com> (raw)
In-Reply-To: <abrwjt_R2X8r7Bbm@x1>

nit: Typo in the subject line s/syncronize/synchronize/

On Wed, Mar 18, 2026 at 11:36 AM Arnaldo Carvalho de Melo
<acme@kernel.org> wrote:
>
> tldr; Just FYI, I'm carrying this on the perf tools tree.
>
> Full explanation:
>
> There used to be no copies, with tools/ code using kernel headers
> directly. From time to time tools/perf/ broke due to legitimate kernel
> hacking. At some point Linus complained about such direct usage. Then we
> adopted the current model.
>
> See further details at:
>
>  https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/tools/include/uapi/README
>
> To pick up the changes in:
>
>   6ffd853b0b10e1e2 ("build_bug.h: correct function parameters names in kernel-doc")
>
> That just add some comments, addressing this perf tools build warning:
>
>   Warning: Kernel ABI header differences:
>     diff -u tools/include/linux/build_bug.h include/linux/build_bug.h
>
> Please take a look at tools/include/uapi/README for further info on this
> synchronization process.
>
> Cc: Andrew Morton <akpm@linux-foundation.org>
> Cc: Randy Dunlap <rdunlap@infradead.org>
> Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
> ---
>  include/linux/build_bug.h | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/include/linux/build_bug.h b/include/linux/build_bug.h
> index d3dc5dc5f916ff4e..2cfbb4c65c784ad8 100644
> --- a/include/linux/build_bug.h
> +++ b/include/linux/build_bug.h

Shouldn't this patch be to the tools version?

Thanks,
Ian

> @@ -32,8 +32,7 @@
>  /**
>   * BUILD_BUG_ON_MSG - break compile if a condition is true & emit supplied
>   *                   error message.
> - * @cond: the condition which the compiler should know is false.
> - * @msg: build-time error message
> + * @condition: the condition which the compiler should know is false.
>   *
>   * See BUILD_BUG_ON for description.
>   */
> @@ -61,7 +60,6 @@
>
>  /**
>   * static_assert - check integer constant expression at build time
> - * @expr: expression to be checked
>   *
>   * static_assert() is a wrapper for the C11 _Static_assert, with a
>   * little macro magic to make the message optional (defaulting to the
> --
> 2.53.0
>

  reply	other threads:[~2026-03-18 20:48 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-18 18:35 Arnaldo Carvalho de Melo
2026-03-18 20:48 ` Ian Rogers [this message]
  -- strict thread matches above, loose matches on Subject: below --
2025-06-12 20:07 Arnaldo Carvalho de Melo
2023-01-18 13:30 [PATCH 1/1 FYI] " Arnaldo Carvalho de Melo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAP-5=fV6_1_4oEDa2VG6uSegpASa_fqm2crs_LB1Toft7YA7wQ@mail.gmail.com' \
    --to=irogers@google.com \
    --cc=acme@kernel.org \
    --cc=adrian.hunter@intel.com \
    --cc=akpm@linux-foundation.org \
    --cc=james.clark@linaro.org \
    --cc=jolsa@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=namhyung@kernel.org \
    --cc=rdunlap@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®