From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id ED052C61DB3 for ; Thu, 12 Jan 2023 21:11:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240838AbjALVLw (ORCPT ); Thu, 12 Jan 2023 16:11:52 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48500 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232585AbjALVLW (ORCPT ); Thu, 12 Jan 2023 16:11:22 -0500 Received: from mail-wr1-x433.google.com (mail-wr1-x433.google.com [IPv6:2a00:1450:4864:20::433]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8C88F6ECAC for ; Thu, 12 Jan 2023 12:55:15 -0800 (PST) Received: by mail-wr1-x433.google.com with SMTP id e3so10091837wru.13 for ; Thu, 12 Jan 2023 12:55:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=1l2nJvkOMhf/Q6N3HmLSKyOtgxFfcSynbTgFlzQDiFk=; b=i7zPfI1s6CYytk6lWGPrP8CLKhu5KppwB4Hin/v8r4IXv34PypNj92GKWH1EOSRi4p 4oraSwQAEm4b+M15QRiIqoEKTna1YolT16s/BMD4AsIPQqG9wVIuNSH58/r+iZQoBIVG 6mwkTRKJx1TPRFlQyVl+gy3wuKXpz5mLkbJlqaWftImBj3KWxYeqE5qntpqRNAsz9kI3 qTpaYV/QRsYLkei4Z8FK21P2zzwwTOLEkpQPUQxQXo8hRg1DLsnyNxa5jXpza5fTj+Hj o/U9rW5lGJ5Zq7ca7PsohBTZwsWbM09H1ERgOjdN9auI7jxsuHpim3TE/JBvk6aMu1eD ID4w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=1l2nJvkOMhf/Q6N3HmLSKyOtgxFfcSynbTgFlzQDiFk=; b=mqMxNoCYtqmDxyzJ0jXpXLdZCHpUVs1IIQ/d1rqhxCg/yya+F7ndmBJxT+KbBzvUjH vxfoHqC2d83DXWkkTkGOztaSuUash6H6uTAdVlTuOLa+IX4gjBCCIANqTueBjGS9TR7h 1l4DTgMzFIOZJzBK7ybRM90AFC+Ka8+XuD+sSsfz3hzLLiActljtcPZUsvzsLow2HR3+ d0e2aV8BrVx2lri9CSS1voPJIOJpkdBk29Sq/N9mx/nNMnbKm8RFgx1wwJN7x8rdZhq1 ZQVnxXKqu+9YsrfX7D6W5O40swBZINmqAjWOUM62gSACeN7hxTcgBv8UdqKvHR/MH9nV ZLKA== X-Gm-Message-State: AFqh2kpgvBeuP2KCt33J6ETJ5ZtQaslzu5FtCyqjjRUAfTtOkaVsCrzc AautQssJhKwjY76NpLX9MteL4ewSEcy4geeoDTqaHQ== X-Google-Smtp-Source: AMrXdXsYwjPZS4ox+2H3rYj/QQgBSwzO3H4oIQRT2gZTOuh5fIi6BNpysWWO7nt1I1ptsE2hVc85zlMZnIjIGDNHEQY= X-Received: by 2002:a05:6000:12cb:b0:28c:459a:d5d with SMTP id l11-20020a05600012cb00b0028c459a0d5dmr1888523wrx.654.1673556897672; Thu, 12 Jan 2023 12:54:57 -0800 (PST) MIME-Version: 1.0 References: <20230105090155.357604-1-irogers@google.com> <20230105090155.357604-2-irogers@google.com> In-Reply-To: From: Ian Rogers Date: Thu, 12 Jan 2023 12:54:45 -0800 Message-ID: Subject: Re: [PATCH v3 1/3] objtool: Install libsubcmd in build To: Nicolas Schier Cc: Josh Poimboeuf , Peter Zijlstra , Nathan Chancellor , Nick Desaulniers , Tom Rix , Masahiro Yamada , linux-kernel@vger.kernel.org, llvm@lists.linux.dev, Stephane Eranian , Andrii Nakryiko , Jiri Olsa , Arnaldo Carvalho de Melo , Namhyung Kim Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jan 12, 2023 at 12:32 PM Nicolas Schier wrote: > > On Thu, Jan 05, 2023 at 01:01:53AM -0800 Ian Rogers wrote: > > Including from tools/lib can create inadvertent dependencies. Install > > libsubcmd in the objtool build and then include the headers from > > there. > > > > Signed-off-by: Ian Rogers > > Reviewed-by: Nick Desaulniers > > Tested-by: Nick Desaulniers > > --- > > tools/objtool/Build | 2 -- > > tools/objtool/Makefile | 33 +++++++++++++++++++++++++-------- > > 2 files changed, 25 insertions(+), 10 deletions(-) > > > [...] > > diff --git a/tools/objtool/Makefile b/tools/objtool/Makefile > > index a3a9cc24e0e3..fd9b3e3113c6 100644 > > --- a/tools/objtool/Makefile > > +++ b/tools/objtool/Makefile > > @@ -12,9 +12,15 @@ srctree := $(patsubst %/,%,$(dir $(CURDIR))) > > srctree := $(patsubst %/,%,$(dir $(srctree))) > > endif > > > > -SUBCMD_SRCDIR = $(srctree)/tools/lib/subcmd/ > > -LIBSUBCMD_OUTPUT = $(or $(OUTPUT),$(CURDIR)/) > > -LIBSUBCMD = $(LIBSUBCMD_OUTPUT)libsubcmd.a > > +LIBSUBCMD_DIR = $(srctree)/tools/lib/subcmd/ > > +ifneq ($(OUTPUT),) > > + LIBSUBCMD_OUTPUT = $(abspath $(OUTPUT))/libsubcmd > > +else > > + LIBSUBCMD_OUTPUT = $(CURDIR)/libsubcmd > > +endif > > +LIBSUBCMD_DESTDIR = $(LIBSUBCMD_OUTPUT) > > Hi Ian, > > Is there a reason for distinguishing between $(LIBSUBCMD_DESTDIR) and > $(LIBSUBCMD_OUTPUT)? I believe the naming aligns with their use when passed to the corresponding sub-make variable, so "DESTDIR=$(LIBSUBCMD_DESTDIR)". It is possible to do other this, a slightly different convention is in some BPF related code: https://lore.kernel.org/lkml/20230112004024.1934601-1-irogers@google.com/ Thanks, Ian > Reviewed-by: Nicolas Schier