From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f170.google.com (mail-pl1-f170.google.com [209.85.214.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 993BA221FB6 for ; Mon, 22 Jun 2026 17:54:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=pass smtp.client-ip=209.85.214.170 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782150846; cv=pass; b=upvwN/AuDyJvb4EH1sWfkKciZxDgH1l0raXhY5slYOa0N9rfT/qvkhZgF+g82D33x4JJ2nyMEFljgpgSD67bKOpL1fVNWNb4nR/p9BdCUdDoCYIhkZTO7oUPJuTC2qDXsNftWn+23QU3cnverdZepvJArU7MO4NofhfwVWGf6G8= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782150846; c=relaxed/simple; bh=W7X4AUb3Et7sMWR1klAYzDvUIOZThnqlSXZOvunWVWU=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=FzDq5LChAdvdbf+kRPH5+Iyh5CAROAVNe1rBn01OsmTIgKOhfSQ9peJ/GrqJaVcG837znw26ZF/gD5c1VBtU3QmC9D8UyZY5mBGGzq/8BGFQPX8JlW2V4woUqYXMThaZ9G9hkQWtM/qdeDfao7jxT9KCUfAezKRjoAHrvBc7ZWU= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=JfsTRYAO; arc=pass smtp.client-ip=209.85.214.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="JfsTRYAO" Received: by mail-pl1-f170.google.com with SMTP id d9443c01a7336-2c73cefe192so2735ad.1 for ; Mon, 22 Jun 2026 10:54:05 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1782150845; cv=none; d=google.com; s=arc-20260327; b=TqxT3Zz91ymDDfBmKj3trOR6GRCYCzywNxbfCk7QowhjDVAPZxG3NJFe2tMwJwwfTk I6NxQdp1+3N8DVGKfNdoxx0s6DBGVVU/xpMLe6nqmg11ScZoUR+xdxAmtEtEInc0X3yN qolD+oDlo/bV8d96x40hIsFq9yaqY6xITQjrnXDEfIzCBWYp8DPdbWKuCOGW06ISCe/m MMYfJppzgWur7WZomNq9ciLHcqVMSojZYX4V7uf0HCpmkSdtPiH/IggPqpvplEYXkIlg NUnz/x8XQyGmCPouJis5KjVd2rvapxUBMqDaOgrSjD7jCPO855okM02IOUyRFc/8S0m5 FW/w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=RZOtWvhAwu9tRqSHi8Z01QBD2QiiSEUjq5c3ZDPlik8=; fh=SZjGcs2bLS0gID1hdJTdJzMKXTPN9gUhXl4jg7sfYsk=; b=S1rioXAZu8pbyjvxVCL6nVGgRom+G5MmFDpI99z91aogc13+IP9WYHHF/ag05Vjk2U Xn1eH3QSMiBE4oBs6gXU5yoxykvQ3d/NAgBXP5d4zAWlaFNse3g+zPQiOUnClGs1jPbI MnLoDByhneRDHRbFAcQlg85H3BGKgiVQwMl4Ew0o/Z23qUBhBmscbD45fmEEJMkVixyU XwSnKPWK95ivaahuCBz2ogJTKyotamofPlDuk1YzKTDE4XTyGNmXZYfVLQ8im7ltTSHJ oMqvqz+vlm1W0VMzYbd1H7mOEzHQqyLFCpiyIjGNVyt56ultKMAzUsacYMndvAus/AdZ E9tA==; darn=vger.kernel.org ARC-Authentication-Results: i=1; mx.google.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1782150845; x=1782755645; darn=vger.kernel.org; h=content-transfer-encoding:content-type:cc:to:subject:message-id :date:from:in-reply-to:references:mime-version:from:to:cc:subject :date:message-id:reply-to:content-type; bh=RZOtWvhAwu9tRqSHi8Z01QBD2QiiSEUjq5c3ZDPlik8=; b=JfsTRYAO/+FCjVC1jLXxGvju671cbHgEbn9RwkUHAKLGelCBCzNTd89WKiiC/PeJ8j 5EUblC10zmOrNhLiuSAMBFURPt1CT9csfKwgPw0Hw3xs1EGpHPu+EE9p18nNF/vW13y9 0d+qZW0OuL1AZKxbX1lCoZPltaqsq8IOgagnujtmzbMDEKMkHDJZN9D1LfoZwmAYZAfz F7iuJb8+8tUPJ5ug7KU/xidWTBFSBd5wrLe0Puv2/RO/e8xfy1wIUXzkJIVQk/kaXlJX aJL5gEzWb2WOPAyua7R9hzy4EWOe6aCoE7OhiRzwsxQy5Gm/tHLAEllMtSUeQsOCtasu 09sA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782150845; x=1782755645; h=content-transfer-encoding:content-type:cc:to:subject:message-id :date:from:in-reply-to:references:mime-version:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=RZOtWvhAwu9tRqSHi8Z01QBD2QiiSEUjq5c3ZDPlik8=; b=j1Pd/+HBVVUWvvY6rBYx+tOJvZvUAjBM7z0uy0YirDoiq5uWqw/Y6z8jKNGBAmJo65 KmUVsKRWnkBU+e1jNOxRBznKLusHZsEtdhhL/uUogtDsGROBX6+3KGwS0QBGCE2sGinv VgV4NvYXz8NxV/hA6Cz9mHknU73rD6fGXGYp42T6Puct4tQ/z0R21s54tqDCghduL2eR jF9I2g8BAxUXntodhUDVskewhZyfcjKPdk5hZP+fVpHCnlX5J+aF3Ad3ZH8XxpKcc/tT /hundLzvA+Do++hnUN5ksgfeYeoGuRfiHE254J7S0BD6Q/hga6SMZyVFhjX+zZJZPkgK fyUw== X-Forwarded-Encrypted: i=1; AHgh+Rpk3SioMpBn46moSN6yNNafCx8wSUgn/9OMcSdlTU1yWsQt0/NJW1b6VZEOt8gqQep0XR8ySzJgT8VsmPA=@vger.kernel.org X-Gm-Message-State: AOJu0Yzs3+83kw6YV98rKs6YQC7jTMoeutE198K1E3dnrU5355s9Fa8g 4Vg9aP37RKGguYWVOE1YdZk6Dn/QKbj/BKnjgpKTMzlvNEJShqjUh8vJU0Rjlu5pTugbb8r1Gng NplxygMVKftDOwG2YaCGS6EnFWfmAp3m1ntMXt2Q6bfVVY5ccjT+Gms5iY8A= X-Gm-Gg: AfdE7clVABpG/cP46+AM5gxB36q55cgmLbovJab4r7gh+OA9ZWHCwIlwIeCxlif/mOQ myHkXm04l1LgrHVGrXqS2SMY1LyUSRzp9aHbzHfO7ZdCYoW6ot4EpUWk1Y2itXknmQyQwLwLUyq pxkoOlbYtN+YHyo3/05aU0RhHhaM4Km2nQp9mrh6RLmIdm+R34BRFYZV+k4rEisNf4Rm9joMgdk AIHbZMa6WXRITvjT08yGYmv3VCbv2ZQiIBWgR2hhEFbchoavy9inhr1sXS61IiZWhWAy+Pac1/H qYHPDEcS X-Received: by 2002:a17:902:ebd1:b0:2c7:9e6a:1a8d with SMTP id d9443c01a7336-2c7c513e6f2mr214375ad.12.1782150844196; Mon, 22 Jun 2026 10:54:04 -0700 (PDT) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20260612012413.3253516-1-irogers@google.com> <26291bce-9be4-4edc-9dc5-4c685d9811c8@huawei.com> In-Reply-To: <26291bce-9be4-4edc-9dc5-4c685d9811c8@huawei.com> From: Ian Rogers Date: Mon, 22 Jun 2026 10:53:52 -0700 X-Gm-Features: AVVi8CfKGLu_QsQO_3I3w1dPwEJNp61fhexkDHwYkK88CU3ngqTCxUBhBLa54JQ Message-ID: Subject: Re: [PATCH v1] perf pmu: Recognize default_core as a core PMU in more places To: Qinxin Xia Cc: Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Namhyung Kim , Jiri Olsa , Adrian Hunter , James Clark , Dapeng Mi , Athira Rajeev , Thomas Falcon , linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Mon, Jun 22, 2026 at 2:11=E2=80=AFAM Qinxin Xia w= rote: > > > > On 2026/6/12 09:24:13, Ian Rogers wrote: > > The python metrics code used in places like ilist.py passes a > > pmu-filter of "default_core" on non-hybrid x86/ARM/.. systems. As a > > PMU like "cpu" isn't a literal name match then no PMU matches > > "default_core" and the events fail to parse for the metric. Fix the > > name matching and PMU lookup for "default_core" and check that it > > fixes ilist.py. > > > > Fixes: 74e2dbe7be50 ("perf tools: Add --pmu-filter option for filtering= PMUs") > > Signed-off-by: Ian Rogers > > --- > > Note: this bug is in 7.1 but it is a little too late to send for the > > release. It should get picked up via the fixes tag. > > --- > > tools/perf/util/pmu.c | 6 +++++- > > tools/perf/util/pmus.c | 2 ++ > > 2 files changed, 7 insertions(+), 1 deletion(-) > > > > diff --git a/tools/perf/util/pmu.c b/tools/perf/util/pmu.c > > index a550f030b85d..836e3b5615cd 100644 > > --- a/tools/perf/util/pmu.c > > +++ b/tools/perf/util/pmu.c > > @@ -2660,8 +2660,12 @@ bool perf_pmu__wildcard_match(const struct perf_= pmu *pmu, const char *wildcard_t > > pmu->name, > > pmu->alias_name, > > }; > > - bool need_fnmatch =3D strisglob(wildcard_to_match); > > + bool need_fnmatch; > > > > + if (pmu->is_core && !strcmp(wildcard_to_match, "default_core")) > > + return true; > > + > > + need_fnmatch =3D strisglob(wildcard_to_match); > > if (!strncmp(wildcard_to_match, "uncore_", 7)) > > wildcard_to_match +=3D 7; > > > > diff --git a/tools/perf/util/pmus.c b/tools/perf/util/pmus.c > > index 5e3f571450fe..e0a4cb2428ca 100644 > > --- a/tools/perf/util/pmus.c > > +++ b/tools/perf/util/pmus.c > > @@ -150,6 +150,8 @@ struct perf_pmu *perf_pmus__find(const char *name) > > bool core_pmu; > > unsigned int to_read_pmus =3D 0; > > > > + if (!strcmp(name, "default_core")) > > + return perf_pmus__find_core_pmu(); > > /* > > * Once PMU is loaded it stays in the list, > > * so we keep us from multiple reading/parsing > > Thank you for the fix, Ian. > In the previous patch, I overlooked the handling of the "default_core" > alias. Also, perhaps we can leave need_fnmatch as-is, since it doesn't > seem to affect anything here. Thanks. I moved need_fnmatch's initialization just to save some work in the "default_core" case where the value is unused. While leaving it in place would reduce the diff, I think the optimization is worth it as we would otherwise call strisglob when say iterating all metrics. Would it be okay to supply a Reviewed-by tag? I notice this fix is missing from perf-tools-next. Thanks! Ian > -- > Thanks, > Qinxin >