From: Alexandre Courbot <acourbot@chromium.org>
To: Hans Verkuil <hverkuil@xs4all.nl>
Cc: Tomasz Figa <tfiga@chromium.org>,
Paul Kocialkowski <paul.kocialkowski@bootlin.com>,
Maxime Ripard <maxime.ripard@bootlin.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Pawel Osciak <posciak@chromium.org>,
Linux Media Mailing List <linux-media@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] media: docs-rst: Document m2m stateless video decoder interface
Date: Tue, 22 Jan 2019 17:19:28 +0900 [thread overview]
Message-ID: <CAPBb6MVSJ1jfGXknJMFFkYjCy1z_mJ_MLOKB=kW1tYg33cppmg@mail.gmail.com> (raw)
In-Reply-To: <9c6ceddc-62c4-e4e7-9e27-b8213d8adb42@xs4all.nl>
On Tue, Jan 22, 2019 at 5:06 PM Hans Verkuil <hverkuil@xs4all.nl> wrote:
>
> On 01/22/2019 07:26 AM, Alexandre Courbot wrote:
> > Documents the protocol that user-space should follow when
> > communicating with stateless video decoders.
> >
> > The stateless video decoding API makes use of the new request and tags
> > APIs. While it has been implemented with the Cedrus driver so far, it
> > should probably still be considered staging for a short while.
> >
> > Signed-off-by: Alexandre Courbot <acourbot@chromium.org>
> > ---
> > Changes since v1:
> >
> > * Use timestamps instead of tags to reference frames,
> > * Applied Paul's suggestions to not require one frame worth of data per OUTPUT
> > buffer
> >
> > One of the effects of requiring sub-frame units to be submitted per request is
> > that the stateless decoders are not exactly "stateless" anymore: if a frame is
> > made of several slices, then the decoder must keep track of the buffer in which
> > the current frame is being decoded between requests, and all the slices for the
> > current frame must be submitted before we can consider decoding the next one.
> >
> > Also if we decide to force clients to submit one slice per request, then doesn't
> > some of the H.264 controls need to change? For instance, in the current v2
> > there is still a v4l2_ctrl_h264_decode_param::num_slices member. It is used in
> > Chromium to specify the number of slices given to the
> > V4L2_CID_MPEG_VIDEO_H264_SLICE_PARAMS control, but is apparently ignored by the
> > Cedrus driver. Maxime, can you comment on this?
> >
> > Documentation/media/uapi/v4l/dev-codec.rst | 5 +
> > .../media/uapi/v4l/dev-stateless-decoder.rst | 378 ++++++++++++++++++
> > 2 files changed, 383 insertions(+)
> > create mode 100644 Documentation/media/uapi/v4l/dev-stateless-decoder.rst
> >
>
> Thank you! I have uploaded a version of the V4L2 spec with this and the two older
> stateful codec patches applied:
>
> https://hverkuil.home.xs4all.nl/codec-api/uapi/v4l/dev-codec.html
Thanks! A v3 will likely be necessary (and I'll likely be more
reactive producing it) because of that one-slice-per-request
requirement. After discussing with Tomasz we think it would be
safer/simpler to require one frame per request in a first time, as we
initially agreed.
Anyway, we can discuss the details once Tomasz chimes in.
next prev parent reply other threads:[~2019-01-22 8:19 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-22 6:26 Alexandre Courbot
2019-01-22 8:05 ` Hans Verkuil
2019-01-22 8:19 ` Alexandre Courbot [this message]
2019-01-22 8:25 ` Tomasz Figa
2019-01-30 6:56 ` Randy Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAPBb6MVSJ1jfGXknJMFFkYjCy1z_mJ_MLOKB=kW1tYg33cppmg@mail.gmail.com' \
--to=acourbot@chromium.org \
--cc=hverkuil@xs4all.nl \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=maxime.ripard@bootlin.com \
--cc=mchehab@kernel.org \
--cc=paul.kocialkowski@bootlin.com \
--cc=posciak@chromium.org \
--cc=tfiga@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®