From: Nick Krause <xerofoify@gmail.com>
To: Mateusz Guzik <mguzik@redhat.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
USB list <linux-usb@vger.kernel.org>
Subject: Re: [PATCH] scatterlist.h: Change CONFIG_DEBUG_SG for ifdef statement in sg_set_bf
Date: Sun, 3 Aug 2014 00:31:30 -0400 [thread overview]
Message-ID: <CAPDOMVh16no_Lh=4cPEpXJheCU67DJJS6EBtg9AH_0yUXxXSPg@mail.gmail.com> (raw)
In-Reply-To: <20140803035931.GA24059@mguzik.redhat.com>
On Sat, Aug 2, 2014 at 11:59 PM, Mateusz Guzik <mguzik@redhat.com> wrote:
> On Sat, Aug 02, 2014 at 10:56:13PM -0400, Nicholas Krause wrote:
>> This changes the ifdef statement in sg_set_bg to !CONFIG_DEBUG_SG in order
>> to avoid a bug with xhci dequence/enquence functions.
>>
>> Signed-off-by: Nicholas Krause <xerofoify@gmail.com>
>> ---
>> include/linux/scatterlist.h | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/include/linux/scatterlist.h b/include/linux/scatterlist.h
>> index adae88f..62de7b3 100644
>> --- a/include/linux/scatterlist.h
>> +++ b/include/linux/scatterlist.h
>> @@ -111,7 +111,7 @@ static inline struct page *sg_page(struct scatterlist *sg)
>> static inline void sg_set_buf(struct scatterlist *sg, const void *buf,
>> unsigned int buflen)
>> {
>> -#ifdef CONFIG_DEBUG_SG
>> +#ifdef !CONFIG_DEBUG_SG
>> BUG_ON(!virt_addr_valid(buf));
>> #endif
>
> Have you tried compiling this? IIRC you said you would compile your
> stuff, what hapened to that?
>
> What exactly were you trying to achieve? Did this BUG_ON detect a
> problem on your system and now you are trying to silence it?
>
> The change would be wrong even if it compiled since it would just
> execute the assertion only when debug is disabled.
>
> --
> Mateusz Guzik
This is the mailing theme I am getting this from,[xhci] kernel BUG at
include/linux/scatterlist.h:115.
I hope this answers your question about the BUG_ON and yes I did
compile check it with make
M=include/. I also checked usb and usb net directories too.
Regards,
Nick
next prev parent reply other threads:[~2014-08-03 4:31 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-03 2:56 Nicholas Krause
2014-08-03 3:59 ` Mateusz Guzik
2014-08-03 4:31 ` Nick Krause [this message]
2014-08-03 5:02 ` Mateusz Guzik
2014-08-03 5:18 ` Nick Krause
2014-08-03 5:27 ` Nick Krause
2014-08-03 11:48 ` Mateusz Guzik
2014-08-04 10:04 ` Hugo Mills
2014-08-03 12:28 ` Sergei Shtylyov
2014-08-03 12:51 ` New follower Stefano Martinallo
2014-08-03 17:30 ` [PATCH] scatterlist.h: Change CONFIG_DEBUG_SG for ifdef statement in sg_set_bf Nick Krause
2014-08-04 10:07 ` Hugo Mills
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAPDOMVh16no_Lh=4cPEpXJheCU67DJJS6EBtg9AH_0yUXxXSPg@mail.gmail.com' \
--to=xerofoify@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mguzik@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®