From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932247AbcGLJx4 (ORCPT ); Tue, 12 Jul 2016 05:53:56 -0400 Received: from mail-wm0-f41.google.com ([74.125.82.41]:35031 "EHLO mail-wm0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753430AbcGLJxx (ORCPT ); Tue, 12 Jul 2016 05:53:53 -0400 MIME-Version: 1.0 In-Reply-To: References: <20160704115818.35614-1-prtvar.b@gmail.com> From: Ulf Hansson Date: Tue, 12 Jul 2016 11:53:50 +0200 Message-ID: Subject: Re: [PATCH] mmc: core: Extend sysfs with OCR register To: Bojan Prtvar Cc: linux-mmc , Jonathan Corbet , Linus Walleij , Adrian Hunter , Dong Aisheng , Wolfram Sang , Gwendal Grignou , Chaotian Jing , "linux-doc@vger.kernel.org" , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 6 July 2016 at 18:21, Ulf Hansson wrote: > On 4 July 2016 at 13:56, Bojan Prtvar wrote: >> Make operation conditions register (OCR) easily accessible from user space. >> >> Signed-off-by: Bojan Prtvar > > Thanks, applied for next! Amended the changelog with the explanation > why this change is wanted. I just realized that the OCR register is also available for SD cards. Could you perhaps cook a patch which adds this to sysfs for SD cards as well!? Kind regards Uffe > > Kind regards > Uffe > >> --- >> Documentation/mmc/mmc-dev-attrs.txt | 1 + >> drivers/mmc/core/mmc.c | 2 ++ >> 2 files changed, 3 insertions(+) >> >> diff --git a/Documentation/mmc/mmc-dev-attrs.txt b/Documentation/mmc/mmc-dev-attrs.txt >> index caa5557..8163eca 100644 >> --- a/Documentation/mmc/mmc-dev-attrs.txt >> +++ b/Documentation/mmc/mmc-dev-attrs.txt >> @@ -28,6 +28,7 @@ All attributes are read-only. >> preferred_erase_size Preferred erase size >> raw_rpmb_size_mult RPMB partition size >> rel_sectors Reliable write sector count >> + ocr Operation Conditions Register >> >> Note on Erase Size and Preferred Erase Size: >> >> diff --git a/drivers/mmc/core/mmc.c b/drivers/mmc/core/mmc.c >> index 5d438ad..1848334 100644 >> --- a/drivers/mmc/core/mmc.c >> +++ b/drivers/mmc/core/mmc.c >> @@ -727,6 +727,7 @@ MMC_DEV_ATTR(enhanced_area_offset, "%llu\n", >> MMC_DEV_ATTR(enhanced_area_size, "%u\n", card->ext_csd.enhanced_area_size); >> MMC_DEV_ATTR(raw_rpmb_size_mult, "%#x\n", card->ext_csd.raw_rpmb_size_mult); >> MMC_DEV_ATTR(rel_sectors, "%#x\n", card->ext_csd.rel_sectors); >> +MMC_DEV_ATTR(ocr, "%08x\n", card->ocr); >> >> static ssize_t mmc_fwrev_show(struct device *dev, >> struct device_attribute *attr, >> @@ -762,6 +763,7 @@ static struct attribute *mmc_std_attrs[] = { >> &dev_attr_enhanced_area_size.attr, >> &dev_attr_raw_rpmb_size_mult.attr, >> &dev_attr_rel_sectors.attr, >> + &dev_attr_ocr.attr, >> NULL, >> }; >> ATTRIBUTE_GROUPS(mmc_std); >> -- >> 2.8.0.GIT >>