From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3BBCCC4332F for ; Wed, 19 Oct 2022 12:34:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231652AbiJSMeQ (ORCPT ); Wed, 19 Oct 2022 08:34:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58938 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232911AbiJSMdn (ORCPT ); Wed, 19 Oct 2022 08:33:43 -0400 Received: from mail-pj1-x102e.google.com (mail-pj1-x102e.google.com [IPv6:2607:f8b0:4864:20::102e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AF63EA98E4 for ; Wed, 19 Oct 2022 05:13:05 -0700 (PDT) Received: by mail-pj1-x102e.google.com with SMTP id h14so171263pjv.4 for ; Wed, 19 Oct 2022 05:13:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=VMNFqQ1cKYZraeOUh2laCGjFrCge3hBVt6vY/kYdzro=; b=uCAZEUah1GXTO/Dhr3QPK4COCoFCeM8+Jjxsh4MLnKf1kiS4gCYn1tFEbS+Qx0GQZr lBKbx4uC7EboNj0hJmSxCxX7dYXYKZ6TMcAjDHAZvSUj8/wRjt9NaqPlLU1drz+/1cth A0SDNx2KUz3G2e5yuejO1SKwBWH0Xq/88Oo8IpcpmMYdLk8GLJcz8xf85uJDV+HoXfhs q0ctj00NM7PQDZemzH7QSJyup22Fz1Lh6PN2gCzIp+Gsu5+9wiKeEM7kiw2zYcFA5eAk bXoQip1KEgt9apacmG85i9WjsEXPBj1xloNylB25uCs0tHmqknYZuWAgfPq+lquO777l cKAw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=VMNFqQ1cKYZraeOUh2laCGjFrCge3hBVt6vY/kYdzro=; b=b8oZrbNgfE9qqttmoP5dSQoj+9pVHv9S1RjGL1XO0HHHzoCKhfc5JpRq++/aZm7cOm kVQfJd+8mts8Z4nDIypgEYyTDp5wJNZtTEZOHjjPhxNJalSDB3dsNST3g7g+8GMjj9tM 2Pn1wRynTrAco78txWkyJko/bxmIuBdpKNt+2NeNtdSI8PoM7qN/xG5XjTY4p5B/lyp3 bLiv2yBTt8CdkLuCpNz3iynyg1P+T6B5pKFGWFYnjrYZEeuS4IUmi+3XhqiShxfQ2JO2 2YTBUFKu/cKtmgUGhqSkCd3ZjEIc4Nix33R0jnQhPk2KHldYZHfqXhpVughyJScfvDS5 PrCA== X-Gm-Message-State: ACrzQf2NQDkvBo67yu9jOtJHiYeSe9Ap1xPqxwJ8vAouomTeKPWk1FnI 8LrlS34YoNGXxVKaYjsXT+0hptb4uTAbnQ2XYt1awWemN/4QjA== X-Google-Smtp-Source: AMsMyM6WQNKXibXuVfWu8N49gAxdnh4vFghljtoHG++6NQujmf4jWPdnvyEXOs837QKkhfJvV65lOWL+4b+PAZmI4Cs= X-Received: by 2002:a17:903:246:b0:179:96b5:1ad2 with SMTP id j6-20020a170903024600b0017996b51ad2mr7993669plh.37.1666180690956; Wed, 19 Oct 2022 04:58:10 -0700 (PDT) MIME-Version: 1.0 References: <20221018145348.4051809-1-amit.pundir@linaro.org> In-Reply-To: <20221018145348.4051809-1-amit.pundir@linaro.org> From: Ulf Hansson Date: Wed, 19 Oct 2022 13:57:34 +0200 Message-ID: Subject: Re: [PATCH] arm64: dts: qcom: qrb5165-rb5: Disable cpuidle states To: Amit Pundir Cc: Sudeep Holla , Bjorn Andersson , Andy Gross , Maulik Shah , Dmitry Baryshkov , Rob Herring , Konrad Dybcio , Krzysztof Kozlowski , linux-arm-msm , dt , lkml Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 18 Oct 2022 at 16:53, Amit Pundir wrote: > > Disable cpuidle states for RB5. These cpuidle states > made the device highly unstable and it runs into the > following crash frequently: > > [ T1] vreg_l11c_3p3: failed to enable: -ETIMEDOUT > [ T1] qcom-rpmh-regulator 18200000.rsc:pm8150l-rpmh-regulators: ldo11: devm_regulator_register() failed, ret=-110 > [ T1] qcom-rpmh-regulator: probe of 18200000.rsc:pm8150l-rpmh-regulators failed with error -110 > > Fixes: 32bc936d7321 ("arm64: dts: qcom: sm8250: Add cpuidle states") > Signed-off-by: Amit Pundir > --- > arch/arm64/boot/dts/qcom/qrb5165-rb5.dts | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/qrb5165-rb5.dts b/arch/arm64/boot/dts/qcom/qrb5165-rb5.dts > index cc003535a3c5..f936c41bfbea 100644 > --- a/arch/arm64/boot/dts/qcom/qrb5165-rb5.dts > +++ b/arch/arm64/boot/dts/qcom/qrb5165-rb5.dts > @@ -251,6 +251,14 @@ qca639x: qca639x { > > }; > > +&LITTLE_CPU_SLEEP_0 { > + status = "disabled"; > +}; > + > +&BIG_CPU_SLEEP_0 { > + status = "disabled"; > +}; > + > &adsp { > status = "okay"; > firmware-name = "qcom/sm8250/adsp.mbn"; > -- > 2.25.1 Disabling the CPU idlestates, will revert us back to using only the WFI state. An option that probably works too is to just drop the idlestate for the CPU cluster. Would you mind trying the below and see if that works too? diff --git a/arch/arm64/boot/dts/qcom/sm8250.dtsi b/arch/arm64/boot/dts/qcom/sm8250.dtsi index c32227ea40f9..c707a49e8001 100644 --- a/arch/arm64/boot/dts/qcom/sm8250.dtsi +++ b/arch/arm64/boot/dts/qcom/sm8250.dtsi @@ -700,7 +700,6 @@ CPU_PD7: cpu7 { CLUSTER_PD: cpu-cluster0 { #power-domain-cells = <0>; - domain-idle-states = <&CLUSTER_SLEEP_0>; }; }; Kind regards Uffe