mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Ulf Hansson <ulf.hansson@linaro.org>
To: Sylwester Nawrocki <s.nawrocki@samsung.com>,
	Krzysztof Kozlowski <krzk@kernel.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
	Marek Szyprowski <m.szyprowski@samsung.com>,
	Mark Brown <broonie@kernel.org>, Inki Dae <inki.dae@samsung.com>,
	"linux-samsung-soc@vger.kernel.org"
	<linux-samsung-soc@vger.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Linux ARM <linux-arm-kernel@lists.infradead.org>,
	Andrzej Hajda <a.hajda@samsung.com>
Subject: Re: [FAIL bisect] Sound card probe error
Date: Mon, 14 May 2018 14:30:47 +0200	[thread overview]
Message-ID: <CAPDyKFoQFxHqupyqH3JsriUDdJHpUDecD37OqOSKn-sT26gEiA@mail.gmail.com> (raw)
In-Reply-To: <b193b8a0-ad25-1895-8f8d-ffab97261dc1@samsung.com>

On 14 May 2018 at 14:22, Sylwester Nawrocki <s.nawrocki@samsung.com> wrote:
> Hi,
>
> On 05/14/2018 12:17 PM, Krzysztof Kozlowski wrote:
>
>> Bisected to:
>> 8c123c14bbba4add148536b6d47a9226deda2f7a is the first bad commit
>> commit 8c123c14bbba4add148536b6d47a9226deda2f7a
>> Author: Ulf Hansson <ulf.hansson@linaro.org>
>> Date:   Thu Apr 26 10:53:06 2018 +0200
>>
>>     driver core: Respect all error codes from dev_pm_domain_attach()
>>
>>     The limitation of being able to check only for -EPROBE_DEFER from
>>     dev_pm_domain_attach() has been removed. Hence let's respect all error
>>     codes and bail out accordingly.
>>
>>     Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
>>     Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
>>     Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
>
> The DRM driver creates the HDMI codec but its registration fails, due
> to some missing clocks. The clock are missing because the exynos5-subcmu
> driver probing fails.
>
> [    0.678578] exynos5-subcmu: probe of GSC failed with error -17
> [    0.679250] exynos5-subcmu: probe of MFC failed with error -17
> [    0.679992] exynos5-subcmu: probe of DISP failed with error -17
>
> The exynos5-subcmu driver before registering platform device makes
> of_genpd_add_device() call, so in platform_drv_probe() dev_pm_domain_attach()
> call will fail, as dev->pm_domain is already set. Previously the error
> was masked by code removed in the above commit and platform_drv_probe()
> was could complete successfully.

Thanks for providing this information!

I was about to tell that I overlooked the fact that there is more than
one way to assign PM domain pointers to devices. To fix the problem,
dev_pm_domain_attach() should return 0, not -EEXIST when it finds and
existing PM domain pointer.

Does the below patch fix the problem?

From: Ulf Hansson <ulf.hansson@linaro.org>
Date: Mon, 14 May 2018 14:26:16 +0200
Subject: [PATCH] PM / Domains: Don't return -EEXIST at attach when PM domain
 exists

As dev_pm_domain_attach() isn't the only way to assign PM domain pointers
to devices, clearly we must allow a device to have the pointer already
being assigned. For this reason, return 0 instead of -EEXIST.

Reported-by: Krzysztof Kozlowski <krzk@kernel.org>
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
---
 drivers/base/power/common.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/base/power/common.c b/drivers/base/power/common.c
index 5e4b481..390868c 100644
--- a/drivers/base/power/common.c
+++ b/drivers/base/power/common.c
@@ -106,7 +106,7 @@ int dev_pm_domain_attach(struct device *dev, bool power_on)
        int ret;

        if (dev->pm_domain)
-               return -EEXIST;
+               return 0;

        ret = acpi_dev_pm_attach(dev, power_on);
        if (!ret)
-- 
2.7.4

  parent reply	other threads:[~2018-05-14 12:30 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20180514101728epcas4p3108760546a415b36252df93dfe38e0fb@epcas4p3.samsung.com>
2018-05-14 10:17 ` Krzysztof Kozlowski
2018-05-14 12:22   ` Sylwester Nawrocki
2018-05-14 12:29     ` Krzysztof Kozlowski
2018-05-14 12:36       ` Marek Szyprowski
2018-05-14 12:40       ` Sylwester Nawrocki
2018-05-14 12:45         ` Krzysztof Kozlowski
2018-05-14 12:50           ` Krzysztof Kozlowski
2018-05-14 13:34             ` Sylwester Nawrocki
2018-05-14 12:30     ` Ulf Hansson [this message]
2018-05-14 12:43       ` Krzysztof Kozlowski
2018-05-14 14:35         ` Ulf Hansson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAPDyKFoQFxHqupyqH3JsriUDdJHpUDecD37OqOSKn-sT26gEiA@mail.gmail.com \
    --to=ulf.hansson@linaro.org \
    --cc=a.hajda@samsung.com \
    --cc=broonie@kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=inki.dae@samsung.com \
    --cc=krzk@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=m.szyprowski@samsung.com \
    --cc=rafael.j.wysocki@intel.com \
    --cc=s.nawrocki@samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®