From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf1-f44.google.com (mail-lf1-f44.google.com [209.85.167.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6D7A23947A5 for ; Thu, 26 Mar 2026 12:34:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=pass smtp.client-ip=209.85.167.44 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774528496; cv=pass; b=eksnJp9WlMcS0B3ZkhNZU3QOsYKNxalyWBvKEMZ+j1k43C+uVvTaIWLq/X+JCkG8K+ADhS73l4TprbDtjhanG465SIRkzMqefbweQ5Wljnvjch1felun8utF4s5m+hFJzXirxN2FQcAhgpU4WJ/PIcnpi8dsb53TcyOheIdgAeQ= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774528496; c=relaxed/simple; bh=p+oFtCDEdez9suBe9pe1fZYHjfKOx23fi/EG0H17aGQ=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=qFkEruigKp3QQzYr1KpBVcO98xKdy5gYqDa9DMT76sAUKH7+GPCDea+merdmt5jQmog84SxiPZ4/TERfJngo6zyWt9MMT8TXMv+13JfY1ukLFD3Q6thJQuA6bOZj0e0KwXpg/VPI3Y/v9BWdvCb+Rle6FWGWzbfnl6m3Jl7pJ2A= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=hZZYgoI3; arc=pass smtp.client-ip=209.85.167.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="hZZYgoI3" Received: by mail-lf1-f44.google.com with SMTP id 2adb3069b0e04-5a0ff30b240so1055407e87.0 for ; Thu, 26 Mar 2026 05:34:55 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1774528494; cv=none; d=google.com; s=arc-20240605; b=BbxRtYUShENHHVw23WvHsBf386M2i+s/H7RZQsN1nOcVChYdbHh49YnOYrMmZN8F1u LVJOjE/aVJjn7GJpY+JrbaqmdIHs58AjmxJzXJU2r5HRiqR/P1rsyQrZTbGDBeL0TU1a ee47amdPNpLkBznxoXBrdTr8YuV/j+tqY1dG+GWCfzGKlptut0hkiMLBtq2FVMJ/m9hd acZ3JMj+sr5lvwFetXiV6vtYi/lKeVFsK+1tBALTrpWR4qMPefBe1UPMehVuMI7DdIH7 MTJoNmEX+Muff5+Vp20OcehZEHIunN/K96d94kOLbeDaPHdTBk2M3QJ2HWjw1ZYMi1fz N96g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:dkim-signature; bh=fMtjTcJq5eIA2qihI+2nGicxmL8Td67ZjB3pSoQD8ho=; fh=696uaa/rDjxEjPSw+5rHDIgNN1VTSvWcJgnYog2PlUo=; b=JriFvcbb9YZhxYMKE3vaNlyGVLhPEQvuJsy9th02TvrTJ68owMcN0TNqSbTvWQ1+JB NDlV3OqLJ98DFfAcGNPowG9/qUtHSjMwC1OLj+aSUyl+nuJpKKHMGQ2Ab6x9wJpHWSlQ NKokP9HTAk5tJ+NKzWkKbU7jHAqcft5GstZqvOI7oDbpQqNVV/BP75nOEau06IvPt7I3 2bJ48YKlKZDSBsRTL77Nx7L0klwnFBHaktWQFaIwpHM4viMO87cImr6UjVrKpeH9UB6z 8PmDm4Tz3XGpEJ+mpaaHpzlt9bmL1SecRyBKAFVmrusuOP2iWOMs+lbLqtAiC5//YUVp ppAA==; darn=vger.kernel.org ARC-Authentication-Results: i=1; mx.google.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1774528494; x=1775133294; darn=vger.kernel.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=fMtjTcJq5eIA2qihI+2nGicxmL8Td67ZjB3pSoQD8ho=; b=hZZYgoI3hZE5jscwY/qgSvmSORNBapT/tnNUPeOYH6nSseyEGXl7xg043KwGvyQ5XQ 39qBu0hUvs+id894K45MXjjb6hRr2s9+KV0jHYz905AFh/zJF7tkMXcKUwMOQMSe/sZ9 c+AvYiJN5f/KXuqWaYijmCA3iFUUPDMvQ1WW59A6rMVtqtRnUHyxfrkQmJ7tt/emBdMo aEOs1SlkXT0z8GwwZeXG/0zvlgrHD69dX8QVk5naCNB7QHExGd4Gi9ZNpyQO9a4WAwCJ Aa+kPaoFIfonDIoOk41YCP5QqlQgOfSyl4n46heEFQtmzQF+gXSFC/nGnPWaiBJK/cul gZyA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774528494; x=1775133294; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=fMtjTcJq5eIA2qihI+2nGicxmL8Td67ZjB3pSoQD8ho=; b=ZIJa0zrF+bJg1KDveXDZkn9OcqoLkp/yjesx99Q6S4x/JONUyJ/2cBlWmpOgqDkSP+ 1GtT9Za8tgj2xu3f8lVsPUKCEMf/tqgWpNPuS5oX4PnKM2w6mNDQPY6EV4F6EGp7viL5 SvgKbnldyMjBnICBi6IXx9lkLhJoXSicNEJyTFUZzUYeCupxTRBVROBEqBip2k810HTo 4kMtBruxlb8GVNuDJRXdGWVFSXl2vc7miVCZeZoZSdDh3mmGoK11Al8cT+j2lxrQ2MyC 1zO3nX5HqZ9JyTgEysUr5SWHaZWaPYyq5e8RoGvI28VmHku3M2+Ve6DEWyKZ59nhoMEW R5aQ== X-Forwarded-Encrypted: i=1; AJvYcCUZaRfL0zHVGIbOT8D6zbvJ5CUenm0PhePAEBdVaWFTT9YTR8nsNo0kbbSCcvxEhcWUJTtfUwUD2vYyOi4=@vger.kernel.org X-Gm-Message-State: AOJu0YzeSTdq26aNbYYJ31e/CegxCK8y4kPFyWebDkwxgSdPhtOqH786 24mUM5zJRekafqrT1E5dc1FRRS2kFP38GZ/McmaSDOlyqNYAeTfVYc0oWkHdCIas8EpjahPIoVs c8t5FT77QSfEVcf3/pqdI9usrfN2oGH61tTHTSJ6BEqZfYeRy3luZRCo= X-Gm-Gg: ATEYQzwUp9glFSZZGdVMBvCSr1wUMwAJDAZmIns02QapY4hPt/XOYjOHqdlFqx33BeU FzKG9SuFGIrzhaJa7Sev6L+5A+tV16iDQZwYtjjjDSNIwoqg6i4cjJKqjobunM2iEBSQ/teDmg+ /WrJM59M5TjkKKzBHhTVxKX+LagPHHeLwEd08DxNjdFzPHYJihQa5XO8tNj8eVfhg71DE6i/EYW 5BUDw8McgFgDGzwZbBPgPIjzWHLGpbN7wvpWMCHzbof1kWmZHydXdcFsCYebaLnBADBF+zrzuXU D0xqmYM= X-Received: by 2002:a05:6512:3e0c:b0:5a1:43f3:764a with SMTP id 2adb3069b0e04-5a29b979b0amr2997503e87.5.1774528493504; Thu, 26 Mar 2026 05:34:53 -0700 (PDT) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20260326030759.8107-1-ot_cathy.xu@mediatek.com> In-Reply-To: <20260326030759.8107-1-ot_cathy.xu@mediatek.com> From: Ulf Hansson Date: Thu, 26 Mar 2026 13:34:16 +0100 X-Gm-Features: AQROBzAUMJTYzzyeSawXUe9OdLfBc-C70N5GR1BByMjzhb7eLn_1dlJggBGZnww Message-ID: Subject: Re: [PATCH RESEND] mmc: mtk-sd: disable new_tx/rx and modify related settings for mt8189 To: Cathy Xu Cc: Chaotian Jing , Matthias Brugger , AngeloGioacchino Del Regno , Louis-Alexis Eyraud , linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, Mengqi Zhang , Wenbin Mei , Andy-ld Lu , Axe Yang , Yong Mao , stable@vger.kernel.org Content-Type: text/plain; charset="UTF-8" On Thu, 26 Mar 2026 at 04:08, Cathy Xu wrote: > > Disable new_tx/rx to avoid data transmission instability, and adjust > .data_tune, .stop_dly_sel, and .pop_en_cnt to fit the overall > configuration after disabling new_tx/rx, making it more compatible > with mt8189. > > Fixes: 846a3a2fdff5 ("mmc: mtk-sd: add support for MT8189 SoC") > Cc: stable@vger.kernel.org > Tested-by: Louis-Alexis Eyraud > Signed-off-by: Cathy Xu Applied for fixes and by dropping the stable-tag as it's superfluous in this case. Thanks! Kind regards Uffe > --- > drivers/mmc/host/mtk-sd.c | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/drivers/mmc/host/mtk-sd.c b/drivers/mmc/host/mtk-sd.c > index 302ac8529c4f..b2680cc054bd 100644 > --- a/drivers/mmc/host/mtk-sd.c > +++ b/drivers/mmc/host/mtk-sd.c > @@ -682,15 +682,15 @@ static const struct mtk_mmc_compatible mt8189_compat = { > .needs_top_base = true, > .pad_tune_reg = MSDC_PAD_TUNE0, > .async_fifo = true, > - .data_tune = true, > + .data_tune = false, > .busy_check = true, > .stop_clk_fix = true, > - .stop_dly_sel = 1, > - .pop_en_cnt = 2, > + .stop_dly_sel = 3, > + .pop_en_cnt = 8, > .enhance_rx = true, > .support_64g = true, > - .support_new_tx = true, > - .support_new_rx = true, > + .support_new_tx = false, > + .support_new_rx = false, > .support_spm_res_release = true, > }; > > -- > 2.45.2 >