From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S932143AbdJJIJw (ORCPT <rfc822;w@1wt.eu>);
        Tue, 10 Oct 2017 04:09:52 -0400
Received: from mail-it0-f51.google.com ([209.85.214.51]:46675 "EHLO
        mail-it0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1755705AbdJJIJu (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 10 Oct 2017 04:09:50 -0400
X-Google-Smtp-Source: AOwi7QBpDg34pRqrtsJweioqwCjZ6/apGt0q0Z4wtErQrt1DSZLeVGQ7hnB9Qvc7V/Odn+D5dbo7LjvfoUheszG80nc=
MIME-Version: 1.0
In-Reply-To: <1507620951.19789.7.camel@mhfsdcap03>
References: <1507604480-23246-1-git-send-email-chaotian.jing@mediatek.com>
 <1507604480-23246-2-git-send-email-chaotian.jing@mediatek.com>
 <CAPDyKFrqv5tt8Exq1msUBbMEROam2c+YnStazsf5SPj-NLrGSg@mail.gmail.com> <1507620951.19789.7.camel@mhfsdcap03>
From: Ulf Hansson <ulf.hansson@linaro.org>
Date: Tue, 10 Oct 2017 10:09:49 +0200
Message-ID: <CAPDyKFppTCdaMizSGTjrfgsbMuHCsNi+knHVf9ibxgrAQ0GD2w@mail.gmail.com>
Subject: Re: [PATCH v3 01/12] mmc: mediatek: add support of mt2701/mt2712
To: Chaotian Jing <chaotian.jing@mediatek.com>
Cc: Rob Herring <robh+dt@kernel.org>, Mark Rutland <mark.rutland@arm.com>,
        Matthias Brugger <matthias.bgg@gmail.com>,
        Catalin Marinas <catalin.marinas@arm.com>,
        Will Deacon <will.deacon@arm.com>, yong mao <yong.mao@mediatek.com>,
        Linus Walleij <linus.walleij@linaro.org>,
        Heiner Kallweit <hkallweit1@gmail.com>, Phong LE <ple@baylibre.com>,
        "linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        linux-mediatek@lists.infradead.org,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        srv_heupstream <srv_heupstream@mediatek.com>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 10 October 2017 at 09:35, Chaotian Jing <chaotian.jing@mediatek.com> wrote:
> On Tue, 2017-10-10 at 09:26 +0200, Ulf Hansson wrote:
>> [...]
>>
>> > +
>> > +static const struct of_device_id msdc_of_ids[] = {
>> > +       { .compatible = "mediatek,mt8135-mmc", .data = &mt8135_compat},
>> > +       { .compatible = "mediatek,mt8173-mmc", .data = &mt8173_compat},
>> > +       { .compatible = "mediatek,mt2701-mmc", .data = &mt2701_compat},
>> > +       { .compatible = "mediatek,mt2712-mmc", .data = &mt2712_compat},
>> > +       {}
>> > +};
>> > +MODULE_DEVICE_TABLE(of, msdc_of_ids);
>>
>> As already stated in the other reply. These new compatible changes
>> needs to be discussed and acked before the driver starts using them.
>>
>> In other words, make patch3 to precede this one.
> but, then there will have a probe issue as mentioned in previous mail
> list. that's why I separate the binding file changes to 2 patches.

That sounds seriously wrong. Aren't the bindings backwards compatible?

Kind regards
Uffe