From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933634AbbJHRft (ORCPT ); Thu, 8 Oct 2015 13:35:49 -0400 Received: from mail-wi0-f173.google.com ([209.85.212.173]:37974 "EHLO mail-wi0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933345AbbJHRfs (ORCPT ); Thu, 8 Oct 2015 13:35:48 -0400 MIME-Version: 1.0 In-Reply-To: <1444094562-31165-2-git-send-email-mw@semihalf.com> References: <1444094562-31165-1-git-send-email-mw@semihalf.com> <1444094562-31165-2-git-send-email-mw@semihalf.com> Date: Thu, 8 Oct 2015 19:35:46 +0200 Message-ID: Subject: Re: [PATCH 1/8] mmc: sdhci-pxav3: remove broken clock base quirk for Armada 38x sdhci driver From: Ulf Hansson To: Marcin Wojtas Cc: "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , linux-mmc , Sebastian Hesselbarth , Andrew Lunn , Jason Cooper , Thomas Petazzoni , Gregory Clement , Nadav Haklai , Lior Amsalem , Tawfik Bayouk , jaz@semihalf.com, "# 4.0+" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 6 October 2015 at 03:22, Marcin Wojtas wrote: > From: Nadav Haklai > > shci-pxav3 driver is enabling by default the > SDHCI_QUIRK_CAP_CLOCK_BASE_BROKEN quirk. However this quirk is not > required for Armada 38x and leads to wrong clock setting in the divider. > > Signed-off-by: Nadav Haklai > Signed-off-by: Marcin Wojtas > Cc: # v4.2 Thanks, applied for fixes! Kind regards Uffe > --- > drivers/mmc/host/sdhci-pxav3.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/mmc/host/sdhci-pxav3.c b/drivers/mmc/host/sdhci-pxav3.c > index 946d37f..976cddd 100644 > --- a/drivers/mmc/host/sdhci-pxav3.c > +++ b/drivers/mmc/host/sdhci-pxav3.c > @@ -135,6 +135,7 @@ static int armada_38x_quirks(struct platform_device *pdev, > struct sdhci_pxa *pxa = pltfm_host->priv; > struct resource *res; > > + host->quirks &= ~SDHCI_QUIRK_CAP_CLOCK_BASE_BROKEN; > host->quirks |= SDHCI_QUIRK_MISSING_CAPS; > res = platform_get_resource_byname(pdev, IORESOURCE_MEM, > "conf-sdio3"); > -- > 1.8.3.1 >