From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S967005AbeBNJxW (ORCPT ); Wed, 14 Feb 2018 04:53:22 -0500 Received: from mail-it0-f42.google.com ([209.85.214.42]:40305 "EHLO mail-it0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S966980AbeBNJxP (ORCPT ); Wed, 14 Feb 2018 04:53:15 -0500 X-Google-Smtp-Source: AH8x2254drjZ9c/8/bmpdmOrvyvGCUSU++BxetNYzRS5Mbcut7NYJOTwDIpRXy3nQuVryA/iFV/GRCiLuIm5//UYtrw= MIME-Version: 1.0 In-Reply-To: <20180205125029.21570-9-kishon@ti.com> References: <20180205125029.21570-1-kishon@ti.com> <20180205125029.21570-9-kishon@ti.com> From: Ulf Hansson Date: Wed, 14 Feb 2018 10:53:14 +0100 Message-ID: Subject: Re: [PATCH v2 08/16] mmc: sdhci-omap: Add support to override f_max and iodelay from pdata To: Kishon Vijay Abraham I Cc: Tony Lindgren , Adrian Hunter , Rob Herring , Mark Rutland , Russell King , "linux-mmc@vger.kernel.org" , devicetree@vger.kernel.org, Linux Kernel Mailing List , linux-omap , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 5 February 2018 at 13:50, Kishon Vijay Abraham I wrote: > DRA74x EVM Rev H EVM comes with revision 2.0 silicon. However, earlier > versions of EVM can come with either revision 1.1 or revision 1.0 of > silicon. > > The device-tree file is written to support rev 2.0 of silicon. > pdata-quirks are used to then override the settings needed for > PG 1.1 silicon. > > PG 1.1 silicon has limitations w.r.t frequencies at which MMC1/2/3 > can operate as well as different IOdelay numbers. I fail to understand the need for platform data. Why can't DT be used for the older revisions as well? > > Add support in sdhci-omap driver to get platform data if available > (added using pdata quirks) and override the data (max-frequency and > iodelay data) obtained from device tree. [...] Kind regards Uffe