From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AB421C33C9A for ; Thu, 14 Nov 2019 14:19:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7AAE420706 for ; Thu, 14 Nov 2019 14:19:11 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Ml/cOiBy" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726952AbfKNOTK (ORCPT ); Thu, 14 Nov 2019 09:19:10 -0500 Received: from mail-vs1-f66.google.com ([209.85.217.66]:36381 "EHLO mail-vs1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726516AbfKNOTI (ORCPT ); Thu, 14 Nov 2019 09:19:08 -0500 Received: by mail-vs1-f66.google.com with SMTP id q21so3956994vsg.3 for ; Thu, 14 Nov 2019 06:19:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=mF9QJkIN8Qk+EGkxO+jVoBbFR7FMIpRA3CjmA8m3d7Y=; b=Ml/cOiBysl9RO47an1PTBHLBV9w/7hUJ5RTzC9SA1Mtzt+/DhPojZxalupt6UqYxdQ Z6JVbt31LezzDArBbJjiKL2Y5fmaM9zvJ7unZ4BgDdfgF9mW0AXrx+BoEeZrvPk8v4Na vFp/6s+uvZ+tazuT9dOHmkygy3CCIjNpWHbDS4RdoO1Ax+9gtplcOkQGyvu+xkTNpwvf BQOZDKA6W1skAgd0wkcQQjy4KYmerLP5JSisRTka6/XXrK6yecbJSVLJ+KeRGxhACdKH 8qTLgfs22vZ7hOJ8kyH9jH6x5yGzqyYsrJoASTpX+UbbwnAEwMt16yGMLqfSMGWl0VET jivg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=mF9QJkIN8Qk+EGkxO+jVoBbFR7FMIpRA3CjmA8m3d7Y=; b=tOo8lRo0fBa6fWVQwuaBKjx7Ros1Xt+2JQhr6HGepGUpfd5UE+t6EwnsC//8GbU68Z i0QYqW+5OLCdqO8WzzFvL3EVnFOGxXjXbH492EzxHjuTBRS3gFbmMp0FMfchLOfabQF6 LDvQyXJSrBuAUguV+H8Br3E+u5ML3kpKIp6w7IVKHJacAFra0nVrcZ2kg1kc5oJ4snrt 0500DZzkLU+d/esyFjNSmIkywuS+IVgceGtTVhb+Gfqo9TWfvuJc5bvfMDE3jzp5SmZ7 qY7EdkkkafQiDXlx922i2leaQB75B/w1bdtexLC09clouMfX0Vlq/l/z1olmwrtUJVll bhUg== X-Gm-Message-State: APjAAAX0U4/3FJ+hnYhKnMP4+N9UmBX4Enk2AccdkeCbJcnnl2ZABOg7 vdQtyNEZRVycrc16RjFULCt1eCcODaozgT1qfp8APA== X-Google-Smtp-Source: APXvYqwgCmwHYSDSJ68Em4upupN+YGH3wrjpaM8fSyc24xbueo9viz0GrcVPQXBkKEvWLAXn8LtIFd6tV6myvBaAjVM= X-Received: by 2002:a05:6102:36d:: with SMTP id f13mr6019578vsa.34.1573741145328; Thu, 14 Nov 2019 06:19:05 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Ulf Hansson Date: Thu, 14 Nov 2019 15:18:29 +0100 Message-ID: Subject: Re: [PATCH v3 00/12] OpenPandora: make wl1251 connected to mmc3 sdio port of OpenPandora work again To: "H. Nikolaus Schaller" Cc: =?UTF-8?Q?Beno=C3=AEt_Cousson?= , Tony Lindgren , Rob Herring , Mark Rutland , Russell King , Kalle Valo , Mike Rapoport , David Sterba , "Rafael J. Wysocki" , Petr Mladek , Sakari Ailus , Kefeng Wang , Yangtao Li , Alexios Zavras , Thomas Gleixner , Allison Randal , Greg Kroah-Hartman , John Stultz , Bjorn Helgaas , linux-omap , DTML , Linux Kernel Mailing List , Linux ARM , "linux-mmc@vger.kernel.org" , linux-wireless , netdev , Discussions about the Letux Kernel , kernel@pyra-handheld.com Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 7 Nov 2019 at 11:31, H. Nikolaus Schaller wrote: > > > * add a revisit note for special wl1251 handling code because it should > be solved more generic in mmc core - suggested by Ulf Hansson > * remove init_card callback from platform_data/hsmmc-omap.h - suggested by Ulf Hansson > * remove obstructive always-on for vwlan regulator - suggested by Ulf Hansson > * rename DT node - suggested by Rob Herring > * fix ARM: dts: subject prefix - suggested by Tony Lindgren > * also remove omap2_hsmmc_info and obc-y line in Makefile - suggested by Tony Lindgren No further comments from my side. Let's just agree on how to deal with the ti,power-gpio, then I can apply this. Thanks a lot for fixing all this mess! Kind regards Uffe > > PATCH V2 2019-10-19 20:41:47: > * added acked-by for wl1251 patches - Kalle Valo > * really removed old pdata-quirks code (not through #if 0) > * splited out a partial revert of > efdfeb079cc3b ("regulator: fixed: Convert to use GPIO descriptor only") > because that was introduced after v4.19 and stops the removal of > the pdata-quirks patch from cleanly applying to v4.9, v4.14, v4.19 > - reported by Sasha Levin > * added a new patch to remove old omap hsmmc since pdata quirks > were last user - suggested by Tony Lindgren > > PATCH V1 2019-10-18 22:25:39: > Here we have a set of scattered patches to make the OpenPandora WiFi work again. > > v4.7 did break the pdata-quirks which made the mmc3 interface > fail completely, because some code now assumes device tree > based instantiation. > > Fixes: 81eef6ca9201 ("mmc: omap_hsmmc: Use dma_request_chan() for requesting DMA channel") > > v4.11 did break the sdio qirks for wl1251 which made the driver no longer > load, although the device was found as an sdio client. > > Fixes: 884f38607897 ("mmc: core: move some sdio IDs out of quirks file") > > To solve these issues: > * we convert mmc3 and wl1251 initialization from pdata-quirks > to device tree > * we make the wl1251 driver read properties from device tree > * we fix the mmc core vendor ids and quirks > * we fix the wl1251 (and wl1271) driver to use only vendor ids > from header file instead of (potentially conflicting) local > definitions > > > H. Nikolaus Schaller (12): > Documentation: dt: wireless: update wl1251 for sdio > net: wireless: ti: wl1251 add device tree support > ARM: dts: pandora-common: define wl1251 as child node of mmc3 > mmc: host: omap_hsmmc: add code for special init of wl1251 to get rid > of pandora_wl1251_init_card > omap: pdata-quirks: revert pandora specific gpiod additions > omap: pdata-quirks: remove openpandora quirks for mmc3 and wl1251 > omap: remove omap2_hsmmc_info in old hsmmc.[ch] and update Makefile > mmc: host: omap-hsmmc: remove init_card pdata callback from pdata > mmc: sdio: fix wl1251 vendor id > mmc: core: fix wl1251 sdio quirks > net: wireless: ti: wl1251 use new SDIO_VENDOR_ID_TI_WL1251 definition > net: wireless: ti: remove local VENDOR_ID and DEVICE_ID definitions > > .../bindings/net/wireless/ti,wl1251.txt | 26 +++ > arch/arm/boot/dts/omap3-pandora-common.dtsi | 36 +++- > arch/arm/mach-omap2/Makefile | 3 - > arch/arm/mach-omap2/common.h | 1 - > arch/arm/mach-omap2/hsmmc.c | 171 ------------------ > arch/arm/mach-omap2/hsmmc.h | 32 ---- > arch/arm/mach-omap2/pdata-quirks.c | 105 ----------- > drivers/mmc/core/quirks.h | 7 + > drivers/mmc/host/omap_hsmmc.c | 30 ++- > drivers/net/wireless/ti/wl1251/sdio.c | 23 ++- > drivers/net/wireless/ti/wlcore/sdio.c | 8 - > include/linux/mmc/sdio_ids.h | 2 + > include/linux/platform_data/hsmmc-omap.h | 3 - > 13 files changed, 111 insertions(+), 336 deletions(-) > delete mode 100644 arch/arm/mach-omap2/hsmmc.c > delete mode 100644 arch/arm/mach-omap2/hsmmc.h > > -- > 2.23.0 >