From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C5C6DC433E7 for ; Thu, 3 Sep 2020 08:11:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A34B52098B for ; Thu, 3 Sep 2020 08:11:48 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="KvJqMahN" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728949AbgICILo (ORCPT ); Thu, 3 Sep 2020 04:11:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34106 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728879AbgICIKf (ORCPT ); Thu, 3 Sep 2020 04:10:35 -0400 Received: from mail-ua1-x944.google.com (mail-ua1-x944.google.com [IPv6:2607:f8b0:4864:20::944]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6E475C06124F for ; Thu, 3 Sep 2020 01:10:32 -0700 (PDT) Received: by mail-ua1-x944.google.com with SMTP id f16so297223ual.11 for ; Thu, 03 Sep 2020 01:10:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=t0hPUkXrts5hGV+gelozsNVJL831/qNHHpNikRUOxRI=; b=KvJqMahNGmcwZQvnzuao4zxMTJwrZ0aVd7RcYrE6hPpss6ABBzXgZfiKyN0Dc1xt3w d3AvbT3tUsr7G6i3EtAwWd+0XJ5MPlSy7K4kK/NeDlm6/Oo+WgIIiY7uz1D6RIs5kRTl dKWixy9q/3zuVRU3M/njOSPnnFTjXipSJ87wGBJtH7eiTaBcdN5ZUFQbWqAfd7QPVhU4 FWG6f+ssqAmxHxYlswVTrkTyEBATxmqcTZ+YR/6XiBmCPeZOcSHKQUO12y6KiBnU5dUR 2oEVUql1QDK9sCgoP2ChziQt2N+GXUK0rLFjOpZPxVz+l1LqejH6ftYDaJh35vQI3K+P LMJw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=t0hPUkXrts5hGV+gelozsNVJL831/qNHHpNikRUOxRI=; b=JimKkgPWZ6f3QkH4N/vmavaO15TzaBhK8VTu7jTsg/Dp8Pswi15hNNcFRl2pZcrtQi eGe/h34l+7+ZWUby5sfvBGGrtK4gtj9IaDxwHLBLiuljyKj0ATgLdOOpQgCQvIZMRkHM jsNChwWr8BrmN/gTcQcup+GCWFW5HgnPX1U3mHkly3uPt9Xh8XzMxP1jVGw/YLfOoWsZ pq+yl+v5aDrK6/Ajn0dW7ea2CIp3FKQJ21IUdw6RcP0yxzAAlriupGA5Os3PrEwvVqJ+ mS3++w1oPVHUV7dIUbvadhSJX1eWHCCtO087eGMYTUGkfew/H643fFwJuv8gluxdxZQq eVjQ== X-Gm-Message-State: AOAM532W15r9wFwL6g3yxmcP0sFjJDlZO9uJjfdwknll6pkmD58H0DDL dBYuHp8F8VkgGQ9Kb0nEXH/swbhiDeb12og/r6+J8Q== X-Google-Smtp-Source: ABdhPJyGFXf2GrcMm01qExZWSJ7jPtSw9m1PN/7SAvsSK9s1ZS20v0pF9sjrlhSxNVUE5hh22/OySMNemS1iIc0OoDQ= X-Received: by 2002:a9f:2722:: with SMTP id a31mr381930uaa.100.1599120631644; Thu, 03 Sep 2020 01:10:31 -0700 (PDT) MIME-Version: 1.0 References: <20200902193658.20539-1-krzk@kernel.org> <20200902193658.20539-7-krzk@kernel.org> In-Reply-To: From: Ulf Hansson Date: Thu, 3 Sep 2020 10:09:53 +0200 Message-ID: Subject: Re: [RFT 06/11] mmc: sdhci-brcmstb: Simplify with optional clock and dev_err_probe() To: Florian Fainelli , Krzysztof Kozlowski Cc: Ray Jui , Scott Branden , BCM Kernel Feedback , Nicolas Saenz Julienne , Jaehoon Chung , Jun Nie , Shawn Guo , Paul Cercueil , Kevin Hilman , Neil Armstrong , Jerome Brunet , Martin Blumenstingl , Al Cooper , Adrian Hunter , Michal Simek , Lars Povlsen , Steen Hegelund , Microchip Linux Driver Support , Thierry Reding , Jonathan Hunter , Arnd Bergmann , "linux-mmc@vger.kernel.org" , Linux Kernel Mailing List , linux-rpi-kernel@lists.infradead.org, Linux ARM , "open list:ARM/Amlogic Meson..." , linux-tegra Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2 Sep 2020 at 21:58, Florian Fainelli wrote: > > > > On 9/2/2020 12:36 PM, Krzysztof Kozlowski wrote: > > Only -ENOENT from devm_clk_get() means that clock is not present in > > device tree. Other errors have their own meaning and should not be > > ignored. > > > > Simplify getting the clock which is in fact optional and also use > > dev_err_probe() for handling deferred. > > > > Signed-off-by: Krzysztof Kozlowski > > This is actually an open coded version of devm_clk_get_optional(), so > this is fine: devm_clk_get_optional() treats -ENOENT specifically, so it's not an exact open coded version. I think that's why Krzysztof prefered to get it tested on HW. > > Acked-by: Florian Fainelli Thanks! I am queuing this up for next, without waiting for explicit tests . There is time to get that from testing in linux-next anyway. Kind regards Uffe