From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-23.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_IN_DEF_DKIM_WL autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3C860C43460 for ; Wed, 14 Apr 2021 01:28:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 16DA4613B6 for ; Wed, 14 Apr 2021 01:28:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242050AbhDNB2c (ORCPT ); Tue, 13 Apr 2021 21:28:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:32916 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229785AbhDNB22 (ORCPT ); Tue, 13 Apr 2021 21:28:28 -0400 Received: from mail-vs1-xe29.google.com (mail-vs1-xe29.google.com [IPv6:2607:f8b0:4864:20::e29]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9F42AC061574 for ; Tue, 13 Apr 2021 18:28:07 -0700 (PDT) Received: by mail-vs1-xe29.google.com with SMTP id l11so1041280vsr.10 for ; Tue, 13 Apr 2021 18:28:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=mt9FPvqsM99syM3V4UPsDSUXPJo0lBDNk0KpnCh/nwo=; b=llob8PI6oLIoAZftpic9u7CSKaXkcnvfP/vD3AX2p4eHHkLRwjNPuVeTZb8W3s/MK0 MCsuvYLkFtrNs/kbIAfqQ/ZfdU/wV28zr0MUFHSksOSy0vHiE62OM2BdG5aeXja0hnqi VoQcZSKl+k90GC3BOT00+1lLKSCSW8Kh+pNVaS2fy57v2CawGZRFZWEvde1a2NqDe7zz 7JuTszoIfBF1A4QgsYfcxSYU/StVN21pYorzjXpkkfBPjhnMq7QquSpXZowjT0wdrKSo KDvZynHtuJgYHkVZWaT4+k7O8KJm01vDQ3QAwidGWCxyR7UxBstHt2415xgWYCfptNCM LdYQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=mt9FPvqsM99syM3V4UPsDSUXPJo0lBDNk0KpnCh/nwo=; b=SA2ZQX2CWJBP943thcmaoyxakI70kMc916mSESHLvH/pcxLCSrCpP8XdvSl4RcTV8A tuGTQj4MEdrtNQS72q64x5dJhNmO0FaT2mXZhZaozVkaACu42RN3pw1m4jdO53ajWIEs vJ5J7XnJ9/DdFmdwbc5X2Zlo5RlNEII6f1rpSZNkACvDwHPFB1PZEBNg84GHRWnLf65U F4tsHHYglHnkwTprs0f/zdYRDZj7Yae8ohs/Gjwddclh4l+cMfsdVINL8l8wvRgMlF39 ihvGj/msAL3ikjiExnj31UepvUAwW5SfpXct79biGGciXrZEGD2WeUU9Okjnjs8Usw4/ tW7g== X-Gm-Message-State: AOAM53183qzGoIUd/se7LFiv5Km5XX0gQr8ccSWOMK+IMygti/4h/7up veeaYuguo2kEO599t6ET8aaU8LmPpYVK03ZhdRvurA== X-Google-Smtp-Source: ABdhPJxYFckGniifS7vjuSzS3/hfjGlYO1cQrMRpm1/e4phHtVDXLNENpfEgPO/gihAQiqkYcdUNooVt6ODnwd2XuT4= X-Received: by 2002:a67:12c6:: with SMTP id 189mr25672622vss.16.1618363686305; Tue, 13 Apr 2021 18:28:06 -0700 (PDT) MIME-Version: 1.0 References: <20210407200723.1914388-1-badhri@google.com> <20210407200723.1914388-6-badhri@google.com> <20210409183803.GA3928012@robh.at.kernel.org> In-Reply-To: <20210409183803.GA3928012@robh.at.kernel.org> From: Badhri Jagan Sridharan Date: Tue, 13 Apr 2021 18:27:31 -0700 Message-ID: Subject: Re: [PATCH v2 6/6] Documentation: connector: Add slow-charger-loop definition To: Rob Herring Cc: Guenter Roeck , Heikki Krogerus , Greg Kroah-Hartman , Adam Thomson , USB , LKML , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Kyle Tso Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Rob, Have clarified "slow charger loops" and pSnkStby in my V3 of the patch and have updated the subject as well. I was actually doing a git log where the last one showed up with the following commit description. commit 4b59b60d896f3ed94921974e916db091bc3a9ba8 Author: Kyle Tso Date: Fri Feb 12 15:37:43 2021 +0800 Documentation: connector: Update the description of sink-vdos Remove the acronym "VDM" and replace it with the full name "Vendor Defined Message". Reviewed-by: Guenter Roeck Signed-off-by: Kyle Tso Link: https://lore.kernel.org/r/20210212073743.665038-1-kyletso@google.com Signed-off-by: Greg Kroah-Hartman Thanks, Badhri On Fri, Apr 9, 2021 at 11:38 AM Rob Herring wrote: > > On Wed, Apr 07, 2021 at 01:07:23PM -0700, Badhri Jagan Sridharan wrote: > > To allow slow charger loops to comply to pSnkStby requirement, > > this patch introduces slow-charger-loop which when set makes > > the port request PD_P_SNK_STDBY_MW upon entering SNK_DISCOVERY > > (instead of 3A or the 1.5A during SNK_DISCOVERY) and the actual > > currrent limit after RX of PD_CTRL_PSRDY for PD link or during > > SNK_READY for non-pd link. > > What are 'slow charger loops' and pSnkStby? > > 'dt-bindings: connector: ...' for the subject. Follow the pattern you > see with 'git log --oneline' for a directory. > > > > > Signed-off-by: Badhri Jagan Sridharan > > --- > > .../devicetree/bindings/connector/usb-connector.yaml | 7 +++++++ > > 1 file changed, 7 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/connector/usb-connector.yaml b/Documentation/devicetree/bindings/connector/usb-connector.yaml > > index b6daedd62516..09ad3ad983a6 100644 > > --- a/Documentation/devicetree/bindings/connector/usb-connector.yaml > > +++ b/Documentation/devicetree/bindings/connector/usb-connector.yaml > > @@ -197,6 +197,13 @@ properties: > > $ref: /schemas/types.yaml#/definitions/uint32 > > enum: [1, 2, 3] > > > > + slow-charger-loop: > > + description: Allows slow charging loops to comply to pSnkStby. When set makes > > + the port request pSnkStby(2.5W - 5V@500mA) upon entering SNK_DISCOVERY(instead > > + of 3A or the 1.5A during SNK_DISCOVERY) and the actual currrent limit after > > + reception of PS_Ready for PD link or during SNK_READY for non-pd link. > > + type: boolean > > + > > required: > > - compatible > > > > -- > > 2.31.1.295.g9ea45b61b8-goog > >