Re: [PATCH v1] arm64: dts: exynos: gs101: Enable AVS APDO

[Badhri Jagan Sridharan <badhri@google.com>]

On Wed, Feb 25, 2026 at 10:51 PM Krzysztof Kozlowski <krzk@kernel.org> wrote:
>
> On 26/02/2026 07:51, Krzysztof Kozlowski wrote:
> > On 26/02/2026 07:10, Badhri Jagan Sridharan wrote:
> >> Enable USB PD SPR AVS for gs101 by adding SPR AVS APDO to the sink caps
> >> pusblished by gs101.
> >>
> >> Signed-off-by: Badhri Jagan Sridharan <badhri@google.com>
> >> ---
> >> Depends-on:https://lore.kernel.org/lkml/20260226055311.2591357-1-badhri@google.com/
> >
> > Really, how? If it depends on that, it is wrong and cannot be applied.
> > DTS cannot depend on the hardware. NAK.
>
> s/hardware/drivers/ obviously...
>
> >
> >>
> >>  arch/arm64/boot/dts/exynos/google/gs101-pixel-common.dtsi | 1 +
> >>  1 file changed, 1 insertion(+)
> >>
> >> diff --git a/arch/arm64/boot/dts/exynos/google/gs101-pixel-common.dtsi b/arch/arm64/boot/dts/exynos/google/gs101-pixel-common.dtsi
> >> index 93892adaa679..5a689be61432 100644
> >> --- a/arch/arm64/boot/dts/exynos/google/gs101-pixel-common.dtsi
> >> +++ b/arch/arm64/boot/dts/exynos/google/gs101-pixel-common.dtsi
> >> @@ -174,6 +174,7 @@ connector {
> >>                                              | PDO_FIXED_HIGHER_CAP
> >>                                              | PDO_FIXED_DUAL_ROLE))
> >>                                   PDO_FIXED(9000, 2200, 0)
> >> +                                 PDO_SPR_AVS_SNK_APDO(3000, 3000)
> >>                                   PDO_PPS_APDO(5000, 11000, 3000)>;
> >>                      sink-vdos = <VDO_IDH(1, 1, IDH_PTYPE_PERIPH, 0,
> >>                                           IDH_PTYPE_DFP_HOST, 2, 0x18d1)
> >>
> >> base-commit: 6de23f81a5e08be8fbf5e8d7e9febc72a5b5f27f
> >> prerequisite-patch-id: 4dacd8bc550e317d67134d030814765fb9f4c6e1
> >> prerequisite-patch-id: e863378fc602b6bee2e9fdd8c568003c00b2a38e
> >> prerequisite-patch-id: 202a9e1e9cf27a0b9ff7ebea76eb45cdac2cb581
> >> prerequisite-patch-id: f3817c560d0e701d7499fa1fb9ee40d22816c09e
> >> prerequisite-patch-id: c071913307a6eaa417d1345485d7a9c165d40834
> >
> > 5 patches here. This is confusing.

Apologies for the confusion Krzysztof. This DTS change depends only on
the binding defined in the topic:
https://lore.kernel.org/lkml/20260226055311.2591357-1-badhri@google.com/).
I will drop the  prerequisite-patch-id and will add the following in
V2 where just the binding from topic is marked depends-on by this
patch. i.e.

Depends-on: https://lore.kernel.org/lkml/20260226055311.2591357-2-badhri@google.com/

>
> Best regards,
> Krzysztof