From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 04DA8C433EF for ; Mon, 13 Jun 2022 23:26:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1346172AbiFMX0J (ORCPT ); Mon, 13 Jun 2022 19:26:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58876 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242275AbiFMX0H (ORCPT ); Mon, 13 Jun 2022 19:26:07 -0400 Received: from mail-io1-xd36.google.com (mail-io1-xd36.google.com [IPv6:2607:f8b0:4864:20::d36]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B6ECC326C8 for ; Mon, 13 Jun 2022 16:26:06 -0700 (PDT) Received: by mail-io1-xd36.google.com with SMTP id 19so7738027iou.12 for ; Mon, 13 Jun 2022 16:26:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=cbxRBPwDsE33S/4VWlMl76EK8aUfLE1juYHGI23Fd9s=; b=Q7KcmegsUIXtRK/aUvN0dfl38itVsJxSdSzTcmQADGwvhawJSCjwQwVZ0S8tUk0MLT sMnvKm08Vjq/p4mvxxELqyBzAmAjWGgT7rWjMhrgeHhzxIhiWA+1OfCJLNEYSXGBiuwX KKgoji0LufhQdFZhgUnLRooUwbeqYKZVNWnzk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=cbxRBPwDsE33S/4VWlMl76EK8aUfLE1juYHGI23Fd9s=; b=Xb7Epx+F6d0j7QbLVmNv2CYE7Lhw6kmi7tSFT2+8D1sJ3qgRAkr9P7dKcsFls70Sav oxAKq6cSniGEbqZvCd/a8PY0GReiksOFHKDgoELLmrfgZsWWdVP6T+z0T+v6/FrGdbCK MOhcXpd/r0J46l2iGZfkMv8cCqtnZcUKIJlo6MfSRJ5/Y/UFnNLcjx7LJQSLZ8fYxqCi Nkz1R3jUk9Nd4mWr4vRr3nY8aHzhu/6zeaSCqz99oNPQQnD7EYbTODdxlb5BpJDraIQQ tfczc3D9XNJntR1oq2x0OAT6vND3DNAFdHAaCRzO0XlXJ2VXnaGZqQJV9Y6g6+WwqPWm AJQw== X-Gm-Message-State: AOAM532+eKvYnpHj/VBxWGwVsUhyBUmI2wA5CHuatNaVAaaKoUZSZW3U d1HTRrAeNyBlzpgkGgyJPjJi/GwwzRWRoagraH3Cvw== X-Google-Smtp-Source: ABdhPJz6BzkhxT4qPiTDFCP9A72GGdJ/EGAHIkamJTf26bfTUwgdrW/qNn+EcsJTpA9WG7RlmeDt//ajXwXTAncS/68= X-Received: by 2002:a05:6602:2d4b:b0:669:f213:c6e1 with SMTP id d11-20020a0566022d4b00b00669f213c6e1mr1080945iow.77.1655162766187; Mon, 13 Jun 2022 16:26:06 -0700 (PDT) MIME-Version: 1.0 References: <20220613232224.2466278-1-swboyd@chromium.org> In-Reply-To: <20220613232224.2466278-1-swboyd@chromium.org> From: Gwendal Grignou Date: Mon, 13 Jun 2022 16:25:55 -0700 Message-ID: Subject: Re: [PATCH] iio:proximity:sx9324: Check ret value of device_property_read_u32_array() To: Stephen Boyd Cc: Jonathan Cameron , Aashish Sharma , linux-kernel@vger.kernel.org, patches@lists.linux.dev, linux-iio@vger.kernel.org, kernel test robot Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jun 13, 2022 at 4:22 PM Stephen Boyd wrote: > > From: Aashish Sharma > > 0-day reports: > > drivers/iio/proximity/sx9324.c:868:3: warning: Value stored > to 'ret' is never read [clang-analyzer-deadcode.DeadStores] > > Put an if condition to break out of switch if ret is non-zero. > > Signed-off-by: Aashish Sharma > Fixes: a8ee3b32f5da ("iio:proximity:sx9324: Add dt_binding support") > Reported-by: kernel test robot > [swboyd@chromium.org: Reword commit subject, add fixes tag] > Signed-off-by: Stephen Boyd Reviewed-by: Gwendal Grignou > --- > drivers/iio/proximity/sx9324.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/iio/proximity/sx9324.c b/drivers/iio/proximity/sx9324.c > index 70c37f664f6d..63fbcaa4cac8 100644 > --- a/drivers/iio/proximity/sx9324.c > +++ b/drivers/iio/proximity/sx9324.c > @@ -885,6 +885,9 @@ sx9324_get_default_reg(struct device *dev, int idx, > break; > ret = device_property_read_u32_array(dev, prop, pin_defs, > ARRAY_SIZE(pin_defs)); > + if (ret) > + break; > + > for (pin = 0; pin < SX9324_NUM_PINS; pin++) > raw |= (pin_defs[pin] << (2 * pin)) & > SX9324_REG_AFE_PH0_PIN_MASK(pin); > > base-commit: f2906aa863381afb0015a9eb7fefad885d4e5a56 > -- > https://chromeos.dev >