From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f176.google.com (mail-pf1-f176.google.com [209.85.210.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D8D923128D4 for ; Tue, 14 Jul 2026 13:27:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=pass smtp.client-ip=209.85.210.176 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784035623; cv=pass; b=ct5thVxiWv1SKrnKZkUPKejR67lQpNJbAA8jat8uj4B15qbE36DHcvE1ChzaVuAX4sFJ0VpJjaAfq2q2EZXjOGnECAHPkPbmW7yeAS/BDeUvmOgdwgfST8QVXhgE0F29E0oQRoG+n3cqJMrKXJG8Boc8A/KmRM4g2ezXMylV/5I= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784035623; c=relaxed/simple; bh=nO1TZgVYGZMERjIgcqsTAqDB/ZWtf6AUfRwRoLJPVvc=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=nQpjbf+jGUNrchYLm0YO5qaVpZESLsxYdPfPffObS2XE57xQqbGH+pLACgT999KcG1j7KlZ48uNCc9wddSVZmcuJTnKTAEKB9+cNQntUG5N89oJkd57nfIcEU2MKAucvwrCy2LKqdfIn93LC3z/VkBghLlUOG2hzTk2FGKbDBc8= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=LZf1aXd0; arc=pass smtp.client-ip=209.85.210.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="LZf1aXd0" Received: by mail-pf1-f176.google.com with SMTP id d2e1a72fcca58-84864086bfeso4493120b3a.1 for ; Tue, 14 Jul 2026 06:27:01 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1784035621; cv=none; d=google.com; s=arc-20260327; b=mkiz8uRugwa7aooSeb3U3lztytolYYIkPN9HCoD9hNXYCZNoYMtJrhwJn0XxEnk7C9 /DzF8MSwHLtaLjoZEBX2vbcpWaiRE6USdke0rkXSHmaSwxOQSTVF0ktnkUDRGDLuER1N YAB2RDVfGN27EnCAMJZ1c0HKiq6qyR+ssiyblb4b6YXvnBfsRumovU25XfHz99txE205 s5wG+Cjp7FOqqlOUpBBE7P2QoHMiSamrPGsjbcFHqVEDkhv41MQb4/vmFScNvKvrC36T XyPWPGAYiEBBGf5DYWobZiSk6l4wF4JTA2hBQR7IlhCWDCHJQK1qpAiLM78NaBxj68uL h2Pw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=nO1TZgVYGZMERjIgcqsTAqDB/ZWtf6AUfRwRoLJPVvc=; fh=YjHkFj3A/8xKc2CxdzJO/8ZY1g9YDbYUrM9xbQWWbXY=; b=sGrYxvVnTQVVardZL996XwJgPjTC+5OgbsMnaN0JGeb2AGiIISHRvBm6t5MOsxra6B zJcxQaQr9UZnU9dHzCMjepCNKY2Uufl11Jw+gl2nyoSAJs8P3aPOPctRtG0tjjTLkmQ2 GVsDG7sz41Tju/UEKSkXlBc6j8jznPdrUZuVZMEpRdjH8ORrCyvvp1ZuaPWTiL1/BzIQ Qj/YI6KbEENdbO89LJ2l2wVQU9b3AJtLRn04jlRnKaGMyTpuPslh+LIKt5KfRIc2/gUC Wu5DbLVTaz+DXVdsAXw8dVOMTwNpAGaY4Bs8eRMFGWkquD7a4MKcB3r+ToBCp1lYWzv5 F8Vg==; darn=vger.kernel.org ARC-Authentication-Results: i=1; mx.google.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784035621; x=1784640421; darn=vger.kernel.org; h=content-transfer-encoding:content-type:cc:to:subject:message-id :date:from:in-reply-to:references:mime-version:from:to:cc:subject :date:message-id:reply-to:content-type; bh=nO1TZgVYGZMERjIgcqsTAqDB/ZWtf6AUfRwRoLJPVvc=; b=LZf1aXd0NDZy+HyoV9fvHRsX5BLLkFdBKmoUP+hsams104OkhJru3dmMG/oz6E0o9P 0rBAvVrCSCSIhCrYr1gNqDhOAvm3PLyO58snWKTApbRtlPeiTym32NPpIKOblXD7z4Au XPt5nXHEqkOwfqPqyrJhnwospmkSKWhwS0H/L5pvhr62cA74ZAcmldmq8cvN3/FhWLda ubfOxB4awH73kFJIDmWFoVzv1PT8p7cjjTzZTp67yTxK32oHIm+PEFbUlkuQtf0pJRUo ZYu+Ih1/KqqwSaHohotBUtpxiEb1E2iGPgYnM25zKGGTr25K0BBTuVvChnaBs+5J/TMp A2zw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784035621; x=1784640421; h=content-transfer-encoding:content-type:cc:to:subject:message-id :date:from:in-reply-to:references:mime-version:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=nO1TZgVYGZMERjIgcqsTAqDB/ZWtf6AUfRwRoLJPVvc=; b=MwEakpVfh34o6K6wKsctxlGeB1btBamXiCX4Amgn7NWNM9b/aePUaYbaROEI/lvRsv zPe0m8ztvCzOyKMPAYzx2ZXuuJWenX4BwhI9L1aymP3oPNfxqzg3OhtPGublnCvfIr9r SVPwY1A1FDe1fgzYpNBbVJM58RDOPzwS/zd6s9MUEK/hbuSChbRUnCFBGtDlkZEYpaJp QbC7ff39VyhpxmQ6PW0GhKNoOd1xT5h5TXCxZjNfjde9dak4cdNWSYWMJo7TfaG2Q2O3 GlNsujy7xy41Vsu5IUFBU+fWKEvKgYNZPbxQVEoWA3kMphhhogkkp4DZM1xEWWQ3WhWd D51Q== X-Forwarded-Encrypted: i=1; AHgh+RrX5m6NcckfXFQ22KOVDzZg1M71NNv0zK6qWJSoK4jsxLTAi7196JOw7hFb3wILCkTl3xSFGTo9Hwccjmk=@vger.kernel.org X-Gm-Message-State: AOJu0YyjUztODMvpnC+YLZghOBvWE49sxEdGScOSNv29PKygI/Ks4GsE syFVlxTE5WZ9RTq2TIMIMGIUmfyen7qD2fv35XyVC3PYm4PxU6ierdwcMNX2HyfZpPruXvWMtw7 WPYfuf/q1wN8zk4nfZstc9xLNZz3HRIFF2g== X-Gm-Gg: AfdE7cmoFlnTfdbUJZGpZfEO3RjI73gUOPxv7pZymh9sEl7ESTqGFFY0Zrucr8rHJ92 cJz8MiGgPyNLP8CalzFWYWKr95IE1yhB4TnPY2W8LtPGyUgfQwPTEPvvcVe2VencnGzveGRS/gg e7oNZYE5pY7b6eFWOYUP++RTVAQeRo5hQYrfabCYWeafPuSq6G4V64Lh0elU+n+0wATVeXAPHLD 1PIVewcBorCAZ45gIej6sdIPIBr+zytkDAguDhFIU7ibezuKP57kKMgwKah5eqA8RBZdQBzqvnD U7gRkshme1IJFEW/kDNqS3r4/bTvLg== X-Received: by 2002:a05:6a21:730e:b0:3c1:279c:526c with SMTP id adf61e73a8af0-3c3576426d3mr2584439637.63.1784035620851; Tue, 14 Jul 2026 06:27:00 -0700 (PDT) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20260617080031.99156-1-clamor95@gmail.com> <20260617080031.99156-3-clamor95@gmail.com> In-Reply-To: From: Svyatoslav Ryhel Date: Tue, 14 Jul 2026 16:26:49 +0300 X-Gm-Features: AUfX_mylEu9Yyzm1iZHwnL_3qQ4wX-qy21nMalz6S1BYQvhN4kmLF8d5IT5che8 Message-ID: Subject: Re: [PATCH v5 02/14] mfd: lm3533: Remove driver specific regmap wrappers To: Johan Hovold Cc: Lee Jones , Daniel Thompson , Jingoo Han , Pavel Machek , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Jonathan Cameron , David Lechner , =?UTF-8?B?TnVubyBTw6E=?= , Andy Shevchenko , Helge Deller , dri-devel@lists.freedesktop.org, linux-leds@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, linux-fbdev@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable =D0=BF=D1=82, 3 =D0=BB=D0=B8=D0=BF. 2026=E2=80=AF=D1=80. =D0=BE 12:44 Johan= Hovold =D0=BF=D0=B8=D1=88=D0=B5: > > On Wed, Jun 17, 2026 at 11:00:19AM +0300, Svyatoslav Ryhel wrote: > > Remove driver-specific regmap wrappers in favor of using regmap helpers > > directly. > > The commit message should explain why you think this is a good idea. > Removing custom wrappers over standard regmap helpers is always a good idea, that is self explanatory. > Based on a quick look you lose the errnos that were logged on errors and > also the register debugging provided by those helpers. > That is not true, regmap helpers will provide logging and you should not include debug stuff into the final submitted driver unless you have a extremely valid justification for this, debug logs should have been removed once the driver development was completed. > Johan