From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f48.google.com (mail-pj1-f48.google.com [209.85.216.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 15FF746AF1A for ; Tue, 14 Jul 2026 13:31:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=pass smtp.client-ip=209.85.216.48 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784035882; cv=pass; b=fKydhtDVlQ/jphYRU7G4R+TP5EpG+l4LS7djGJKhyDYqpcwf16EkRScihNgXff0TU55+7fXRh3w/KI7x//h8tqmvF7G7buSIrgv1sdM/pg131GA/9zU2MPLsaHwVClOtvlO006qexwcW0qUIxGap/pHRo8QiclNdrbnAHA+NLuk= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784035882; c=relaxed/simple; bh=6DZv1K0DlUi+ti2Ixfzbo+SkZOzrPzgNcj+8JfhDZTE=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=Mwft9WiudHh+nBLEqdI/dJ4dLySqJfYnUV9MnMPLF5XZu+moWy3CRAGvJs5rz+Vc+9ZB5abdN/ERUt6VGVHFqTm2ePQVqGmA1PVp7ZdNHMAEfg3ZBHgHYwch6KYtY5LMazEiTfQGmKGOSmaTnfYOGaQW84PzTFbACAQ10Bo0Loc= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=adtRORoK; arc=pass smtp.client-ip=209.85.216.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="adtRORoK" Received: by mail-pj1-f48.google.com with SMTP id 98e67ed59e1d1-38175907a56so760489a91.0 for ; Tue, 14 Jul 2026 06:31:20 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1784035880; cv=none; d=google.com; s=arc-20260327; b=GsWjQ+3MEbLXIU57Hw8kc/2nUwN0IqpidYC1qnJYrNMNzmOv/M03T3EP4W4yrNBPcq mnXTZENGb76KZmR+cPb48/eCBbBOg6pw542ffZdF/RX4JPU77nWWqMiM0lrJ5cfrMghg /+4pQbAXXNTFYjCQnfu9AYNkY6qpxWGrAYxa9gf+KaJH9sDIMz+4RReLHfUy2PoROkKA 5mh45S9fYophgtlg2+MlvUwgXn4A4xkEurX9lwrH4dsXz3Bu4/5Z/H+Kz7lw1DRoblha D8ZVl8e7vpqdHXaM1XUGCMZ8HGh0/EO+x0FHj9yeGiR6KrX9SCKU3T6icg10TtrxjexV CIkg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=kLfW8NpBLmGd5rRr/q7P+WdrGpDQQoBNPKO5OnQCHQk=; fh=LGuar9KLoB4NRarvLKD6Rjv2qYerLi5ZoUnx/PcZAtM=; b=f5PeRkRy35ow8FwqbifDsdFHsSi2T+vDIqMKTMZcIDZURrRtHHBJo66fWKoK/vWGYd Qmctk7jQhu0HTk0TuTNV0pBkdmE+Azbkh9s1OgMBvME/7SwUsFFuvb6IxgTbvLvcqjMn AyGaa7f8wzQGpFvwbzuM10rGeEzA9XzsIy+yt8kdVqfkEWXjHgyrlGptZYUoX2a5uiN2 KNedZM/d0DLUiA4Ji/k0RJIO0wrkHXkC4h72MVdmjvP12evjjBCyZ5JS2QmSwEpyYylQ vAlyyRsKNVpHrV7c2JqVKquSUxilsw62CMxCLVZny5xRvr4asoY8UXfZ4ladVLL9OLYF rKxA==; darn=vger.kernel.org ARC-Authentication-Results: i=1; mx.google.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784035880; x=1784640680; darn=vger.kernel.org; h=content-transfer-encoding:content-type:cc:to:subject:message-id :date:from:in-reply-to:references:mime-version:from:to:cc:subject :date:message-id:reply-to:content-type; bh=kLfW8NpBLmGd5rRr/q7P+WdrGpDQQoBNPKO5OnQCHQk=; b=adtRORoK6ykURV4MpPqfrnTXyFhgyraH2fPjJ0S7zI+Kwx7knp9zoE890+UYb+j00y bFiN9z5SSPD8qzVBXDWlV5SlrMQbkjEPvlDpqIz1kmHac6uHt49DQ93YNWJQfdi5EQHk 475uVtuqDXE2WWrNE7/ik48QuATe0RyrQUbWMxyxEj9KdpndUMc9EO3fPKh/seREI0ql //DrLBaWIMGG0cjP3+D5fNXmM/AIXH05XyLQawLfUa820ELjaK2iJiPlBqzjJ35GHXmI D9sKHXvALthnn958hN4yPWlnY+H2pBMvmeGysDo4boFy80Y/Zwozmr8Tvp6DryTrOpwS AT/w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784035880; x=1784640680; h=content-transfer-encoding:content-type:cc:to:subject:message-id :date:from:in-reply-to:references:mime-version:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=kLfW8NpBLmGd5rRr/q7P+WdrGpDQQoBNPKO5OnQCHQk=; b=EqviufTarWraIh5dTskfInhWzb5GaL2+btvJrhnEhqBC+W+dx54frhJi/5F+EMi+2h Vag3PTnjM8cIkXWxdSghNlqCNy/4rFBU6dHQuUNzMfqSPJOfOxHxL8MxP9x2+7CpYUzZ y0PqFhr90LSZ+TZ9XsRFD9yk3wxl8uiZUr+D0Ws100beQ3nl8TG/Fm7bFJCJF/Qbo5+X sBE4KxalenicWQuBxTnb0bA9pihw2wL8Ybf2gq1WO58oV0+OCFRVlSxGAnBdbVN6Da2V qWfTYRYzSE0zaSbOUUV1AHOnqlftSulHe2JxFCxiXK8r0OfKMxbS+D+2cPgiMraUrPvJ XunQ== X-Forwarded-Encrypted: i=1; AHgh+Rp0yORnNhKqQo0nSua5o/Q9BzxXkpeONCvsgrUYrvA6dRE7rpv33FGyWB+9QXEbpk3MFZ2Gfmqtt2YhObI=@vger.kernel.org X-Gm-Message-State: AOJu0YzFqZ8nT0lqZ2X2iv3cdBmX+OVftX3+4U6d5uK3bAEkCyxb+p1c T6XK9zTHAF7egcnKVXVwONsirwJHhQbHiiT5eecr9foHRlzEiMDD15nK1CFM3fD/74D4rMcYBK8 a82z298rp0lYULITKRvsYwxlFtNpR0QU= X-Gm-Gg: AfdE7cncnxCPK2yxCba4ZJn7RRAZwW5W8ic3lVJxw80KL5Cj47xRcfuczipcwhlDS0s Y067LuVNfVlaLYjWygMv67Fe0WN43u2At9g8jsVK19B1leJlGIDmzLsY3CbI9ubAiX4qRBa+brl 8Fbm0VJCwNVwFYryyd9zeXfxHllaopPqp/pjBYpq2QRy3MTIDEvgtbGUwpJQoznQ+h22LoCE/Rd kc97UqJflksQQicUKvW5hGbaBj+SB3p5/fGtwTHPw+/rJ5WtJBc8u4tB15A36fyhbzDc+ApF1Nn aJahltYqkYho0GzjuEiqMaRm8QGX5pq/drI9f/mH X-Received: by 2002:a17:90b:5607:b0:37f:e5b1:ec4b with SMTP id 98e67ed59e1d1-38d13c60530mr18215292a91.5.1784035880304; Tue, 14 Jul 2026 06:31:20 -0700 (PDT) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20260617080031.99156-1-clamor95@gmail.com> <20260617080031.99156-6-clamor95@gmail.com> In-Reply-To: From: Svyatoslav Ryhel Date: Tue, 14 Jul 2026 16:31:08 +0300 X-Gm-Features: AUfX_mxzYxEuGLMctIZqZIdW8wmxIrFK1WcO0C4FctuVUcu9qYtJIaIs5OSxe4o Message-ID: Subject: Re: [PATCH v5 05/14] iio: light: lm3533-als: Remove redundant pdata helpers To: Johan Hovold Cc: Lee Jones , Daniel Thompson , Jingoo Han , Pavel Machek , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Jonathan Cameron , David Lechner , =?UTF-8?B?TnVubyBTw6E=?= , Andy Shevchenko , Helge Deller , dri-devel@lists.freedesktop.org, linux-leds@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, linux-fbdev@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable =D0=BF=D1=82, 3 =D0=BB=D0=B8=D0=BF. 2026=E2=80=AF=D1=80. =D0=BE 12:55 Johan= Hovold =D0=BF=D0=B8=D1=88=D0=B5: > > On Wed, Jun 17, 2026 at 11:00:22AM +0300, Svyatoslav Ryhel wrote: > > The lm3533_als_set_input_mode() and lm3533_als_set_resistor() functions > > are used only in lm3533_als_setup(). Incorporate their code into > > lm3533_als_setup() directly to simplify driver readability. > > That's a debatable claim. > Adding helpers to wrap custom regmap wrappers seems redundant twice. > > Signed-off-by: Svyatoslav Ryhel > > --- > > drivers/iio/light/lm3533-als.c | 56 ++++++++++------------------------ > > 1 file changed, 16 insertions(+), 40 deletions(-) > > > > diff --git a/drivers/iio/light/lm3533-als.c b/drivers/iio/light/lm3533-= als.c > > index a9af8e2b965f..69bac1b202f1 100644 > > --- a/drivers/iio/light/lm3533-als.c > > +++ b/drivers/iio/light/lm3533-als.c > > > -static int lm3533_als_setup(struct lm3533_als *als, > > - const struct lm3533_als_platform_data *pdata) > > -{ > > - int ret; > > - > > - ret =3D lm3533_als_set_input_mode(als, pdata->pwm_mode); > > + pdata->r_select); > > if (ret) > > - return ret; > > - > > - /* ALS input is always high impedance in PWM-mode. */ > > - if (!pdata->pwm_mode) { > > - ret =3D lm3533_als_set_resistor(als, pdata->r_select); > > - if (ret) > > - return ret; > > - } > > + return dev_err_probe(dev, ret, "failed to set resistor\n"= ); > > return 0; > > } > > There's nothing hard to read about the above. To the contrary the logic > is more obvious this way. > > You also remove the high-impedance comment for no good reason. > Removing one level of indentations without obscuring readability is always a good idea. > Johan