From: Svyatoslav Ryhel <clamor95@gmail.com>
To: Rob Herring <robh@kernel.org>
Cc: Sebastian Reichel <sre@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
linux-pm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 1/2] dt-bindings: power: supply: Document Maxim MAX8971 charger
Date: Tue, 4 Mar 2025 16:38:58 +0200 [thread overview]
Message-ID: <CAPVz0n3WZOUb41AzNPqMLx8wtPiBJ1jfww7h5xyJaZgu+=RdkA@mail.gmail.com> (raw)
In-Reply-To: <20250304135806.GA2503334-robh@kernel.org>
вт, 4 бер. 2025 р. о 15:58 Rob Herring <robh@kernel.org> пише:
>
> On Mon, Mar 03, 2025 at 01:55:01PM +0200, Svyatoslav Ryhel wrote:
> > Add bindings for Maxim MAX8971 charger.
> >
> > Signed-off-by: Svyatoslav Ryhel <clamor95@gmail.com>
> > ---
> > .../bindings/power/supply/maxim,max8971.yaml | 68 +++++++++++++++++++
> > 1 file changed, 68 insertions(+)
> > create mode 100644 Documentation/devicetree/bindings/power/supply/maxim,max8971.yaml
> >
> > diff --git a/Documentation/devicetree/bindings/power/supply/maxim,max8971.yaml b/Documentation/devicetree/bindings/power/supply/maxim,max8971.yaml
> > new file mode 100644
> > index 000000000000..2244cc3d45a6
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/power/supply/maxim,max8971.yaml
> > @@ -0,0 +1,68 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/power/supply/maxim,max8971.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Maxim MAX8971 IC charger
> > +
> > +maintainers:
> > + - Svyatoslav Ryhel <clamor95@gmail.com>
> > +
> > +description:
> > + The MAX8971 is a compact, high-frequency, high-efficiency switch-mode charger
> > + for a one-cell lithium-ion (Li+) battery.
> > +
> > +allOf:
> > + - $ref: power-supply.yaml#
> > +
> > +properties:
> > + compatible:
> > + const: maxim,max8971
> > +
> > + reg:
> > + maxItems: 1
> > +
> > + interrupts:
> > + maxItems: 1
> > +
> > + monitored-battery: true
> > +
> > + port:
> > + description:
> > + An optional port node to link the extcon device to detect type of plug.
> > + $ref: /schemas/graph.yaml#/properties/port
>
> extcon as a binding is pretty much deprecated in favor of connector
> bindings.
>
> The OF graph is an overkill here too. You should just need a phandle to
> the connector node.
>
Actually, I am fine with using connector phandle if this will lead to
acceptance of schema.
I will add this in v4 once time comes. Thanks.
> Rob
next prev parent reply other threads:[~2025-03-04 14:39 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-03 11:55 [PATCH v3 0/2] power: supply: Add support for " Svyatoslav Ryhel
2025-03-03 11:55 ` [PATCH v3 1/2] dt-bindings: power: supply: Document " Svyatoslav Ryhel
2025-03-04 13:58 ` Rob Herring
2025-03-04 14:07 ` Svyatoslav Ryhel
2025-03-04 14:38 ` Svyatoslav Ryhel [this message]
2025-03-03 11:55 ` [PATCH v3 2/2] power: supply: Add support for " Svyatoslav Ryhel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAPVz0n3WZOUb41AzNPqMLx8wtPiBJ1jfww7h5xyJaZgu+=RdkA@mail.gmail.com' \
--to=clamor95@gmail.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=robh@kernel.org \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®