From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oa1-f52.google.com (mail-oa1-f52.google.com [209.85.160.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E27A636C0D2 for ; Tue, 21 Jul 2026 13:40:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=pass smtp.client-ip=209.85.160.52 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784641205; cv=pass; b=NKYWpbEO88z3TP1gzmPKnBPNeiIBbbdkw4sTQgrPk03cRwplcIgswNIdNpE7o8BHVSHDN5y8OiD3jAW+XAUcxwiDtPBjUKxj+IriOuKPDIzZ2Rfiwsa6RtXwz4y2O+lKl50UsYIk+W62Fktp+Edur+xpGxS7TXXLafy8DEBrRNE= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784641205; c=relaxed/simple; bh=wWXm2+0RBFt0nyH6v10F5A4NgVlT9JLETtegduZU6qA=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=tIkodZAoziLiJi+Pa6zveGj1GUKqnoIunHq6/m/t36xKgnDsSd6Mnfvxg7dim4s4BlzYTlBXyaSMWLe/KbyvMEoTHdduN14vyyCLWE7QZmG86wB8YivF7KjEMsMPjFGUGCOqJy4gLkS/twwb/dsSR9fsyjXD81hQbCzoJVjfu1Q= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=raspberrypi.com; spf=pass smtp.mailfrom=raspberrypi.com; dkim=pass (2048-bit key) header.d=raspberrypi.com header.i=@raspberrypi.com header.b=fFoZSp+t; arc=pass smtp.client-ip=209.85.160.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=raspberrypi.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=raspberrypi.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=raspberrypi.com header.i=@raspberrypi.com header.b="fFoZSp+t" Received: by mail-oa1-f52.google.com with SMTP id 586e51a60fabf-455ca262ccbso6110776fac.1 for ; Tue, 21 Jul 2026 06:40:03 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1784641203; cv=none; d=google.com; s=arc-20260327; b=nu1xNqpFeZ9LhXFInypgcPOZioiu8ytA2mRUNDY0/WnIeL45AaTIgpJHnn97eyDUq8 smp24jOy5o6H6PG5xpfFiCJOCZwB8K9Il3sAFtGyvi/8Uq824WAQBuI6gllFnjGuA0KM eY7LrVk5sbIVCa7/xg2JQa6M9MmLa+lpixF6rOHGnc9IFGNhBRAUa6IVjzSbpXoHSViT nTRs9Ej4hw7veMiNbloRAQP7URaVQXGUnfd5+V0yd57KxHdVYA0ExYZjAIK689hIcYTQ C6n9A0oATnbXJRkt65YTIgCVLQJ+7Vhtx6s0bqaNnC592hXYRRqceFcEGnUsfkJSWNx3 Tdbw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:dkim-signature; bh=9HYiqtLXgsdyAJq0m5/OuD6lcEfSre1c/VzcXGw+L6w=; fh=ho+zJhlNTKhVOdeN2So3fD7M7XCOHbJxQaScSPxTZWg=; b=oGKylUPxiAbHKcB6vMQU7RidX0/mcB6zmAcPooi5OwAooJyVdiYzcTrE5lACwm3ppy PvGl6DBqn9tU302ssgpJsN0R3QPSITBCrLZtsFL7RN2CJOeRtfuE88bkJawssM23CZmS xBQVEEbvRt/ifcOM0VxMeRb6Ga+gbM55fz/45aRIA+d47pko+ZhRqNLw/hyTzrHdFLO1 XkM9W+VlJ75+1kpH2oGW0IeJjP33ZNUdlz3o18/nGAfCM7qanOi+Sy/tMgy8Qwq6w8rj PnGMOBGdV2qDAi4y1DrJ31LZUw+LPSpco3jWh6L9FOJTBjpilrlCwuoZFXa5+R4ukvRQ goYQ==; darn=vger.kernel.org ARC-Authentication-Results: i=1; mx.google.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=raspberrypi.com; s=google; t=1784641203; x=1785246003; darn=vger.kernel.org; h=content-type:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:from:to:cc:subject:date:message-id:reply-to :content-type; bh=9HYiqtLXgsdyAJq0m5/OuD6lcEfSre1c/VzcXGw+L6w=; b=fFoZSp+t0cnSS42e9a/685vlrxKu07Jv03lzOsz4EqZJChPDH7fRq0++wwwQmRKNIj +UJQwSvlHv6rh827fTS0jVNAUbX/ahHTMlSdmz7psUjKl7/Y8GN+MR17e0MnF91Qi29x Ba/lF8fUXH3MrSWv0vhWTYVDksdSyl+NqzmHguLnee6oXs6mGcoH3vjB6AUvQKO8NLXi WbGSKgUDZ5VodAZLWmuEnJXeOP5Dl7IAhm8qIFfTdg1TjefgRiZpNfSiLFZj4C4a9s72 5dWFThCeUrS/6V7exI7XNmYm7W66sMIbvMhf8D/jmOx2fYfNVVn3FKCcq+AJVf0xxI2O K/Xg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784641203; x=1785246003; h=content-type:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to:content-type; bh=9HYiqtLXgsdyAJq0m5/OuD6lcEfSre1c/VzcXGw+L6w=; b=XhPjf/0fq7rP/PSJgbmfKEPSv6xmbMFC19qyeDy37uALAaCO6ny9EYfv2ytml9/RaY NaYT5rE6gK1f1Lg2+UTSRw4z/oz9jHqOLOiYFeH0q1MrgM01DfjXfO+NjXtZNSmA3F/7 FdBxRfomCTZCtu44VOjjgpcRgL30oxYqDdAIypSNu/lzG2Ie3UCgKJfQLMZvBhtpVhz9 IzC7wkZ1uCUIl7wH5HEREg1wCkusV2/TSMtMp4xvAf1SoJ7jKtJH5kEiODu8P478FrgQ RF0OAWle2jEiFVhLOk2TKExgPPdihv1b6egzKBRxAFIgHjMFGf1nQ+NNw7xwZmcgVEAh JP6g== X-Forwarded-Encrypted: i=1; AHgh+RqOgG4cdXlgqTZ7nDiCUVNWnAVCjaJSoTTkHVJwOR911tMbLvg0matWwFMw4NgS8WLn6ega6ZWQidrJeQA=@vger.kernel.org X-Gm-Message-State: AOJu0YzIbSwnV3deYh1FMe8efBErMylNx0NK1BoKysBmxtdPkx/rEc3i X3NR0aNcbyE6O2w6pkVB/CxlnwF0aoNUhs1PEMt2T7JmKiNxJZU2PY331g5RCO6k+DQ8VV/Wb9M noxGhTbbkRqHoc1KLcyrQTId8SG2o5avQDRc+llCu6A== X-Gm-Gg: AR+sD12uBb+bxkMTrzlRUkbuLDiFB6D+VICxM8yPF9mGh59ZGvOO8fCMpH8Del1Yhp2 wobguAT3EblbAZhp5UT63avx7ZTQI+Ie+DVqUkDin2n5/AAXRM9SwaCWcUjLenBduPOcY3zKh0g qdWkHUpHFiwt5ef2H4XMm8spLQLZ6kGLoC5JPy5/J81+dcqzI4qBPjFfIyORK3b2xIrLJRxnLQF 3nGQKFCELP7/bw7nSW4J0NySJZpD04zBfl4Kq6v/BI5qR/bsIRAuzrW25dJqKSMKwUGQC0auIgp 7VRoHNvZkd2KygmUPluBSYLJW5SnepfcdJ3DB3a6xsowX9GVaGP17EPgslat3M1H9CaaBwH4eLI 7aaL7RpNVzXEp5Q== X-Received: by 2002:a05:6870:270:b0:456:5d8b:5681 with SMTP id 586e51a60fabf-4569013a65dmr8645087fac.1.1784641202556; Tue, 21 Jul 2026 06:40:02 -0700 (PDT) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20260721-cci-single-v1-0-8485171e1393@linux.dev> <20260721-cci-single-v1-2-8485171e1393@linux.dev> In-Reply-To: <20260721-cci-single-v1-2-8485171e1393@linux.dev> From: Dave Stevenson Date: Tue, 21 Jul 2026 14:39:46 +0100 X-Gm-Features: AUfX_mzd8rc263fLRvHLGxAGoqDqLvIm6oB7vlGb0QE_5L4g9MRdIK3TjhLIAO8 Message-ID: Subject: Re: [PATCH 2/2] media: ov9282: enable single-read I2C transactions To: Richard Leitner Cc: Mauro Carvalho Chehab , Sakari Ailus , Laurent Pinchart , Hans de Goede , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Hi Richard On Tue, 21 Jul 2026 at 14:25, Richard Leitner wrote: > > Some OV9282 camera modules, such as those from Vision Components, fail > multi-byte register reads with the default CCI I2C regmap access pattern > and only work when single-register read transactions are used. This > results in the driver being unable to probe due to a chip id mismatch. Those damn stupid Vision Components modules with the MCU that prevents you reading registers. I seem to recall Laurent had a plan for how to handle those without having to patch all the drivers, however I can't find that thread quickly. > As the driver has no reliable way to identify affected modules enable > use_single_read for OV9282 unconditionally when creating the CCI regmap. > > Tested on an i.M8MP system with OV9282 modules from Vision Components. > > Signed-off-by: Richard Leitner As regmap does provide a simple way to request this behaviour, and the only read is the ID register from ov9282_detect, I'll give it an Acked-by: Dave Stevenson but it's not an ideal situation. Others can debate the alternative approaches for handling VC modules. Dave > --- > drivers/media/i2c/ov9282.c | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git a/drivers/media/i2c/ov9282.c b/drivers/media/i2c/ov9282.c > index 5b6f897a74fcd..8267a0a9c6f2d 100644 > --- a/drivers/media/i2c/ov9282.c > +++ b/drivers/media/i2c/ov9282.c > @@ -1283,6 +1283,11 @@ static int ov9282_probe(struct i2c_client *client) > struct ov9282 *ov9282; > int ret; > > + const struct cci_regmap_config config = { > + .reg_addr_bits = 16, > + .use_single_read = true, > + }; > + > ov9282 = devm_kzalloc(&client->dev, sizeof(*ov9282), GFP_KERNEL); > if (!ov9282) > return -ENOMEM; > @@ -1301,7 +1306,7 @@ static int ov9282_probe(struct i2c_client *client) > return ret; > } > > - ov9282->regmap = devm_cci_regmap_init_i2c(client, 16); > + ov9282->regmap = devm_cci_regmap_init_i2c_cfg(client, &config); > if (IS_ERR(ov9282->regmap)) > return dev_err_probe(ov9282->dev, PTR_ERR(ov9282->regmap), > "Failed to init CCI\n"); > > -- > 2.53.0 > >