mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Dave Stevenson <dave.stevenson@raspberrypi.com>
To: Maxime Ripard <maxime@cerno.tech>
Cc: Emma Anholt <emma@anholt.net>, Maxime Ripard <mripard@kernel.org>,
	David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>,
	Eric Anholt <eric@anholt.net>,
	dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
	Mateusz Kwiatkowski <kfyatek+publicgit@gmail.com>
Subject: Re: [PATCH 08/15] drm/vc4: hvs: Ignore atomic_flush if we're disabled
Date: Mon, 9 Jan 2023 10:32:37 +0000	[thread overview]
Message-ID: <CAPY8ntDmSKB-u2FNALeGgh2bZwxDfPXGnP1kV4LnGT_NrZ-4Wg@mail.gmail.com> (raw)
In-Reply-To: <20221207-rpi-hvs-crtc-misc-v1-8-1f8e0770798b@cerno.tech>

Hi Maxime

On Wed, 7 Dec 2022 at 11:55, Maxime Ripard <maxime@cerno.tech> wrote:
>
> atomic_flush will be called for each CRTC even if they aren't enabled.
>
> The whole code we have there will thus run without a properly affected
> channel, which can then result in all sorts of weird behaviour.
>
> Signed-off-by: Maxime Ripard <maxime@cerno.tech>

Reviewed-by: Dave Stevenson <dave.stevenson@raspberrypi.com>

> ---
>  drivers/gpu/drm/vc4/vc4_hvs.c | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/drivers/gpu/drm/vc4/vc4_hvs.c b/drivers/gpu/drm/vc4/vc4_hvs.c
> index 3582ede1a0aa..5fadbf219542 100644
> --- a/drivers/gpu/drm/vc4/vc4_hvs.c
> +++ b/drivers/gpu/drm/vc4/vc4_hvs.c
> @@ -579,6 +579,9 @@ void vc4_hvs_atomic_flush(struct drm_crtc *crtc,
>                 return;
>         }
>
> +       if (vc4_state->assigned_channel == VC4_HVS_CHANNEL_DISABLED)
> +               return;
> +
>         if (debug_dump_regs) {
>                 DRM_INFO("CRTC %d HVS before:\n", drm_crtc_index(crtc));
>                 vc4_hvs_dump_state(hvs);
>
> --
> 2.38.1

  reply	other threads:[~2023-01-09 10:42 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-07 11:53 [PATCH 00/15] drm/vc4: Misc fixes and improvements for the HVS and CRTCs Maxime Ripard
2022-12-07 11:53 ` [PATCH 01/15] drm/vc4: hvs: Configure the HVS COB allocations Maxime Ripard
2022-12-07 11:53 ` [PATCH 02/15] drm/vc4: hvs: Set AXI panic modes Maxime Ripard
2022-12-07 11:53 ` [PATCH 03/15] drm/vc4: hvs: SCALER_DISPBKGND_AUTOHS is only valid on HVS4 Maxime Ripard
2022-12-07 11:53 ` [PATCH 04/15] drm/vc4: hvs: Correct interrupt masking bit assignment for HVS5 Maxime Ripard
2022-12-07 11:53 ` [PATCH 05/15] drm/vc4: hvs: Support zpos on all planes Maxime Ripard
2022-12-07 11:53 ` [PATCH 06/15] drm/vc4: hvs: Fix colour order for xRGB1555 on HVS5 Maxime Ripard
2022-12-07 11:53 ` [PATCH 07/15] drm/vc4: hvs: Add DRM 210101010 RGB formats Maxime Ripard
2022-12-07 11:53 ` [PATCH 08/15] drm/vc4: hvs: Ignore atomic_flush if we're disabled Maxime Ripard
2023-01-09 10:32   ` Dave Stevenson [this message]
2022-12-07 11:53 ` [PATCH 09/15] drm/vc4: plane: Allow using 0 as a pixel order value Maxime Ripard
2022-12-07 11:53 ` [PATCH 10/15] drm/vc4: plane: Omit pixel_order from the hvs_format for hvs5 only formats Maxime Ripard
2022-12-07 11:53 ` [PATCH 11/15] drm/vc4: plane: Add 3:3:2 and 4:4:4:4 RGB/RGBX/RGBA formats Maxime Ripard
2022-12-07 11:53 ` [PATCH 12/15] drm/vc4: Add comments for which HVS_PIXEL_ORDER_xxx defines apply Maxime Ripard
2022-12-07 11:53 ` [PATCH 13/15] drm/vc4: crtc: Fix timings for VEC modes Maxime Ripard
2022-12-07 11:53 ` [PATCH 14/15] drm/vc4: hdmi: Correct interlaced timings again Maxime Ripard
2022-12-07 11:53 ` [PATCH 15/15] drm/vc4: vec: Support progressive modes Maxime Ripard
2023-01-09 14:53 ` [PATCH 00/15] drm/vc4: Misc fixes and improvements for the HVS and CRTCs Maxime Ripard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAPY8ntDmSKB-u2FNALeGgh2bZwxDfPXGnP1kV4LnGT_NrZ-4Wg@mail.gmail.com \
    --to=dave.stevenson@raspberrypi.com \
    --cc=airlied@gmail.com \
    --cc=daniel@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=emma@anholt.net \
    --cc=eric@anholt.net \
    --cc=kfyatek+publicgit@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maxime@cerno.tech \
    --cc=mripard@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®