From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752697AbdDISEF (ORCPT ); Sun, 9 Apr 2017 14:04:05 -0400 Received: from mail-oi0-f43.google.com ([209.85.218.43]:33395 "EHLO mail-oi0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752559AbdDISEE (ORCPT ); Sun, 9 Apr 2017 14:04:04 -0400 MIME-Version: 1.0 In-Reply-To: <0ff6e139159043e3416b0e5bc89e9aa5399bbb8e.1490601847.git.geliangtang@gmail.com> References: <0ff6e139159043e3416b0e5bc89e9aa5399bbb8e.1490601847.git.geliangtang@gmail.com> From: Dan Williams Date: Sun, 9 Apr 2017 11:04:02 -0700 Message-ID: Subject: Re: [PATCH] dmaengine: ioat: use setup_timer To: Geliang Tang Cc: Vinod Koul , Dave Jiang , "dmaengine@vger.kernel.org" , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Apr 8, 2017 at 6:41 PM, Geliang Tang wrote: > Use setup_timer() instead of init_timer() to simplify the code. > > Signed-off-by: Geliang Tang > --- > drivers/dma/ioat/init.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/dma/ioat/init.c b/drivers/dma/ioat/init.c > index cc5259b..6ad4384 100644 > --- a/drivers/dma/ioat/init.c > +++ b/drivers/dma/ioat/init.c > @@ -760,9 +760,7 @@ ioat_init_channel(struct ioatdma_device *ioat_dma, > dma_cookie_init(&ioat_chan->dma_chan); > list_add_tail(&ioat_chan->dma_chan.device_node, &dma->channels); > ioat_dma->idx[idx] = ioat_chan; > - init_timer(&ioat_chan->timer); > - ioat_chan->timer.function = ioat_timer_event; > - ioat_chan->timer.data = data; > + setup_timer(&ioat_chan->timer, ioat_timer_event, data); > tasklet_init(&ioat_chan->cleanup_task, ioat_cleanup_event, data); > } > > -- > 2.9.3 > Reviewed-by: Dan Williams