From: Song Liu <song@kernel.org>
To: Xiaomeng Tong <xiam0nd.tong@gmail.com>
Cc: rgoldwyn@suse.com, Guoqing Jiang <guoqing.jiang@linux.dev>,
linux-raid <linux-raid@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>,
stable@vger.kernel.org
Subject: Re: [PATCH v3] md: fix an incorrect NULL check in md_reload_sb
Date: Fri, 8 Apr 2022 09:36:14 -0700 [thread overview]
Message-ID: <CAPhsuW4dTNShcoHGL1_t_=6f-+P3CSLTexSy+Mv2+HZSk8skOA@mail.gmail.com> (raw)
In-Reply-To: <20220408084715.26097-1-xiam0nd.tong@gmail.com>
On Fri, Apr 8, 2022 at 1:47 AM Xiaomeng Tong <xiam0nd.tong@gmail.com> wrote:
>
> The bug is here:
> if (!rdev || rdev->desc_nr != nr) {
>
> The list iterator value 'rdev' will *always* be set and non-NULL
> by rdev_for_each_rcu(), so it is incorrect to assume that the
> iterator value will be NULL if the list is empty or no element
> found (In fact, it will be a bogus pointer to an invalid struct
> object containing the HEAD). Otherwise it will bypass the check
> and lead to invalid memory access passing the check.
>
> To fix the bug, use a new variable 'iter' as the list iterator,
> while using the original variable 'pdev' as a dedicated pointer to
> point to the found element.
>
> Cc: stable@vger.kernel.org
> Fixes: 70bcecdb1534 ("md-cluster: Improve md_reload_sb to be less error prone")
> Signed-off-by: Xiaomeng Tong <xiam0nd.tong@gmail.com>
Applied to md-next. Thanks!
prev parent reply other threads:[~2022-04-08 16:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-08 8:47 Xiaomeng Tong
2022-04-08 16:36 ` Song Liu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAPhsuW4dTNShcoHGL1_t_=6f-+P3CSLTexSy+Mv2+HZSk8skOA@mail.gmail.com' \
--to=song@kernel.org \
--cc=guoqing.jiang@linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-raid@vger.kernel.org \
--cc=rgoldwyn@suse.com \
--cc=stable@vger.kernel.org \
--cc=xiam0nd.tong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®