From: Song Liu <song@kernel.org>
To: Namhyung Kim <namhyung@kernel.org>
Cc: Arnaldo Carvalho de Melo <acme@kernel.org>,
Ian Rogers <irogers@google.com>,
Kan Liang <kan.liang@linux.intel.com>,
Jiri Olsa <jolsa@kernel.org>,
Adrian Hunter <adrian.hunter@intel.com>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
linux-perf-users@vger.kernel.org,
James Clark <james.clark@linaro.org>
Subject: Re: [PATCH v2] perf tools: Skip BPF sideband event for userspace profiling
Date: Fri, 28 Feb 2025 16:25:03 -0800 [thread overview]
Message-ID: <CAPhsuW5JFP-QuE_HZBJm+RT+ytsV72ihP0g_CvByKB_S+fHV_g@mail.gmail.com> (raw)
In-Reply-To: <Z8JS2P-QwHcPUpTV@google.com>
On Fri, Feb 28, 2025 at 4:20 PM Namhyung Kim <namhyung@kernel.org> wrote:
>
> On Thu, Feb 27, 2025 at 10:50:26AM -0800, Song Liu wrote:
> > On Wed, Feb 26, 2025 at 9:17 PM Namhyung Kim <namhyung@kernel.org> wrote:
> > >
> > > The BPF sideband information is tracked using a separate thread and
> > > evlist. But it's only useful for profiling kernel and we can skip it
> > > when users profile their application only in userspace.
> > >
> > > It seems it already fails to open the sideband event in that case.
> > > Let's remove the noise in the verbose output anyway.
> > >
> > > Cc: Song Liu <song@kernel.org>
> > > Signed-off-by: Namhyung Kim <namhyung@kernel.org>
> >
> > This turns out to be more complicated than I thought. I actually
> > like v1 better.
>
> Sure, the complexity comes from moving the code to reduce the
> duplication. But either is fine to me.
>
> Can I add your Acked-by to v1, then?
Yes, you can add to v1:
Acked-by: Song Liu <song@kernel.org>
Thanks,
Song
prev parent reply other threads:[~2025-03-01 0:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-27 5:17 Namhyung Kim
2025-02-27 18:50 ` Song Liu
2025-03-01 0:20 ` Namhyung Kim
2025-03-01 0:25 ` Song Liu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPhsuW5JFP-QuE_HZBJm+RT+ytsV72ihP0g_CvByKB_S+fHV_g@mail.gmail.com \
--to=song@kernel.org \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=irogers@google.com \
--cc=james.clark@linaro.org \
--cc=jolsa@kernel.org \
--cc=kan.liang@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®