From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ua1-f49.google.com (mail-ua1-f49.google.com [209.85.222.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0312133CE8A for ; Fri, 15 May 2026 00:38:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=pass smtp.client-ip=209.85.222.49 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778805533; cv=pass; b=NaOlFS56JApcj3JtAFyXMhjLvKLss0SCMprXqwINX408bsR9y71xbXL09EFE+UoKLJLQtkvBuRHjqrcABJKeeM+vKX66Ecp2p0l7ex/HpdrIgdApa7b4YR7A7rSJIVWfmQEpm1CuUUSXqM8NxzVPc183MJKv18AuBCFWyYILOk8= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778805533; c=relaxed/simple; bh=UTymBo1a9R/y0q8icpfUt0V06SWFg+3XgUqWiI9+NS8=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=W8xTf4W7usyFUW+HKgy0CrcD+09AgEUziaLqnHVrLEbnolySjvhPGD3ghQzj+3iD9WkoVAz++5RdpHhUm1BXXIeNQT9vLdkpH29yFH8Hi1X1bb9fESSN7GVCGSGdvn/X+/cBrUtgN4pfstqMPA3Y4+5eAbk8Co2esynuBJBT/II= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=purestorage.com; spf=fail smtp.mailfrom=purestorage.com; dkim=pass (2048-bit key) header.d=purestorage.com header.i=@purestorage.com header.b=U0ym/cbe; arc=pass smtp.client-ip=209.85.222.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=purestorage.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=purestorage.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=purestorage.com header.i=@purestorage.com header.b="U0ym/cbe" Received: by mail-ua1-f49.google.com with SMTP id a1e0cc1a2514c-95cc96eac66so5019978241.1 for ; Thu, 14 May 2026 17:38:50 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1778805529; cv=none; d=google.com; s=arc-20240605; b=AL9rH11io/unqs0Y91nJgXFbzMf+pdpy6hUcKvaIxqmeyiM72USAEHyuQbNKnMIZA5 2XhcppVAYUVkxjseq7b4qsHEHG5nkVyIVGoc0LIB5X51XzytaK2C1sAhYeJ4y2IgTvzl LROmshNR32BPZO6sgKGMSTx2RPMvyzx9Kipz5EVRZZSEtYX0+FaiSGHDhbSrk11om6yN AYHNCv0wRZppseeOR1Jhl7hV4tA5p8s2o/mdGBdnX3wK71T3XMZWfsEqj0+R25cZUYl8 KzEjpATSgziyT9/qXoP24hoj7PsPXFAd9AAV1Zv9WgTNHcQLvxCVs5uxzniNUW8bF5dU 2YbA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=8xQfgZ7+IQZ7TOJ0Rz2Wyj2D0WsNeMpOwH26MIpwY7o=; fh=wB1P65Cma+oa6A30CUeRqkG9l/yapx+YofSSz5M00uk=; b=ML550ezXKlSiA7qIWXDya9lXfJtOvMNEeg5ZyKu415eWe75WMdqJPiAOVPdGlRjCr4 7ogtUvvwIPLb6xo7d3YEm/pKU09If0pkimetXN7TIgf1gt/z/dXDFO388APB3323Haxa 65IQMK99qUZ/Y+pvT3OUcI8CP1NrgLXpXVnGoL+ao6k70LFfcqvOt4Lc+6oU3YyR5RbC vqDDLJM9PuxDQJXx90e+2jUBA6VLBUI5j2llIxHiQH/eC8a0FKhVXY83M8sLfxmDb9I0 5YXxNPaaFEqe2Nnt2TzbLhlwyhiLkyMF0rQmHXXGCv8a8+g33CLDrypm4vHFYfMKVOOQ cAPw==; darn=vger.kernel.org ARC-Authentication-Results: i=1; mx.google.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=purestorage.com; s=google2022; t=1778805529; x=1779410329; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=8xQfgZ7+IQZ7TOJ0Rz2Wyj2D0WsNeMpOwH26MIpwY7o=; b=U0ym/cbeH95sPT6qJp60tq6YJ6IE61rY0X/+++EAFUW5wsTc80zo+2+77G3PHZeBwV rpgPUVJeKd4/Ar2DAXNN2079fP2Odfrb48HLLQ82l+FoBRLPCcj3ohMP9E7d8Pzxq4QG +eoCB94h9kpdxp8vAEZvKrWLVaoksbAoKimphozuUZVYUgedteQ4By0vsanhq6P8BFUV UEWEHV6NwwFqmwxxXMFS8LJmD1AdEFJjPWXJvxl8GB/ggijUjy/XHQ7O28y1hgON4h81 WYclitDetEi2BCD6Eb4VP7eA7aSdoE397Z2opDIdrF89unZaGhE8QBjHMCyMleuaPENC 54wQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778805529; x=1779410329; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=8xQfgZ7+IQZ7TOJ0Rz2Wyj2D0WsNeMpOwH26MIpwY7o=; b=IQzL31fCIiVyggjJuDnnUlasF55A/Q0JTtVABrjql0tvqEn6usd9+/y+Ng3ZYUWLW1 ECdkjQCqxjIyyhB7pg7giiXx9e844EchS4KfwJemScOfL/K/VWUJDV7NdafzaDlnGaR1 Fnd60xfS3nVWRHdSazgtYrtkpgboybhePCosndoY3eFyN6H115dM/bn85oiSpsfnFLgE hDloIjFbjhZ1hKJxfx/09eHeU+w/+lRzu2Hc+4gDmEctXXDQV2UeXvU1S3E5lSkSUfws hg8vSk+cdk84P6OvZoW5tWkZN437Lx9aRGj9PPp8TTlbGIAGzT56aP+zf/wq79N/VFf0 sltA== X-Forwarded-Encrypted: i=1; AFNElJ/CQkhHrRBjpCpD5oeXe9smYhXV3p3DjbNG1By6Es9RtwTqcIVCCwwnfGRTkWM0PWvb7zEnPnO+3ZCs24w=@vger.kernel.org X-Gm-Message-State: AOJu0YwtZaggWkGZO6tx1ENUD71SsN5MwFUehCRwX4bjNcG+FAfR7NFB eMU+FQsfe1q3OHTjoPYtB7LHwur2c86768cRT6aDcLGI2RnayXTUcADPlH0gQvuwj3zoejzSYlF xIqOifBEXQQUx0mTtb5t1i/nhf1gLotNVgFZXaWlnEA== X-Gm-Gg: Acq92OF8YlBBZ7b71xpi1oeA09CW66mSI+FcGORpSCIxJbIla4VMORmPZUdGsHljRMh WTtGXEfnCYdKcEcx03jsQkVJ94XMOlMUFTwT7rOUkraWlE8P1ebg9tV72V1RYyjcHtRj1ZG+LYM NunFXbwNTXlE6MzOzmEeM10hf17igi0utQogMwAWjggPZ/vhpx76PRxxwJdl5wyffgUoDr4L8VF HHRDqpvZntjqfPdNp3xsYQMOaG7Ds4v0xLuEGymNyouwo7XACj0zY8bU9tzKE40dvxt9KmuCNT7 crBCwKN0KxrOTrWoE407k7sVREU3khhChHjn2VSAxqW1w2I43gszogi3l1DTru+LGg4xxA== X-Received: by 2002:a05:6102:3713:b0:62f:3e1d:a55a with SMTP id ada2fe7eead31-63a3cc12f5amr898246137.2.1778805529354; Thu, 14 May 2026 17:38:49 -0700 (PDT) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20260328004518.1729186-1-mkhalfella@purestorage.com> <20260328004518.1729186-5-mkhalfella@purestorage.com> In-Reply-To: <20260328004518.1729186-5-mkhalfella@purestorage.com> From: Randy Jennings Date: Thu, 14 May 2026 17:38:35 -0700 X-Gm-Features: AVHnY4Jagk0hEroyvK1-XIG-of4mRpbaCQFLepJO8pqDIg6aN6SdwHdS3av7koY Message-ID: Subject: Re: [PATCH v4 04/15] nvmet: Implement CCR logpage To: Mohamed Khalfella Cc: Justin Tee , Naresh Gottumukkala , Paul Ely , Chaitanya Kulkarni , Jens Axboe , Keith Busch , Sagi Grimberg , James Smart , Hannes Reinecke , Aaron Dailey , Dhaval Giani , linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Fri, Mar 27, 2026 at 5:45=E2=80=AFPM Mohamed Khalfella wrote: > > Defined by TP8028 Rapid Path Failure Recovery, CCR (Cross-Controller > Reset) log page contains an entry for each CCR request submitted to > source controller. Implement CCR logpage for nvme linux target. > +/* NVMe Cross-Controller Reset Status */ > +enum { > + NVME_CCR_STATUS_IN_PROGRESS, > + NVME_CCR_STATUS_SUCCESS, > + NVME_CCR_STATUS_FAILED, > +}; > + Looking at the rest of the code, all the enums are defined except /* NVMe Namespace Write Protect State */ which does define the value of the first entry (0). I think it would be prefereable to add explicit values here (0, 1, 2) even though the implicit values should be correct. Sincerely, Randy Jennings