From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-vk1-f173.google.com (mail-vk1-f173.google.com [209.85.221.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AF99F275B03 for ; Sat, 16 May 2026 00:45:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=pass smtp.client-ip=209.85.221.173 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778892317; cv=pass; b=aOBEbyLo6MX1U0zdHqpQUMxADy579L0qBSrqgUbr5uIftF3Jm30ZCcgVWwmRgH6W/rTDs+JXQ+WN/oXvR58s/KNwLM7NcVnVk333wQ/jFNcOKL3ybydh3SZAvn/UckJ9DImrgSUL6N4IdhpaszhzYIi6+WjbDGL9i1WWVctbZDk= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778892317; c=relaxed/simple; bh=kT9+VkGTgEgW4t76TdSqhjL5RKmZqQQGkXh6/MXI6+4=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=U6NlUcIlfQmpBWyttrONoZCq6nbM/KkWLl1TIxeRKuo1ZT+RI3FoWt0/ls97mnSaKDdHDssHxyME+O45kS2n1318cfZgE4GP2G8kQrsKE5SWwz38oOj1g/+5V/eyOsP1gZELObfVsWEYoBIxrjh1tYPIGgywyTW+c8J0JTh3Cdk= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=purestorage.com; spf=fail smtp.mailfrom=purestorage.com; dkim=pass (2048-bit key) header.d=purestorage.com header.i=@purestorage.com header.b=Il220kTX; arc=pass smtp.client-ip=209.85.221.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=purestorage.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=purestorage.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=purestorage.com header.i=@purestorage.com header.b="Il220kTX" Received: by mail-vk1-f173.google.com with SMTP id 71dfb90a1353d-5637886c92aso176646e0c.0 for ; Fri, 15 May 2026 17:45:14 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1778892314; cv=none; d=google.com; s=arc-20240605; b=RXXKD54m8rxqow3qfOwzjwdzvMCGUy7u/RvmW31KYCxiN8GLtHxMcUrnLr/YpDUE3A AQLiA9aoSeRvyIIVd71szgo4wAN/VTed8UD7R8dYo41SDs9MM7OBtHDltCmeeiij9U++ pLTUcizApstBiGz1oder/1x7O7ijPAyOojHMUrBdw0A4Ch2Jex+s6AMLwpDYbMZ5chmo hi4PAT/nm9vQC8nNQA5Hjgv0Tq8uoLTmvOiwRkdOivv8Jzlj4wlV+nWdxsdcnrB9Hrs5 VaoJYtFGJOzSQFmKi5yMzgDs7XXl+CVTAz+BfiuywMxOEQzSHbynnZOgYqXqJapdtlmc PzAg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=lKyj+BgFWLyIjd7FQWgJlKDISSTkRJ7PSBxk5ZXeyDY=; fh=KqNT2SvZkj6Y/fFbEGuVpBQp+F0a3/IXm0oTNj4fseQ=; b=bau7ILYnPa9u7B433KrET9q/brvQD50j1e4wcWGokivKQeUc9XDGTiu058qeZwR9gg g5UqRhDck4FXb0Gdkm+vquH2LEQ2F2xAEJFazsf9enRfoSBDtKF4dbvNVXHsSES2TPnV lvn6Ihf3xeZgjQHUpwfHrd1ZWGI2UkWoVrHhWXWnSWZONMxhf6I6Tl2lScMxGvBZm1Us PICHEpEq2RiRVpQCZgafCxF1IAL/UI9BPq3YMuFs/Hsed4qxXryGpO3gVpGG620guQcb PSGHVO3XPUMhzH8S5vrfVZF6ZTkj9+/5wHFgQDZxzqIQYXoBD6ZBThg8A81cWxAYkUda RFgQ==; darn=vger.kernel.org ARC-Authentication-Results: i=1; mx.google.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=purestorage.com; s=google2022; t=1778892314; x=1779497114; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=lKyj+BgFWLyIjd7FQWgJlKDISSTkRJ7PSBxk5ZXeyDY=; b=Il220kTXHabITz6P88SIm7WJdBaczqdE4AF0njKBEf063rC37xl1XHHVdzIwGKHi8X bdriTmST9AAvOlnK2on2Zs4RWSgaIJ4WoNMplwVVjOuJolxNlwMEMcagGRknuIF6xrNn GfLnaCAvJmuw9Desn5oTFOGrbBhriup4+NHvf/q/lTG5IkstqpYgC+nDPK0R+iY3Qi8F 4ZWFhKWha7Brb75ltGO76KDTnl8RSxsEsw2yLP1RbQA21HKKucBgwtEfTOAI8ppZrJ36 H/dvFpvXK4ROXCE7G9bbx5gVObx1cF7YwLfx/LG8lPTVe4VPK1KFNIt0XwIG4BpMS7AW x4DA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778892314; x=1779497114; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=lKyj+BgFWLyIjd7FQWgJlKDISSTkRJ7PSBxk5ZXeyDY=; b=Z1VKi5pXpJpW7kWKh0oDI2oheJ1cZIaz4HFRs0RdEYKa9YAbgf2u5nv7HMIwdaKyXD Mkcd74yAchCiMFNZJ1Fz5IrkJzT4Eo9ubLxljF5Yrp1mEmhTA0UHeEgj4gavfKq5cAiW lC49D5dZmC7M/fz3xzL0yRRx0OjTLYhe+AqGRohf5CQTuSjD7GSzwqIWYpYxEIc87daN n5ev8gGJvK3w/CrE9m3iGrKBTd7l+whz7fmo2YUCNFmK71P8FX3mcFVBeMIjWz0P/lS/ vmxm/Bt8iYb5vxjf+/Ye7zPLba6djecDTsBwQIy/WFAvo/h0U2K0TgSHh0s5+EiA/V2q XlxA== X-Forwarded-Encrypted: i=1; AFNElJ8xQ62KXiEOVdTGsoWDonFNvzM/XyQTEjiWfUMlFnDGKHtE8blm/IayAtIS/HUXZcNVSVlMuTpZ9X9CzH8=@vger.kernel.org X-Gm-Message-State: AOJu0YwHczGrLjsvJXbw5sqvPoXq5CvL1AAfNfu4l/AnOje9hI70HY68 nDuBuBi0IOZdHhoLHsozmOH/YH3BkhIl16u3lJEWeQAJQdAiVnIbEtgyX2NnJwzhYzTiyzuA7+R hOcyM/H20Vxdtvie2yun+e0m4zmsiDvYKUcck2Uq5Sw== X-Gm-Gg: Acq92OFkqQ8O6LNvH39kpOtCGQ9zqlxDvKLgWX5ARXQcU2WfUTBMeAZET4AdqWRz6GT Vy+f1yiZ3KqmiQOcETjSgn4Wyu8qWw2CEbcUX0cwqi+w5CPrt08uGsDBsHeLmseo1tiV/vpv9NF XlgDcxGMTywXMByB6rkQu5urQ0J4kHss8ET6S6eHoHOCQJinf30wIkit714nmzwLzn71f44AhAt A2zXuAQ7L2ZU2/tPmjyjbN6fpW8otw/zSQ4P/9V2vz1sbfil9pXIbxFKkok6jakLmDD7Qz9ujxP G5lEnJsCnGlCoeE/R7slXSVXJrteaQix3rP1UAbtdP+YDygLZqi1hu/t03QteYx3XD6z X-Received: by 2002:a05:6122:614e:b0:575:362c:4789 with SMTP id 71dfb90a1353d-5760c04afacmr4192977e0c.11.1778892314091; Fri, 15 May 2026 17:45:14 -0700 (PDT) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20260214042753.4073668-1-mkhalfella@purestorage.com> <20260214042753.4073668-14-mkhalfella@purestorage.com> <20260326174011.GP3435530-mkhalfella@purestorage.com> In-Reply-To: <20260326174011.GP3435530-mkhalfella@purestorage.com> From: Randy Jennings Date: Fri, 15 May 2026 17:45:02 -0700 X-Gm-Features: AVHnY4LGhzl5g_Zq7gvz-N65t3wuwLV_QpG7AbKlEHKhLwGN6XHR4RMnkASItDg Message-ID: Subject: Re: [PATCH v3 13/21] nvme-fc: Use CCR to recover controller that hits an error To: Mohamed Khalfella Cc: James Smart , Justin Tee , Naresh Gottumukkala , Paul Ely , Chaitanya Kulkarni , Christoph Hellwig , Jens Axboe , Keith Busch , Sagi Grimberg , Hannes Reinecke , Aaron Dailey , Dhaval Giani , linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Thu, Mar 26, 2026 at 10:40=E2=80=AFAM Mohamed Khalfella wrote: > > On Fri 2026-02-27 17:03:55 -0800, James Smart wrote: > > On 2/13/2026 8:25 PM, Mohamed Khalfella wrote: > > What bothers me in this process is - there are certainly conditions > > where there is not connectivity loss where FC can send things such as > > the ABTS or a Disconnect LS that can inform the controller to start > > terminating. Its odd that we skip this step and go directly to the CCR > > reset to terminate the controller. We should have been able to continu= e > > to send the things that start to directly tear down the controller whic= h > > can be happening in parallel with the CCR. > > Depending on how the target is implemented ABTS or Disconnect LS do not > guarantee inflight IOs are terminated. CCR main point is terminate > inflight IOs making it safe to retry failed IOs. James, yes, there are circumstances where traffic on the connection is flowing fine, and this request is just a problem child. That is the problem NVMe Cancel is trying to solve, and John is looking at getting that wrapped into the code. I would expect that FC ABTS could just substitute for NVMe Cancel (if desired) when that change comes. For now, we are trying to overcome the data corruption, and canceling/aborting an individual request is an important, but subordinate, optimization. Sincerely, Randy Jennings