From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f51.google.com (mail-ej1-f51.google.com [209.85.218.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AA5BD29BDB1 for ; Sat, 21 Feb 2026 02:15:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=pass smtp.client-ip=209.85.218.51 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771640155; cv=pass; b=pr1RXMAiQF50Y9XmmftmTJsoqYjji8d/UTtjuGyBLwoHHdN1Cyvg/CPLikBYMlF0TYBIv5crEKKp80mWYc1Rr5rgP09N17FwX49oT+KHt+oYwv1Q4+CdmLWzFmd+8sKkf+6sWTsTRrfQsDjRgoV6693bBqXlAVQ3ki3TbPXLR5I= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771640155; c=relaxed/simple; bh=cwVJpYds9WRhqGxgtRAz+YHH/axeAs5tYhVkRL3n+NY=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=XG+m4fy473Vx+vjaTueZYcNXGNdLN/KRidELAmZM6giOwTS+jAZl4FFxzv4PNzaHYxVJuibcQEQUY2NSsQiVaFl/k3bdP/ohD3wYeBvl7a3dz7xhvkfOzPDWPMpvDAq6E6eaT9aDxPGtOsAbQZlDgnOu7V9uxymjvY6ByibH8Wc= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=NfQV4gkQ; arc=pass smtp.client-ip=209.85.218.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="NfQV4gkQ" Received: by mail-ej1-f51.google.com with SMTP id a640c23a62f3a-b8fd976e90cso356968166b.0 for ; Fri, 20 Feb 2026 18:15:54 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1771640153; cv=none; d=google.com; s=arc-20240605; b=SIL8zQrMc2a8XfC7wnG5EV+T3UfjgFu8ESjb8QH/a8uFy+180QA9kGXei7kcJyb5o6 D6dMT+8m2s9wUQONWTJJiTilWgYwKR2ZHAeCM8xrJQDQUIimXSOcKHeAeHkKcTOhtWlD 8nmSoE8MOtBoje6fllUDolcG3BQmzcbtKgfRTxo2NExO0VFuGsxflc1+K2vyEJ7Wk2YI 9wFZjBqhE4/hBm7nBq/NOCBp07zE/sq1mEGE7s0osWXccPOrVO+RbpwwShqTsjtXfXY6 YiLOHrLCWMyBOFnSLYo4ZtdrHwkoO9U8GNFmx/1OYQDd8dnMR4OVrCZKBQv3tYyWtXuS MUcA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:dkim-signature; bh=cwVJpYds9WRhqGxgtRAz+YHH/axeAs5tYhVkRL3n+NY=; fh=gxLLYRhHUtGhmkbKV/xSk+k6F0BaNQXH+TG0d4QvtW4=; b=cAdK80TENT4uVYQoqjPWmr62AAI4JPTNsyz0I2QH0psN8Kpzbimm62S/HyByLIFE5/ L1pJSyVSzAV5neJGIAmAGNMG/D7HZ+BCId1jab5lkFPERWXQe2eSUa7TU+SFwJFmGw24 VX9ukeROFimOKZzFe1ftcpcptBPuXP30g8cP81c82JPCwOemQ3uTbkBF5HVE5OSCafEz xZSOsSF2nQ9f6aytwWnp0gnYYNOwfTgV50PJhmXV+ArGqxUOG38AEyKPSklXI7hb1SIs jxG3AoqBkAhG2VQcRBCJyRHLv4yjSRfj1RNmpGSK6Ynk/9u4dsUHZPoR6kzKskKAgaMJ +w2w==; darn=vger.kernel.org ARC-Authentication-Results: i=1; mx.google.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1771640153; x=1772244953; darn=vger.kernel.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=cwVJpYds9WRhqGxgtRAz+YHH/axeAs5tYhVkRL3n+NY=; b=NfQV4gkQ+/Lyk7eVnL/DiyVroz58r5jwR19LKO1YVxm9JzPsNR/8RX4LIdeg+9FlSB /1iIu/4tSSV9ceA9QzLKDyH0o0cK8pOcDg4nUt7zUTNHtQE8grAsFwH3WChp5Bm3Hfhj Jnqvc2VigJPGxYaekcVCAMyeNy+WhTKn59bW5eqn660muAFIXvNd+rsmxvSjTl1nPnaz CRzXkzyKC2Lz4mdjBHp+hkgNJAyb9a+YSf2cmfP8nRwfUUoTjuJIBgO29a1JrjcuFn1Q mxPcpZtq0dXD2OURsniMUfNfnFvl9wTHXHof4YlWavuJISW6tgd7GHP0+wUtnjAsEiQm pCrg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771640153; x=1772244953; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=cwVJpYds9WRhqGxgtRAz+YHH/axeAs5tYhVkRL3n+NY=; b=tc+pr3Q/2tTbLBb9U+cuyBzNIPTqpYpw7NiZ9widL4zX/Rt3qDuKeIyWe8VX6tAPM3 KlnaVHM1PCvAcgzrmgEhg/pZe0298ee6WOjBXjrUMUWQTv+skcZm2eF8jr1Emffozigj 3qEV/JsjrVxuPHxEliSd7eFK1gPMwA4Zqd8Oj5O/onnF825heZeTs5QVU0yP45PNgjSZ vSQSwCQrcpGCP0eGdclW/0Q/tFeqUSxTDV86a0N4mDCBZ0rYO5+VqnZRXEtliI5nN+4K 57NaOc2ZkM8eo7lBGNC6cbHCV1kREvR2xazNpeYun+K8Dfcc43GPlm9+NxslytZLqTCb NOcg== X-Forwarded-Encrypted: i=1; AJvYcCWdmGLKorFd7wVfl1kLbHypjQpTDNJBOVr8g9JP/8jnTvLKqAD/eC+Z7JeLvzCJqpKFgjApqwAfD/On470=@vger.kernel.org X-Gm-Message-State: AOJu0Yx6Vu7nNnYERLzEBo9P3IVnWfgvpYMHu6XrnPwOlddKOb8r8YeJ G86NuUldanec/wSCrNj57CX/eyUiB3OAy2T6L2VpupTgdUFWTnJ0Ug2BvyJmB20/WWtNjR5iJM7 qup+vGGtH9Zqf9gvpXHdZfiFPrFq/1h4= X-Gm-Gg: AZuq6aLYqZVfrTeCTaFS9gJmf8i2dRffekLRA7xPAFa11HT2KMo9cHBwJ2RwjU2aUY3 wfN1YEFdJWMR+3BEowLsD8cQqPpimIlMkMRU6A/DtcE+LG/LVPLGqA8S88aS03SV7/DbbqU+ajH H/qHju8eDapm9+6WhidmGKB4qFmPWVeTE9f6ttkJ+oHvQKQHWcQ90T9JgtAaK4x75/cTmCRGhXw U2O/DsFbxJYpiQ7am7rMEm725yqI4xyXuEgyTDyOzLOWm5KG2ZCzHJrYqRzlYZP+s63eFn2svdJ 1+jvBrH6x2avzFUOzO8oo9yRNuxOzV6o+erU1zPMA1fk/ej2m3uVFLb0eNCYuHc3qu+qcL/Z2w= = X-Received: by 2002:a17:906:4f8f:b0:b8f:70c0:c619 with SMTP id a640c23a62f3a-b9081bcf826mr57406966b.52.1771640152852; Fri, 20 Feb 2026 18:15:52 -0800 (PST) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20260214033859.43857-1-jiayuan.chen@linux.dev> <20260218174025.2fe593d3@kernel.org> <20260219121213.5b5ab0e7@kernel.org> In-Reply-To: From: I Viswanath Date: Sat, 21 Feb 2026 02:15:38 +0530 X-Gm-Features: AaiRm52UQSJUE8vaQr6WV5HgUrfDWWlGtsDuWtCL3urjMblSAGcISCnDA8aO7iY Message-ID: Subject: Re: [PATCH net v1] net: defer __dev_set_promiscuity() to avoid sleeping in atomic context To: Stanislav Fomichev Cc: Jakub Kicinski , Jiayuan Chen , netdev@vger.kernel.org, Jiayuan Chen , syzbot+2b3391f44313b3983e91@syzkaller.appspotmail.com, "David S. Miller" , Eric Dumazet , Paolo Abeni , Simon Horman , Sabrina Dubroca , Stanislav Fomichev , Kuniyuki Iwashima , Samiullah Khawaja , Ahmed Zaki , Alexander Lobakin , Willem de Bruijn , linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" On Sat, 21 Feb 2026 at 06:45, Stanislav Fomichev wrote: > > Do you mean rtnl_lock when you say instance lock? > > Search for the instance locks in Documentation/networking/netdevices.rst. We > essentially need to add netdev_ops_assert_locked to __dev_set_rx_mode > and make it work. So, the handler should look something like this? static void netif_write_rx_mode(struct work_struct *param) { rtnl_lock() netdev_lock() /* Processing */ netdev_unlock(); rtnl_unlock(); } v9 should be out by next week and fixes all the issues I could think of so please wait for that