From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DFA0D427A06 for ; Fri, 10 Jul 2026 13:08:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=pass smtp.client-ip=205.220.180.131 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783688931; cv=pass; b=hEoljedCQ+18fKZ7KArbzdDnVk0k5KRW3ScvQQfmPqbyh7FZZrej8DymGf1qozO7T9mjpmq8DdCp6x+o0l6RAb/v8dGCLiFj/icOCgvm/IY9GEuduPagZH0pta+ONdRI8S19cOS1OhPA3G0PLoP9ralcsWV7pFZt5FAcS7v4Obc= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783688931; c=relaxed/simple; bh=ps29wYiABii6l1raYJPu8jGO+QY9Y08lyWKo6XlwVyw=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=cHOPAukRjk600ewArPT+TkMwGC7nnlODqsgZn98Ti8QzebRlXsdt0CziXdhEx4q6iqR7BlNPg7vfgjmPdVQysESJyd8i76tX8FqEb5XGaDpWHdSat+9084V+l/udVc08+zF4So2UqHfTuGQQrsJnboRzshiL8qEwDUdAFgaCa/k= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=PQbhMoe3; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=E/jXkmeA; arc=pass smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="PQbhMoe3"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="E/jXkmeA" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66AD6YiY871644 for ; Fri, 10 Jul 2026 13:08:48 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= N5Cka933m4keuHC9q+ty9VLjOYV17gugYbjBnwJv6Bo=; b=PQbhMoe3PoBcb3Hs /DihV9aYD7N2odD9vazHqRjsDv89h5rZHGphaH+tpWhsa7+af5rBKTPuJdW8LPZn Mk39Wieqo6Mw60r42dLUd2Gxgi7p8bxjZpLshjrj7AzbL34A0DXvPUZmVUH4NX0g MgtJWs+BKx0AJ2Ezx5aSRboaeoiSWTe52rVeK8zpfzJ0RAwKpEqAfSYiOKp5qRRf EsdJxs0bExnyDS3qhxtop/v2dbSfVm0i9jaV/APL5yQgCnzY8s/Y1+SDeOsMMPGn F/+wgSzwHMID5UrcvHdiCAnKRs1pvv9gBeLt9XKdfGXLhg0wmyfSh8mZwn6Udt4N ZKZX0A== Received: from mail-yx1-f71.google.com (mail-yx1-f71.google.com [74.125.224.71]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4faxyg8hnb-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 10 Jul 2026 13:08:47 +0000 (GMT) Received: by mail-yx1-f71.google.com with SMTP id 956f58d0204a3-664c8e55e71so1336256d50.0 for ; Fri, 10 Jul 2026 06:08:47 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1783688927; cv=none; d=google.com; s=arc-20260327; b=c8ojwrIs6UUi5PTUCkZXhjvQDpxsrJcj9tTZ3NdJqcXtCmjj42Hv9WAWILgb5GTPv9 0/ddjnh1q1S8UyorBCEGD9Ow4YSu4oX07f3uDUWuBRTLTWWchxvDWTkwltkVH7ub2MUa cdjhtR0OFiDXi1WoDGbYkP9i2dHPOnFKgkFI+9lXfsqIqMiaCKq9epf1npDccUX3tb1A SbVm6w0EZaRNp1SiLAvu4xb02NhbrzlL+TBUS4V++bHXpC9TFyvZYoqhFhbEjsKxkMr1 hZz/yw7t3P+FZD9YBmMCwS0gOE2Cozp3M5Hujp5S84L5J1pdgT3Mykf9GXNrOKIVqW5O Oujw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=N5Cka933m4keuHC9q+ty9VLjOYV17gugYbjBnwJv6Bo=; fh=T09SQ2Bmkx8N0rGq9X4EsteI3hNvHbc5ddANRyv/+W8=; b=VS1+aRX8/Zq205PP7EadYU0uzIK+eln8OVXpS38RG11oYly1F3xVHZVzHqsXhrP9qA 15TrJT/FOI24ejZsnSu97+JwtoY8V8q9S+4tE7TLhAgpYaT4GejZK1F+QU1HR+GBtXxK opj0H5QzZtSMdERqsSc4Ec4Jjd6fuP42beKvvCpkQZOyw1WxffyEsH6d3WzTIhWKUQtl 3iRz+WYMi07HWql3Frca23wNkXAEkd06M9tO937o/6CD6/0HfPmTBkyWjiQcoWlLtvd4 lDeujrFWkGXp0xYxEzUzJezyUZ+2pAkxm7jkz8d4gu8uG2V6nAHTsHwQ/Tx/kX6rkWA+ jYeA==; darn=vger.kernel.org ARC-Authentication-Results: i=1; mx.google.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1783688927; x=1784293727; darn=vger.kernel.org; h=content-transfer-encoding:content-type:cc:to:subject:message-id :date:from:in-reply-to:references:mime-version:from:to:cc:subject :date:message-id:reply-to:content-type; bh=N5Cka933m4keuHC9q+ty9VLjOYV17gugYbjBnwJv6Bo=; b=E/jXkmeAELPdpcsB5FAYtysw0V0m75uaNGlZczuE8t6cMDWaLn+c3GD6ANWg+CwEtW oBaBOuvxNivvTWWmvf1tECkRUK+La/a0NLK5nfPVbjQXDdcpN7hBe2jL7fb7q17Ux9JL 4bu3ys+/mel3WOzcQxUtzSRJ3JMD4z6d5fPJ61mkY4d2RSZweS0mfRVMTg8Ig8+TMZYT pvANgz+GtJ0d/RM9TGRtUh7vgTSJesuRsd10yesKY77gSXqQPL/vVMvwWYyXzw1/VBwL V8EIP6aHxEpRQhAfVje+1FDH4ToWwmtmOm0qFvQ0AyazUGsdC3EKUoqSeQs27tcyJYut h1UQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783688927; x=1784293727; h=content-transfer-encoding:content-type:cc:to:subject:message-id :date:from:in-reply-to:references:mime-version:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=N5Cka933m4keuHC9q+ty9VLjOYV17gugYbjBnwJv6Bo=; b=pc/1YCejKq+eclB1jY699JF9KOMa5X1CEUmurvubDelIjoPhE3mYw76eVIlp/Gtomy uJD11aQiU7Ob467+aVtlPBVAhWbn42uT58sj+lXqeurwuaFrcuaJcwM3Kk55nJhRo0u2 v1k1fQ7sA0ygOQcCCi/1z1dCUlou2iE7ph1fG8gv6qtx8CCgoOXU3D8mHw8FnyGvK9Ti PFA+I627EsXwXIm+qiYC/o+vueAqA01jRzn/id22OmQJwH/551wulUiohkAnUEJ8lkXl tuPAjGf72J5HBTThKIIn7+TwSdUdMKO9d2HNuBUvyFq/vytEcSa6b4BHTmDqCRL1dpE3 rBqA== X-Forwarded-Encrypted: i=1; AHgh+Rpu+sEhjoIWw81Njzud8JQb9LOQr8ZnA5/1oQaY8agZ1kJ43gH1hMqnKqkujNgUJC6fGnRkpnObeDUxkS4=@vger.kernel.org X-Gm-Message-State: AOJu0Yxnnr41YSRMP9y+FTDUM+QY5kW2Ahzyo2zNuWllfyXToysHRfhm +mziB4AoHcdVPkzFB1iSLzxgdprGiiHv2Rm5N/r9qOnRRvKP9+TMdIZ5CO9TKICxH3fwhOQY1+r zczhW27vrXIHtvC1D6MBbbCM0Ib/XN7dhJsGr1mgBLowpiV1ClWknfJ0QVgbvkHtbd9ubGAQwmW vme9+zGe7P4pz7TecFiKOwTpTwkCJ/zwjB33tc/nFPzg== X-Gm-Gg: AfdE7clSgVa+au12BEAthCdgr8jXkwuTx40Kxf3IxblZbXDlTVYZCgs+GiOy5vslxpw GpU4iaPykpu/SQR4pMLmDWJ8N496AmNJtmtx5K+RR9iycJ2EVvMOBeCF5V3crue3OmHpw39ba2n cQew5CWq8Z4Hs6Lt84Xu5ed2HUcgIcKt1N1wFkjoJwPrF7DzoBs4hcuLGnG2rpSbXAscWw X-Received: by 2002:a53:bd08:0:b0:667:8b91:242d with SMTP id 956f58d0204a3-6679f245672mr5946028d50.92.1783688927293; Fri, 10 Jul 2026 06:08:47 -0700 (PDT) X-Received: by 2002:a53:bd08:0:b0:667:8b91:242d with SMTP id 956f58d0204a3-6679f245672mr5945969d50.92.1783688926691; Fri, 10 Jul 2026 06:08:46 -0700 (PDT) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20260703193855.110619-1-mukesh.ojha@oss.qualcomm.com> <20260703193855.110619-24-mukesh.ojha@oss.qualcomm.com> In-Reply-To: <20260703193855.110619-24-mukesh.ojha@oss.qualcomm.com> From: Ulf Hansson Date: Fri, 10 Jul 2026 15:08:34 +0200 X-Gm-Features: AVVi8CefhojPUiWasaXCCjZmJBb6K9Qzlv92c3u5BPoEMYadIduP2fyzpl9La3Q Message-ID: Subject: Re: [PATCH 23/42] mmc: sdhci-of-bst: Use devm_of_reserved_mem_device_init_by_idx() To: Mukesh Ojha Cc: Bjorn Andersson , Konrad Dybcio , Liviu Dudau , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Joel Stanley , Andrew Jeffery , Paul Cercueil , Anitha Chrisanthus , Paul Kocialkowski , Linus Walleij , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Alexey Brodkin , Laurent Pinchart , Tomi Valkeinen , Michal Simek , Daniel Scally , Jacopo Mondi , Mauro Carvalho Chehab , Eddie James , Tiffany Lin , Andrew-CT Chen , Yunfei Dong , Minghsiu Tsai , Houlong Wei , Matthias Brugger , AngeloGioacchino Del Regno , Joseph Liu , Marvin Lin , Dmitry Osipenko , Krzysztof Kozlowski , Thierry Reding , Jonathan Hunter , Srinivas Kandagatla , Arnd Bergmann , Greg Kroah-Hartman , Ge Gordon , Adrian Hunter , Ulf Hansson , Rob Herring , Saravana Kannan , Mathieu Poirier , Jaroslav Kysela , Takashi Iwai , Shengjiu Wang , Xiubo Li , Liam Girdwood , Mark Brown , Frank Li , Sascha Hauer , Peter Ujfalusi , Bard Liao , Daniel Baluta , Orson Zhai , Baolin Wang , Peter Chen , Fugang Duan , Ekansh Gupta , BST Linux Kernel Upstream Group , Fabio Estevam , Nicolin Chen , Pengutronix Kernel Team , Kai Vehmanen , Pierre-Louis Bossart , Vijendar Mukunda , Chunyan Zhang , CIX Linux Kernel Upstream Group , linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-aspeed@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org, linux-mips@vger.kernel.org, linux-sunxi@lists.linux.dev, linux-media@vger.kernel.org, openbmc@lists.ozlabs.org, linux-mediatek@lists.infradead.org, kernel@collabora.com, linux-tegra@vger.kernel.org, linux-mmc@vger.kernel.org, devicetree@vger.kernel.org, linux-remoteproc@vger.kernel.org, linux-staging@lists.linux.dev, linux-sound@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, imx@lists.linux.dev, sound-open-firmware@alsa-project.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Proofpoint-ORIG-GUID: wahGJgg5cHQ1Ltf2xXXQb1p2ZwO4aHQ7 X-Authority-Analysis: v=2.4 cv=PLg/P/qC c=1 sm=1 tr=0 ts=6a50eedf cx=c_pps a=ngMg22mHWrP7m7pwYf9JkA==:117 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=ZpdpYltYx_vBUK5n70dp:22 a=EUspDBNiAAAA:8 a=VwQbUJbxAAAA:8 a=z_eSG8vRrt57AjWXvbkA:9 a=QEXdDO2ut3YA:10 a=yHXA93iunegOHmWoMUFd:22 X-Proofpoint-Spam-Info: AW1haW4tMjYwNzEwMDEzMCBTYWx0ZWRfXz95mxr2z0bSq 8hGr5qJ29q1oW3Bex84+ZP6n32JpDNIrFphi/090eei20iagY4H8AF7Zj29bVQgfREovn1uldnQ 6KfmUJqIo/rZvEYygLdwfMowx/6d6Zs= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzEwMDEzMCBTYWx0ZWRfX3z8FvB6LlL+Y m2Ctelhgc2okx643hFlj//mHDE12ZzRvpYOlbmBn4RuwbDk+mIYXR8Eruf6tvF7jqMuGOMgjOJ8 keodskbqwc/qIk/K2uWc76eNwOf7sr5pX0xPhMQFsD3S9dCSq2bl2IZ2sGJibl4PzL9k/b5DIP0 +anO8l40jenrVdVZaVit7x3xHMWCH6sJL/GsGPoT9CdUIm1Z8ptOVVpPIZ9kdoxGvmFMsPygIjK b3WFrkKNAvuc0T9GgaigbXo3CG76iFCKbJo9pEwdNWNFmyf0il9VUwLJBCinSMIMRRY2hw8YBOa SdScVtGANs7SQ9mLKeeD12ium8/rL56yA8xmdO4hZYHd02SaagoEVCgIZ+Thc9dmho5pECQkmAC Gb1PJdAMV/GPs0lZkvIaBmId792iXTMNa+QheDmA0fXfVH7eL96rYiV96UIkeBYkL5XreU6t2wh FHoA1viu9tVP3X3rxKQ== X-Proofpoint-GUID: wahGJgg5cHQ1Ltf2xXXQb1p2ZwO4aHQ7 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-10_03,2026-07-10_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 phishscore=0 suspectscore=0 clxscore=1015 priorityscore=1501 impostorscore=0 malwarescore=0 adultscore=0 bulkscore=0 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607100130 On Fri, Jul 3, 2026 at 9:48=E2=80=AFPM Mukesh Ojha wrote: > > Use the devres-managed devm_of_reserved_mem_device_init_by_idx() instead > of the manual of_reserved_mem_device_init_by_idx()/ > of_reserved_mem_device_release() pair, letting the device resource > manager handle cleanup automatically. > > Signed-off-by: Mukesh Ojha Acked-by: Ulf Hansson Kind regards Uffe > --- > drivers/mmc/host/sdhci-of-bst.c | 7 ++----- > 1 file changed, 2 insertions(+), 5 deletions(-) > > diff --git a/drivers/mmc/host/sdhci-of-bst.c b/drivers/mmc/host/sdhci-of-= bst.c > index f8d3df715e1a..304554ced690 100644 > --- a/drivers/mmc/host/sdhci-of-bst.c > +++ b/drivers/mmc/host/sdhci-of-bst.c > @@ -405,7 +405,6 @@ static void sdhci_bst_free_bounce_buffer(struct sdhci= _host *host) > host->bounce_buffer, host->bounce_addr)= ; > host->bounce_buffer =3D NULL; > } > - of_reserved_mem_device_release(mmc_dev(host->mmc)); > } > > static int sdhci_bst_alloc_bounce_buffer(struct sdhci_host *host) > @@ -417,7 +416,7 @@ static int sdhci_bst_alloc_bounce_buffer(struct sdhci= _host *host) > /* Fixed SRAM bounce size to 32KB: verified config under 32-bit D= MA addressing limit */ > bounce_size =3D SZ_32K; > > - ret =3D of_reserved_mem_device_init_by_idx(mmc_dev(mmc), mmc_dev(= mmc)->of_node, 0); > + ret =3D devm_of_reserved_mem_device_init_by_idx(mmc_dev(mmc), mmc= _dev(mmc)->of_node, 0); > if (ret) { > dev_err(mmc_dev(mmc), "Failed to initialize reserved memo= ry\n"); > return ret; > @@ -425,10 +424,8 @@ static int sdhci_bst_alloc_bounce_buffer(struct sdhc= i_host *host) > > host->bounce_buffer =3D dma_alloc_coherent(mmc_dev(mmc), bounce_s= ize, > &host->bounce_addr, GFP_= KERNEL); > - if (!host->bounce_buffer) { > - of_reserved_mem_device_release(mmc_dev(mmc)); > + if (!host->bounce_buffer) > return -ENOMEM; > - } > > host->bounce_buffer_size =3D bounce_size; > > -- > 2.53.0 >