From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751825AbaETI4H (ORCPT ); Tue, 20 May 2014 04:56:07 -0400 Received: from mail-ob0-f181.google.com ([209.85.214.181]:44355 "EHLO mail-ob0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751158AbaETI4E (ORCPT ); Tue, 20 May 2014 04:56:04 -0400 MIME-Version: 1.0 In-Reply-To: <063D6719AE5E284EB5DD2968C1650D6D17249DE6@AcuExch.aculab.com> References: <1400526693-29776-4-git-send-email-ricardo.ribalda@gmail.com> <063D6719AE5E284EB5DD2968C1650D6D17249DE6@AcuExch.aculab.com> From: Ricardo Ribalda Delgado Date: Tue, 20 May 2014 10:55:43 +0200 Message-ID: Subject: Re: [PATCH 3/5] usb: gadget: net2280: Pass checkpacth.pl test To: David Laight Cc: Alan Stern , Felipe Balbi , "gregkh@linuxfoundation.org" , Kernel development list , USB list , "joe@perches.com" , "auttamchandani@logicube.com" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Not for grep... But if this is an issue I have no problem going back to the original. We can spend a whole year just talking about codestyle. On Tue, May 20, 2014 at 10:52 AM, David Laight wrote: > From: Alan Stern > ... >> > -static struct usb_request * >> > -net2280_alloc_request (struct usb_ep *_ep, gfp_t gfp_flags) >> > +static struct usb_request *net2280_alloc_request(struct usb_ep *_ep, >> > + gfp_t gfp_flags) >> >> What's with the extreme indentation on the continuation line? The >> style used here is for continuation lines to be indented by two stops >> relative to the first line. > > Also why move the line break? > The Linux kernel has both styles, and the original one (with the > function name starting in column 1) makes it much easier to search > to the definition. > > David > > > -- Ricardo Ribalda