mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Marcel Holtmann <marcel@holtmann.org>
To: Pavel Machek <pavel@ucw.cz>
Cc: "Pali Rohár" <pali.rohar@gmail.com>,
	"Sebastian Reichel" <sre@debian.org>,
	"Sebastian Reichel" <sre@ring0.de>,
	"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
	linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
	linux-omap <linux-omap@vger.kernel.org>,
	"Tony Lindgren" <tony@atomide.com>,
	khilman@kernel.org, "Aaro Koskinen" <aaro.koskinen@iki.fi>,
	ivo.g.dimitrov.75@gmail.com, linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH] bluetooth: Add hci_h4p driver
Date: Mon, 19 Jan 2015 13:36:08 -0800	[thread overview]
Message-ID: <CB643345-4B50-4ED0-8C3E-296CD225754D@holtmann.org> (raw)
In-Reply-To: <20141223130219.GA5731@amd>

Hi Pavel,

> Add HCI driver for H4 with Nokia extensions. This device is used on
> Nokia N900 cell phone.
> 
> Older version of this driver lived in staging, before being reverted
> in a4102f90e87cfaa3fdbed6fdf469b23f0eeb4bfd .
> 
> Signed-off-by: Pavel Machek <pavel@ucw.cz>
> Thanks-to: Sebastian Reichel <sre@debian.org>
> Thanks-to: Joe Perches <joe@perches.com>
> 
> ---
> 
> Please apply,
> 								Pavel
> 
> 
> Kconfig      |   10 
> Makefile     |    4 
> nokia_core.c | 1149 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> nokia_fw.c   |   99 +++++
> nokia_h4p.h  |  214 ++++++++++
> nokia_uart.c |  171 ++++++++
> 7 files changed, 1667 insertions(+)

so when I run this through checkpatch --strict, then I get tons of warning that we have DOS style ^M line breaks. There are also trailing whitespace that need fixing. I can use cleanpatch to do this, but so can you.

Even after doing that there are still obvious plain coding style violation in the patch. For example:

ERROR: space prohibited before that ',' (ctx:WxW)
#610: FILE: drivers/bluetooth/nokia_core.c:517:
+			__h4p_set_auto_ctsrts(info, 0 , UART_EFR_RTS);
 			                              ^

CHECK: Alignment should match open parenthesis
#662: FILE: drivers/bluetooth/nokia_core.c:569:
+		h4p_outb(info, UART_OMAP_SCR,
+			     h4p_inb(info, UART_OMAP_SCR) |

CHECK: Blank lines aren't necessary before a close brace '}'
#692: FILE: drivers/bluetooth/nokia_core.c:599:
+
+}

These are only few. They are more and all these need fixing before I even consider it.

Also this worries me:

WARNING: DT compatible string "brcm,uart,bcm2048" appears un-documented -- check ./Documentation/devicetree/bindings/
#1222: FILE: drivers/bluetooth/nokia_core.c:1129:
+	{ .compatible = "brcm,uart,bcm2048" },

Regards

Marcel


  parent reply	other threads:[~2015-01-19 21:36 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-23 13:02 Pavel Machek
2015-01-18 12:02 ` Pavel Machek
2015-01-19 21:36 ` Marcel Holtmann [this message]
2015-01-20 17:36   ` Pavel Machek
2015-01-20 18:34     ` Marcel Holtmann
2015-01-21 11:01       ` Pavel Machek
2015-01-21 11:46         ` Pali Rohár
2015-01-20  8:28 ` Johan Hedberg
2015-01-20 21:49   ` Pavel Machek
  -- strict thread matches above, loose matches on Subject: below --
2014-12-13 22:37 Pavel Machek
2014-12-20 20:23 ` [PATCH] " Pavel Machek
2014-12-20 20:43   ` Paul Bolle
2014-12-20 23:35   ` Marcel Holtmann
2014-12-23 12:00     ` Pavel Machek
2014-12-23 12:41     ` Pavel Machek
2013-09-20 19:01 [PATCH] Bluetooth: " Pali Rohár
2013-10-17 20:25 ` Pali Rohár
2013-10-17 22:11   ` Marcel Holtmann
2013-10-18 10:30     ` Pali Rohár
2013-10-24 16:41       ` Pali Rohár
2013-10-24 18:41       ` Joe Perches
2013-10-26 19:28         ` Pali Rohár

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CB643345-4B50-4ED0-8C3E-296CD225754D@holtmann.org \
    --to=marcel@holtmann.org \
    --cc=aaro.koskinen@iki.fi \
    --cc=ivo.g.dimitrov.75@gmail.com \
    --cc=khilman@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=pali.rohar@gmail.com \
    --cc=pavel@ucw.cz \
    --cc=sre@debian.org \
    --cc=sre@ring0.de \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®