From: Jean-Francois Dagenais <jeff.dagenais@gmail.com>
To: Dan Carpenter <error27@gmail.com>
Cc: bojan prtvar <prtvar.b@gmail.com>,
Evgeniy Polyakov <johnpol@2ka.mipt.ru>,
Andrew Morton <akpm@linux-foundation.org>,
open list <linux-kernel@vger.kernel.org>,
kernel-janitors@vger.kernel.org
Subject: Re: [patch v2] w1: fix for loop in w1_f29_remove_slave()
Date: Wed, 17 Aug 2011 14:45:06 -0400 [thread overview]
Message-ID: <CC07C792-D6D1-4D76-8384-14470E5B0075@gmail.com> (raw)
In-Reply-To: <20110730081958.GA5575@shale.localdomain>
> The for loop was looking for i <= 0 instead of i >= 0 so this
> function never did anything. Also we started with i =
> NB_SYSFS_BIN_FILES instead of "NB_SYSFS_BIN_FILES - 1" which is an
> off by one bug.
>
> Reported-by: Bojan Prtvar <prtvar.b@gmail.com>
> Signed-off-by: Dan Carpenter <error27@gmail.com>
Acked-by: Jean-François Dagenais <dagenaisj@sonatest.com>
> ---
> v2: fix >= vs <=
>
> diff --git a/drivers/w1/slaves/w1_ds2408.c b/drivers/w1/slaves/w1_ds2408.c
> index c377818..7c8cdb8 100644
> --- a/drivers/w1/slaves/w1_ds2408.c
> +++ b/drivers/w1/slaves/w1_ds2408.c
> @@ -373,7 +373,7 @@ static int w1_f29_add_slave(struct w1_slave *sl)
> static void w1_f29_remove_slave(struct w1_slave *sl)
> {
> int i;
> - for (i = NB_SYSFS_BIN_FILES; i <= 0; --i)
> + for (i = NB_SYSFS_BIN_FILES - 1; i >= 0; --i)
> sysfs_remove_bin_file(&sl->dev.kobj,
> &(w1_f29_sysfs_bin_files[i]));
> }
next prev parent reply other threads:[~2011-08-17 18:43 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-27 9:55 [patch] w1: off by one " Dan Carpenter
2011-07-29 20:28 ` Jean-François Dagenais
[not found] ` <CAOmT4fS1OqQb5KOOeFnGHt1tnYGBRutVrAZ4cXB6n=hou5fn8w@mail.gmail.com>
2011-07-29 22:55 ` Dan Carpenter
2011-07-30 8:19 ` [patch v2] w1: fix for loop " Dan Carpenter
2011-08-17 18:45 ` Jean-Francois Dagenais [this message]
2011-07-30 8:42 ` [patch] w1: off by one " walter harms
2011-07-30 8:51 ` Dan Carpenter
2011-08-17 18:42 ` Jean-Francois Dagenais
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CC07C792-D6D1-4D76-8384-14470E5B0075@gmail.com \
--to=jeff.dagenais@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=error27@gmail.com \
--cc=johnpol@2ka.mipt.ru \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=prtvar.b@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®