From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from DM5PR21CU001.outbound.protection.outlook.com (mail-centralusazon11021115.outbound.protection.outlook.com [52.101.62.115]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0ACAE309EE9 for ; Thu, 18 Dec 2025 05:25:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.62.115 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766035525; cv=fail; b=es/jb0PdKioAmtn+1g7wkigV5a5vE0ac3JefJXGPmX2uDg6m1bScXy5XaheKf/AuugPpeGcQAIv9o1mesAw+oJiMFnC0p70qcA3LO0FvAZkp8SMf3j2T00MpelKNqtR27fm9/slBto7uiSRN/scPD1nXO0wFMslWIjDAOEFfdBo= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766035525; c=relaxed/simple; bh=QykiUfBUtf8qYKY+LIVXhjmyd4uBrNEfe2yHGmDNiOo=; h=From:To:CC:Subject:Date:Message-ID:Content-Type:MIME-Version; b=K8IvKL0kBdxykvnocbobJIgNONYZxdSnOiuqnm/GDp1uprrUQCEM8+2AZ+pszKFAtmqTMlO9CoABHVZLD/7twp/Dkrzj0Up+IpVJWlT5fbaMwFZ4UM954K0DviaZ0gTPCjLHhjpKSou/2rgowoLZnyJlVAgD8LmB2KIvHWyBdGs= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amperecomputing.com; spf=pass smtp.mailfrom=amperecomputing.com; dkim=pass (2048-bit key) header.d=amperecomputing.com header.i=@amperecomputing.com header.b=PYS9qcQu; arc=fail smtp.client-ip=52.101.62.115 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amperecomputing.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=amperecomputing.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=amperecomputing.com header.i=@amperecomputing.com header.b="PYS9qcQu" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=E2sEJKC1QC9wTj4lqKLORO6/IpEURjbZKB7f76zAFJ+LjeZiUWyza7/XFdS2VQ4o1PR6A2Z8TCpSt5HwwYD0dt5ZnU4y999Yn3SNxC+D0pSs21UmlE6jBQTS3SdCDKQJyAl4dhhvAeCOTvWaEgxAxuabM4q7tPeBP0RehEWlAFhiAuxWzacsN8Ie3EZ9ZIWeu7yBFUdtaJaP4WueyU0GrdRLLdZo6LNuIqzOXFvBfnpEBS7uwyMi7KR50aVpRmsph2AHHhcTnJ4vXKP9HiR0NbVKtG6Eiq0CZKStqcLq1RIuCZpB/1BHegDoT04PIhxwr9qBFq7lcCISotA/O3L1UQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=QykiUfBUtf8qYKY+LIVXhjmyd4uBrNEfe2yHGmDNiOo=; b=kzRuqgMjXC5Ik8w3bRn1ECr7Feo10I1U7fU7FMDGtkJXmQWqmvQRZOQVzIZSoR2JGe8nm1oKZ91XGaBFzb3yAmV7aVK7KComAaic+TiRjVmCezx68PHAOTXIqRNL5+uJ+lkypQw6kwbpsmg3P82PM81lu4q2arlLbHk6HgrM4gjh4JxcRfRquWOc5oQ/DUr01imYPbkgBr41nFpBwxGTkxvzM/OrNpD4kp0jgbKpSi1Du5VjXhJfFZqls33TFa46kOf8WeWyiPGKOyv23gGPArcrVwwiOVWde2KbmxtKzSFUujm8fhyZhXY68kw6/26uhZZjoIiYBHvptv7wzqPlMQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amperecomputing.com; dmarc=pass action=none header.from=amperecomputing.com; dkim=pass header.d=amperecomputing.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amperecomputing.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=QykiUfBUtf8qYKY+LIVXhjmyd4uBrNEfe2yHGmDNiOo=; b=PYS9qcQu1y7xVUJRK5our1n0l2OBhTWNBo3PL5m9Inwl1/EUFw/etp5xeO/FZH6H1V77QQ3E0IRo1qxlDYkMUfD6x4cGheT9SNmHMW+i6C51rkQElvkRBM6UdjQCApFpSDRTZQYVXsQeYQckTPKPK2KCalp9qAnceUwefC6cneGPCtUdHu7Fa3FvK1jLHqvZq37DebYCx7jXm5CFs5CVrdIsrzvO79STJGYKtxjgsCLCzK9Rhs0uVy0Vna67DWf8UBKoHwVvqTcuxN/WOu3JH2RZSmVH8tzw6jHaJpiRFEYekE3ulZwZOpzBwyD/y9wjlBmEJWoiAAGkMcWANVi4uQ== Received: from BL1PR01MB7649.prod.exchangelabs.com (2603:10b6:208:394::22) by IA0PR01MB8397.prod.exchangelabs.com (2603:10b6:208:486::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9434.6; Wed, 17 Dec 2025 18:50:52 +0000 Received: from BL1PR01MB7649.prod.exchangelabs.com ([fe80::951b:7575:6352:6da7]) by BL1PR01MB7649.prod.exchangelabs.com ([fe80::951b:7575:6352:6da7%5]) with mapi id 15.20.9434.001; Wed, 17 Dec 2025 18:50:52 +0000 From: Shubhang Kaushik Prasanna Kumar To: "zhanxusheng1024@gmail.com" CC: "dietmar.eggemann@arm.com" , "linux-kernel@vger.kernel.org" , "linux-sched@vger.kernel.org" , "peterz@infradead.org" , "vincent.guittot@linaro.org" , "zhanxusheng@xiaomi.com" Subject: Re: [PATCH] sched/fair: factor out common sched_entity stats/task lookup Thread-Topic: [PATCH] sched/fair: factor out common sched_entity stats/task lookup Thread-Index: AQHcb4YRl4zv1/OZ0k2j8Da9Plpmog== Date: Wed, 17 Dec 2025 18:50:52 +0000 Message-ID: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amperecomputing.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BL1PR01MB7649:EE_|IA0PR01MB8397:EE_ x-ms-office365-filtering-correlation-id: c7c03fe5-ff5c-469b-4c04-08de3d9d33f1 x-ms-exchange-atpmessageproperties: SA x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0;ARA:13230040|376014|366016|1800799024|38070700021; x-microsoft-antispam-message-info: =?us-ascii?Q?p6AajwuTY/9DCV0Dy+nmuzWG+K6KGJIYedWd/IqwJXldHsVwcmo7Ah/mI3iV?= =?us-ascii?Q?9cGDZFai5hxrNIO+RSnepa6w0PY07ODv1SQ5Zx1IgTW0kPz7a3fT1A2vIxof?= =?us-ascii?Q?X+AiG2PiHPwXeycon/296ONpDQlEqZ/ZK0Cm9ce3Q4EgRodydwIopq6TOCRu?= =?us-ascii?Q?E9qzrOU5W/RIVSbrLr3xd5SaXfigNnI94PR2iLt29HLxI9P8SP7HQTzWbfJ8?= =?us-ascii?Q?L8mATKilnvAGd5cOnF14jNYA19zcp42fnpuRn3AAReSJAWdyTAeo1AoSYRXD?= =?us-ascii?Q?4B7DXceIpNT3CLfBDkLtWxr2gSlhFvTqBGVp+xBU5Mz8PYxZzaJ/5eqBYEYQ?= =?us-ascii?Q?ScZYjtEM7U/YhyyWGIIDbqXbd3NPCES3s6KXYWMHCULVIlcIQo4YCpK4t3YA?= =?us-ascii?Q?CC5t/lPGX1FnZ8gBX6EiPGYT2pCz5TWyEUOCwXG68ioRXGuQVW0W5yVFbQy3?= =?us-ascii?Q?Lp3GpLG5BfdihKu2uvGT7XJuivuoKsf5uDg2D07GehRxY43oc3r9dl793w3l?= =?us-ascii?Q?Y7gr0xO47r3EvAc9uW+BV6XRoBqPfBzVCNuqFCDlyOEPV5ZhipTAXgWH4Wha?= =?us-ascii?Q?+9h98ZMPYjPVq3bfxoLsQZTmeceOG4Tlisyj+1GOriI11h5b9dKxZ45ou+kd?= =?us-ascii?Q?hQJ21Tq6yz40Uk/t1NExJP3FGoBmCN98fZNIh96y2iZ+2xWN31TiME+MJdAb?= =?us-ascii?Q?Q/xtxeKDrMHG7tMoEe4l3szOY7BIEg4cDA1ZXYZ3zLwBSqoZbH5DSlGj7vOD?= =?us-ascii?Q?B3dZee8NuQGV3oj/KYI/WdA0DcS3SgzTPWaEh3W+CIjOgJWqXmbfsRr7SPzN?= =?us-ascii?Q?G+/+PetYqjKv1r1p4Dbwqn1hKe7DkWS1X1gz+S448MN7DG83tKuiOANMNMK1?= =?us-ascii?Q?pFiDcD0m8LpBzbwYYQCCpEIeibwKnmnPZuShqAS6IrqBRCRfgdBn6uWbYgm9?= =?us-ascii?Q?zfOTulTEUf5Ph/26DKUwLD7eEtiD7LhtK4w5kVl57mXOPrFAV/XFLLEsxIpX?= =?us-ascii?Q?Bw40MINOwKFPub72UZXvFUyjJcjk4bGaJMnN5RV0fAWQHkKw4Z82xqzXIdJh?= =?us-ascii?Q?G8DVjNE5AAA54hAmEWRAYQqtuV40BPjHBVx/2RemwGynb5uGB3o/cbqxXaWA?= =?us-ascii?Q?2xg9+pgqhtPtfXy44ILkh4u0EoJd4uL5MJ40pPJqPus4q4FlepFpZUBtAanr?= =?us-ascii?Q?Dhub2nAG93TFf0nF9VDPp8JMwXLSQOC7YUONFBESbDPzvFhfl3tmiajw15Nj?= =?us-ascii?Q?DwkHDOk1f8w9ZQQ1QZRfBXkYzg4LXuQqoYmTtAM53TUyiwsIITPkuubwnWgw?= =?us-ascii?Q?tlpkD91FokyUiSyYyFRhVTca0plFjzyYUhUczoHEIagJrNgTYMgCFn0WQRkF?= =?us-ascii?Q?WkobB0Np0YMtsEysRxSKoPK4tfRM9VC1XZFN0SUERnUNm3OHfzGSJmP3jxPC?= =?us-ascii?Q?faw1knft/Q3vJaR7lPUg3BTEJMsKc8wN6tUWHmKRbZohOHl+1dr5xGnamyqR?= =?us-ascii?Q?20mbU3N9ZH+3bYPUO82z4UOLxZAT2GlI5jN5?= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BL1PR01MB7649.prod.exchangelabs.com;PTR:;CAT:NONE;SFS:(13230040)(376014)(366016)(1800799024)(38070700021);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?cwD28zX+bornHKUjVp+1aBWsfoF/UV/kuoqldQbdsSa0D6dl46XGmoGSNgLO?= =?us-ascii?Q?bgi4bQsJJS+Ql3z5n80p5nJwmNZNj/CGytK5UrM4014Tn/5tZVOZkYrojg2p?= =?us-ascii?Q?qG4MSM0KONA07mP4Zf2fRuI/aApsAfwpmTcoit6zDNmrwuscaN0z5cg5NkDR?= =?us-ascii?Q?haNpqLG9cxn1mDofx5/gkgwWRjD2EhLCZsD5HV3WDIRVecokKf8MtdnsiHdM?= =?us-ascii?Q?uKGQ26bGr7g7wNi+z2l3Mn6xk80oW4DPSJw0Mfv4DR7uMCuEuMXorbo3o5MW?= =?us-ascii?Q?bSXJGp0E90nZ/EW08ROogoAiqrho5QkWa9BPH2aBwUM6Cyqx3WcJTnEJ3ucQ?= =?us-ascii?Q?ukQVkAcVd9wGkmGhl+CTqjHBLQ5G42CvpmRssa8oBdWnO++tIEmJX4rodxlp?= =?us-ascii?Q?bSq16jhvoNWRRaxWgLxQwvq8wMt+3KIvfXsbY2g/UGhn6AOuW3k38YTvtQU/?= =?us-ascii?Q?YHnxTMwF4bIU2dah9SFZ6/JkRo9/qOlx+voHN59x0AFoQSKKWJByh82fC6fK?= =?us-ascii?Q?xLeghfOBkUK5dW87E4xBTdnTKEfuRR3Msdl1ceGQ7OHYS8JpwQ+8ZEczkjor?= =?us-ascii?Q?yhzHJN2ACgpLkORbmGTM3o2Jk1EKh6puiV1Cr1jHG9RxVGewjhM0Z0iYZ/bq?= =?us-ascii?Q?t3jfSkdoBtwvw17/ivf47gO/uzkN5uKJhpEkY4j+zZOCK7ntjTE1rnt8WxzT?= =?us-ascii?Q?qX379ei9xgActQaClQaFNvYaL615pR0S9ZJT7lVeDIvoJyiB5mhVqSOYoo7w?= =?us-ascii?Q?reO2YhRgHYRJeuT5fkF4ZE31n0tXZiPTfGUegNR+r0jNfHgfqqXQSYFklBmT?= =?us-ascii?Q?ZTA0dJMreFqf6beYOFTA8CYJMzd9i+5Qiu6bCFQYfFH0YcQVEXd567fkEKT5?= =?us-ascii?Q?RGpQ8B1sFaxhC5ObpZQYOw5d0+F8FVy/vs7WGBdJFBE8ewjFpyJUSDy1Vuf8?= =?us-ascii?Q?k11O9jQ3LUtIScRPl5kZKX0jXAysswlGHoBJL/QInk+UjF5Zfru2n+4r2u/z?= =?us-ascii?Q?neQJ+Sn1t2k+ofdet2u4GBdda2PaXOAtMbDljmf+OAE1n0+ywG/hj+EimFxH?= =?us-ascii?Q?TvAs5zl0FE0s66rCYo7VT8/12Gvj8bd5DER+sOuIv74KD7JLwkDbRRwuUB2L?= =?us-ascii?Q?S5ezvD2asxBibvTSPYWRDtZI4slbvCMkQmStzYHHpMeETBDw7HupEBjY9qck?= =?us-ascii?Q?MvD+GjBuNyEGV1wR2HK9etVwpkUWV8aj3Kt40/BLtvX/Zk2T7uwOMkzEIgWG?= =?us-ascii?Q?3+Ne+r/k1w0Hdybl7esCkmg7Pxd4vbKh4hkJpyu1CXb46EeIsSW3WKEHsR0W?= =?us-ascii?Q?jNKWS+m6PVPRf9Vy5MjEG2HMdf7MjWeY5auyJxA5sPDvYfeP+Zmg0emb5iva?= =?us-ascii?Q?X1NAhuow/pinuo1jEGoaR64MzkzRR/cN/hMmgRu6gckYdgDl0VOESXWPWO9q?= =?us-ascii?Q?L/7GPx+UMI/j7JAhqbjW012bQEjznfBEwnAMbFFdqfAX6ZsQphl3RpNyKhOL?= =?us-ascii?Q?Uo++i7571tiBOm+mIpteds1e3dGmLiVKHLYR8eY9qgPtD6pcXPOnyEGeNKDB?= =?us-ascii?Q?uQ8uKC6+h3hysNwscOSp0D00JTrQdQfs6ROR9SxzKEaJR9t1Dw0GIqjYKagR?= =?us-ascii?Q?sA=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-ID: <190E7C3ED0080345A0ECFCA2B176FEB9@prod.exchangelabs.com> Content-Transfer-Encoding: quoted-printable Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-OriginatorOrg: amperecomputing.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BL1PR01MB7649.prod.exchangelabs.com X-MS-Exchange-CrossTenant-Network-Message-Id: c7c03fe5-ff5c-469b-4c04-08de3d9d33f1 X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Dec 2025 18:50:52.1816 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3bc2b170-fd94-476d-b0ce-4229bdc904a7 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: eOEKtvRJfzlpogJlk/aJT66BG14e+zeMSaUUCD9jQUusXwpksXBPKEHBSKw5OM9zftSyeZgUM9QfclQv+JK1f+KdciUwqQOHVV3rDcjRpTw= X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA0PR01MB8397 Hi Zhan, The cleanup looks nice, but these helpers are sitting in some very critical= hot paths. `update_stats_wait_end_fair` and `update_stats_enqueue_sleeper_= fair` are hit on practically every task wakeup and context switch.=20 Even though it's not a functional refactoring, have you verified it with an= y benchmarks? I'm concerned that introducing the helper and passing around = addresses of local variables (&stats, &p) might make it harder for the comp= iler to optimize compared to the original version. I'm actually looking at a similar improvement in the PELT area, so I'd be c= urious to know if you've seen any measurable change in overhead.. To help t= he compiler, it might be better to have the helper return the stats pointer= directly rather than passing &stats. This avoids the "double indirection" = and makes it easier for the compiler to keep everything in registers. Also,= for these hot paths, using `__always_inline` would be safer than just `inl= ine` to avoid possible overhead. Thanks, Shubhang Kaushik=