From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f43.google.com (mail-pj1-f43.google.com [209.85.216.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4FB7D2D877B for ; Mon, 6 Oct 2025 15:49:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759765757; cv=none; b=FR3yNOeHs9v1OraUrtbXPIB6nAvIqFucEBD1DJtZKEpGi4tUFqedYkCzLGc3d5JhkbeQZHb2Fa7akibfcmf8N+Oz2aX5RgerDUP1yz9uUjH9Nmspz7yyCc0HbROtgmrHi/mwF3xTZJLUrCJRxZBUaFlug+AAZ71jfbEGOZfCUuA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759765757; c=relaxed/simple; bh=h7zPFSCY4N4s5k1Av1++h8vuQP5AfNULE5kid3kk/OY=; h=Date:From:To:CC:Subject:In-Reply-To:References:Message-ID: MIME-Version:Content-Type; b=cNg4t86bD5e29/ize/d1lmUFUs+BI+4jhuLt6nWYRcoLKN9NeSB4dDRKaShuhWRySKLgfrNuKi9b3lxYW9Ua4bai5lQ11xzPqF8qkIhkhVuDANBJ6NhI8cfrx1bjox5G4oa83Nd4OZDBI2zVwTn4PzAqa6Sk+Bq0nsNrAMWZBRw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=gbnRMCvy; arc=none smtp.client-ip=209.85.216.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="gbnRMCvy" Received: by mail-pj1-f43.google.com with SMTP id 98e67ed59e1d1-3369dcfef12so5712451a91.2 for ; Mon, 06 Oct 2025 08:49:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1759765755; x=1760370555; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:references :in-reply-to:user-agent:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to; bh=uKx7DTfvvmjIZ6cGtmnwuVyxZs+QDCyCKdDBftxtrEw=; b=gbnRMCvys50MgBLoIagC0WuNVoaCHpvLGwOJfv/nX2U5BQfXelUYfxUIx48vulih44 SmqH1u8bNpGjoeo4Z/mGY4uoTwMRNq+q2TQg0T4sZzXrGgvyY/Y/JffCGXXEf7EOC+zN 8BI42SyjMs7vcRUCliWKLwR/z4J0jwdw9FYd4Ctw56oeHmQhq1Md+mVuGWscOlqrkRUc Y1/SZEyqRWvTIoyVPcRbo0Eg8x/TKSphOiuWXdJ82kDH3xK9KObwYM1SfthcvO5CtUMB BxWJlZbaJ8PaIXEKeJU25EdLj7e5k0A/oqi6tNU/0XHwgr/t0T3vsJnA3OHfFEQHyEBL Uq5Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1759765755; x=1760370555; h=content-transfer-encoding:mime-version:message-id:references :in-reply-to:user-agent:subject:cc:to:from:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=uKx7DTfvvmjIZ6cGtmnwuVyxZs+QDCyCKdDBftxtrEw=; b=vH5CwK5vkRg7BtRxgWksrINKY1P6EzYhjI1cTgiHuISbSnZ/mwUodMfeK/RCBe6cZ/ JDfVLlD43efLpCr1pAIZOUYhf3jqzGl6RHQ2bYFO6VVPEYk9F7ZMj0mbvr3Yd2PI2Rl4 iUM/QUo3ROvxGlnMrsKL0jFtWH6MvIR6ui+62wBYxOwhNv73eFYO7S9tsz8JSsst9Kvi 4iL8skDcvbaLZUM+S1SIna2phoJ4GtdZRY+hgT6ngNsh1Rbjd5rWTR7kxcsuEp7Zue3l N/mMHlv35zAy1GKP26hamIZjMeigiYBCMpQDFFQ4Arw4yIDeSnWHXn5R5qVaWLeD6jYB W5RA== X-Forwarded-Encrypted: i=1; AJvYcCWEFJxfImfld0ewl8beCVsAOyUyd9Tnb8f/KTo3Jfw6oyE66z9oaGChgRfJBIudMMRDZYcPpWuRG5JoZr8=@vger.kernel.org X-Gm-Message-State: AOJu0YxN69N1zlF9u5KEj0xHE1Mwqnj1azUDtGrT/0m/RCKk1TRujA5d Gh1HRTOCGa+rABeVavrUzljbGkR/N0wMqAzuJ3pRvGRLtHahDA0awKqQ58Lv+QX+ X-Gm-Gg: ASbGncuMMuYvh3R/zBlDOO6K5ohMZFRVsKL1S0dixhTpQgQBkzwgau7w7z/aw/SNA55 Y2Js9HXYcML41KO0UzQUz1Jbtnh2QmgPQHGll5HZY8O00ZPD3bBKN7k+5Idbyk+7oJBDAxMAkDR fl8oYdq/KtTVq9solxyqZplMgohxrZuH4rHKZ8qPdIodQon0Z5m2DvlD56611lgUVrJaBLMlWhj bJ5Q+KFI3f7PfCMQpTtJ5YL/fD/fZO+Imhe1ADJna7AmQRA+nWLsoxa1qad/mk5Se7aPGGOfMjN o00K4Mx45n619nT0/cZbQNoLeMFZZP7ECb4iBeYW/AR5nbGJIfdjWfCLoovyEoUb7UXBe5GBfaR hqj5Y3V46Pp+cedlrFqF55ZsTkX83d1wIha9sMn77rCaMHRnuJkMCu6cy1A== X-Google-Smtp-Source: AGHT+IH4Vfm2HXvCCkpVd9mobsIP67SLElIVdmkXufOG8TbovUst5yZCGISDNRa5UtQ9rmp5sk2B3w== X-Received: by 2002:a17:90b:2707:b0:32e:64ca:e84a with SMTP id 98e67ed59e1d1-339c273dbd2mr18130644a91.12.1759765755438; Mon, 06 Oct 2025 08:49:15 -0700 (PDT) Received: from ehlo.thunderbird.net ([2804:18:932:c1e3:aaa3:c804:f5ef:49e7]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-339c4a0d53fsm10911596a91.5.2025.10.06.08.49.13 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 06 Oct 2025 08:49:14 -0700 (PDT) Date: Mon, 06 Oct 2025 12:49:10 -0300 From: =?ISO-8859-1?Q?Eric_Gon=E7alves?= To: Konrad Dybcio , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley CC: devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 4/5] arm64: dts: qcom: r0q: enable hardware clocks User-Agent: Thunderbird for Android In-Reply-To: References: <20250920014637.38175-1-ghatto404@gmail.com> <20250920014637.38175-5-ghatto404@gmail.com> <99D0B281-03A5-447E-A6BF-892C99829D0B@gmail.com> Message-ID: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On October 6, 2025 9:31:42 AM GMT-03:00, Konrad Dybcio wrote: >On 10/5/25 5:50 AM, Eric Gon=C3=A7alves wrote: >>=20 >>=20 >> On September 25, 2025 10:09:48 AM GMT-03:00, Konrad Dybcio wrote: >>> On 9/20/25 3:46 AM, Eric Gon=C3=A7alves wrote: >>>> Enable the real-time clocks found in R0Q board=2E >>>> >>>> Signed-off-by: Eric Gon=C3=A7alves >>>> --- >>>> arch/arm64/boot/dts/qcom/sm8450-samsung-r0q=2Edts | 15 +++++++++++++= ++ >>>> 1 file changed, 15 insertions(+) >>>> >>>> diff --git a/arch/arm64/boot/dts/qcom/sm8450-samsung-r0q=2Edts b/arch= /arm64/boot/dts/qcom/sm8450-samsung-r0q=2Edts >>>> index c1b0b21c0ec5=2E=2Ec088f1acf6ea 100644 >>>> --- a/arch/arm64/boot/dts/qcom/sm8450-samsung-r0q=2Edts >>>> +++ b/arch/arm64/boot/dts/qcom/sm8450-samsung-r0q=2Edts >>>> @@ -225,6 +225,21 @@ vol_up_n: vol-up-n-state { >>>> }; >>>> }; >>>> =20 >>>> +&pmk8350_rtc { >>>> + nvmem-cells =3D <&rtc_offset>; >>>> + nvmem-cell-names =3D "offset"; >>>> + >>>> + status =3D "okay"; >>>> +}; >>>> + >>>> +&pmk8350_sdam_2 { >>>> + status =3D "okay"; >>>> + >>>> + rtc_offset: rtc-offset@bc { >>> >>> Is this an offset you took from somewhere downstream? >>> >>> Generally you *really don't want to* poke at random SDAM cells, >>> as they contain a lot of important settings (incl=2E battery/charging) >> From another sm8450 device, I'm sure it's okay=2E > >That as an argument alone doesn't sound convincing to me, since vendors >also sometimes repurpose unused-by-Qualcomm SDAM cells > >I actually found a data source internally and this cell you're trying >to use is reserved for PBS (see drivers/soc/qcom/qcom-pbs=2Ec), meaning >you already fell into this trap=2E=2E Interesting, in this case then why does rtc still work? And how can I find the real cell? It's not in downstream DT=2E > >Konrad