From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from CY3PR05CU001.outbound.protection.outlook.com (mail-westcentralusazon11013014.outbound.protection.outlook.com [40.93.201.14]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 38F173B71D5; Thu, 6 Aug 2026 16:25:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.93.201.14 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786033509; cv=fail; b=oprnpCcs3QcWTZDsOQIuyk1aiGVHbYn3DP2vdSKXo7uXuas7vUeq9gMdVsojVpqu0S6UPMIiHxBWfBOydCFPYxS+zr4d7puNBzda5MWDoDQrY5k3fz9Rha+/RN7RY7YzkV6lvwCeIveLvmJiFMPZK41HR4IOw8z4KzEJgOlvD0k= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786033509; c=relaxed/simple; bh=+bOSspVNMASIXainMsjj3OGl/86BqCLTvqiY0tbv0fg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: Content-Type:MIME-Version; b=H9Jny+FIacE8SD6lYcObIFH95UMBv1kqRfvz5FfTQu9VzTHartiOOOlfRcU2IW/wdlYnkUOWZf2nHV42BD5DlKI7EyJc9Cqncw5fMKI0Zbm9sptpqztUA3RgfV8mUKTnIt+N91fjgQUjwXzz8rC1DBPpb+a3UD6XXsETvH9JoPg= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=Y7dhmrFW; arc=fail smtp.client-ip=40.93.201.14 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="Y7dhmrFW" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=dO5CfL+2agcn0xUeVLlkaSVlhNOLy/I1QrfVdkoAI7+JFarnBKYpMPy5O+nWU0RBAFhWoDbfgBlA4B1AY5zBeKdB7/ApKtue0YLXObrxA5TX7Pp98aWzRhF6vVCM8fx32BF/fyo+NlAmn3k/Q7FR374zp2aY47wZMJYlYlvA0cYS7xu1KErZ0M72YmwxRSQXKl1Uej2DUkH5Y7h0MRp4xAVkuBKXVc4XWH0umuy6jsZnbBRpFEiwaMoZdTErYV4ZbVgdyEwhJWakn5yl/1QkzmdSVFCdnom45FGaKc4lznIiuscz9Z0i2Q8WBXAAmgnSocGfHPAMUsdbswJk+cbGAg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=wG9L4l8bbapcld5HGLn7sMqF75MvxIOk1oH+BHHVv9E=; b=naRr5VKIut2pfbXhs6PZKGrnb5wUe+GwJpNGjgCFtakLrTWsVqTZ/c5uHRHx0yCM5LHDHa9T9DYrnCDvlBv3Q7KKQlsrVVKv/vHfq49Wt09jXX3SjMrNZqZup7im4Y1ho12DR15lvpSsSrkZYzJ3RFoJwY1sRM7tGphffPCog6JnHBW41c6eofto1ri1ziN4OCZ26WRCajv7jcstys3dKMeJA0OdWpjuzI+a8phP++CbLXvZid9egLG2u8OCC8Tus5/mSukwdZrbbShzdI83aqljZIShmBcUL21n4UMtgNPkC0w4Z9UkDHOyM0EL8hkywWrkIgUSZk3jsjd481Z4Jw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=wG9L4l8bbapcld5HGLn7sMqF75MvxIOk1oH+BHHVv9E=; b=Y7dhmrFWOPUQ7lA2soKSpGNaAbPIGMc2hsLYYxgKZumpmZQvB+R0XwWb+eXXm45eFf3zD8Uk47ODjyEunDrhB6q46X0AFkJ7r3YkJSEuwSCHLnCJ0/vUNf863y5uAhTv6u6Vh5e2bkJA6BwkzmIcHsqMB+s2bgg298Tjex0IOIP4oomJO13TlDJVU5Dfvayjpm7fXdwRVlTzYTlqvwCZ2u4JLttx5zogtVtHJjDDg9b6fn52wxhwGQZHzgUUikPQ99+YEjSoLvx3CxkA0jzKzOiQNnBKCMP6cePeaPmzsyvj5RcnhH8v2LnNgJRCUMkXGkGk+llk90WxKjei+AV9NA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from IA0PR12MB8374.namprd12.prod.outlook.com (2603:10b6:208:40e::7) by SA1PR12MB6799.namprd12.prod.outlook.com (2603:10b6:806:25b::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.292.19; Thu, 6 Aug 2026 16:25:00 +0000 Received: from IA0PR12MB8374.namprd12.prod.outlook.com ([fe80::d85f:4c87:ae84:3f16]) by IA0PR12MB8374.namprd12.prod.outlook.com ([fe80::d85f:4c87:ae84:3f16%5]) with mapi id 15.21.0292.018; Thu, 6 Aug 2026 16:25:00 +0000 From: Zi Yan To: "Nico Pache (Red Hat)" Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, Andrew Morton , David Hildenbrand , Lorenzo Stoakes , Baolin Wang , "Liam R. Howlett" , Ryan Roberts , Dev Jain , Barry Song , Lance Yang , Usama Arif , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Jonathan Corbet , Shuah Khan Subject: Re: [PATCH v3 1/7] mm/khugepaged: refactor per-scan state clearing into collapse_control_init_scan() Date: Thu, 06 Aug 2026 12:24:58 -0400 X-Mailer: MailMate (3.0r7024) Message-ID: In-Reply-To: <20260804-khugepaged_pte_refactor-v3-1-0364cad642a0@linux.dev> References: <20260804-khugepaged_pte_refactor-v3-0-0364cad642a0@linux.dev> <20260804-khugepaged_pte_refactor-v3-1-0364cad642a0@linux.dev> Content-Type: text/plain X-MS-Reactions: disallow X-ClientProxiedBy: BN9PR03CA0047.namprd03.prod.outlook.com (2603:10b6:408:fb::22) To IA0PR12MB8374.namprd12.prod.outlook.com (2603:10b6:208:40e::7) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: IA0PR12MB8374:EE_|SA1PR12MB6799:EE_ X-MS-Office365-Filtering-Correlation-Id: caa403a5-3d86-4320-c30d-08def3d74310 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|1800799024|376014|23010399003|7416014|11063799006|4143699003|22082099003|18002099003|10067099003|56012099006; X-Microsoft-Antispam-Message-Info: RMWymnKOwaBLotSqUzdfP7Xapjj6j3AoHoJnvFT7tLt3rJecM4Gdr4fs2IsT8z07Q/qMgxNe+C5uKXDC/++FCsXQrBuPYt7887uCGh9TENaUTmMYGtCciyG2TrSrVFxQ4HWJ7XuIfNOeXCCTLY3fb4fWHF5MRu/7Kf8woS7iWn3hVSV223MTsVvezXZ1zAiQUTNkBGWb2xGCVyB+rlKNPZ1s2O3z2N370qeK5knxzdMHrUtl65jjdCEAThSkefilWjBY2YwNSBUdHYOEzS/JaX0n9r23Ici1ysSovfN2ybNvqeX8cPOW0N1dtPtvkjIbxK+lEKmZgS8xyWdpyfhZvVuc9wpIdFT9mCSM23lrBA25FJbaAYZdbzX05/ZhLtlxOMwJjHmlqAiC/ppQt9Lwb2rgnARlA/j7x/QOgyIo6q7xnjXyO1i/tJ01P/Rr7p1wFRWzsTTrOC9KDmVVDE2gCf7QJNYszO5vdNDchWAAE0oxmPJjmAmCEo8QUO+sGqJIwjD0ZwZwhSd6+AcH/FR103BlejNLz3igE2zkKJC5wr3h/QM/CiG9uZRW1OXB1bgS9kEFTrp9nSY2AnIbz/taA9iWCMaZE/y9TEFVAqMtuquGGIC6j4jWbQBXtRh2uSKCcHbWR/fmhJMgOdGaNtH8fQkFFV31A2V/Y08bo4i0Qi4= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:IA0PR12MB8374.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(1800799024)(376014)(23010399003)(7416014)(11063799006)(4143699003)(22082099003)(18002099003)(10067099003)(56012099006);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?wVKQ6Ynx91oSXO/vZX4Qcgq/CHWz2v68G+kRrBlf5xKLeeBCr3SDEi6s+UR0?= =?us-ascii?Q?2zXwH28VCJ7iS6T4gAc7eyZ0GHtPWI6AMhfsMIeCvXmAyQFDiCOawF+SN4Hj?= =?us-ascii?Q?1k7762MP5zjz/joE+sorSEXDU69fxpiFP9y0X0xTRs3/UvtEmI8R0hooXDY9?= =?us-ascii?Q?R5HFtzRb3rIAMX0enfgOSEAAlvRIDCzK+Q0DjEEM88cNxvi7fqgwcK5tSi/i?= =?us-ascii?Q?jeNGCAd2OJtQMDTe3Q6m/Hvv0LJQ8Ai8A2oIrHsRkY29abc3jCVKdvCTKeC4?= =?us-ascii?Q?3T2IU9Jh2HCwFO2BxqlwlMKf0IL/OttSJQwiPvX2l+9aR5Yg650tnRNyxTbe?= =?us-ascii?Q?7+D32pG6Z+dERGHTutK3oJ7PpLjZsBiGlEvCfUXh3YdwYCB1k7IgDxDl7dYQ?= =?us-ascii?Q?2PV3KsQlco+0QTZ+HcRXxfYrFeUvZW9Ize9xCnwJEAql3Jr2qHYysaNilkPg?= =?us-ascii?Q?j5ri9ZO2GtjRC2byuFeY0EGQ7u84A5/dS8bw0tcLupveqWBcKZ0yPZD8RHCc?= =?us-ascii?Q?89ycuyrN73RxgEhchICp1D/HmNsyQOYKfUZCk0we23U0uFjgyms7CLMG+dEQ?= =?us-ascii?Q?4NvOBMcU9HE3SN+mVc4R1fSzknHq0zdVER4C03glWlGQGrpd3HFVvumNeh0D?= =?us-ascii?Q?jtiayM/TU6Pt2/Ct5QbA6tJp7rf6JkybIUfxjVK1U3ludgpelaR5dCQ3elxZ?= =?us-ascii?Q?sewDv7h2ZuleDnH4UhaIFNWCW5s4aFcjgtr/JDO5SijVpxBrpsX/iftp8WxA?= =?us-ascii?Q?CWrjZC+8c7S5rjTSxN3CDyYcjA7C+0wWBmkAjSwoGpmd8cYG7T9jlu0Ilbsh?= =?us-ascii?Q?hLiYicFkSQVXRMfUGHDGgSqos/JYXfqKLgze3loTRVWfqTlOhIvbcqjQQnXw?= =?us-ascii?Q?cxZfUvulJ6lSmT/OdCB4hgAmR8X30eVyApx+V3IJCPj4SqlL4V3ClKZV4+XN?= =?us-ascii?Q?veXaFijZK3ffQze/ITUxACR6P50gumIRjkirZw0ZDhhGzH0LJ/dG1wYDMfEj?= =?us-ascii?Q?o+77re43g2aCm1CXBdIRW6nkYVm4AY73s3Gygu9Ro5JQ6+ks1iwMMsQ91XAC?= =?us-ascii?Q?gikeDi3mujxe0j6cPC9BRCZ5QwfI7SZiV+FkbuDiBRHd8U8O2Vz1g4BqQzon?= =?us-ascii?Q?Z/Z1uezN2gYBsDWDjzwmQKxt/7KJv7QAPsCV9tVfh7GB10isEAoEjpxAk1rM?= =?us-ascii?Q?i/VOtNygE7YvgD9zLK26BKl/nsHfuRvfHEF8AEGE6ij1seYnY8t4jwTI/hmB?= =?us-ascii?Q?YHEhDsw6JtNBpYups1db6rNpsonU9SqUyL6cgJ97c621TWQXXuE/JpVVrHC4?= =?us-ascii?Q?nlRO5ZZNgBOJXCA0D4QzYaBt/CV9y8ujpw7irkZEzW8vC7nLji3PD5RTaHz9?= =?us-ascii?Q?nt7khPbhDxFd2oE/smedSwVz+f4wv1IXkFVWsM/l+ibpud0HJG9geLIT0Or4?= =?us-ascii?Q?lCtZ/4Yb3GKTx5sF1p27+caX0t94xwOQOGp8LifqIqLGtEXz9w8lKRyCdQ8D?= =?us-ascii?Q?oXcxsZbRsh7j2HmZxJQv+WMMwbNkUHpwejZkbE5pxiCN6hRVZC8kfktuSja7?= =?us-ascii?Q?pTFOTmZJUHNb88hqPqupRmeejYbpPSGvVUQYfUMrRtv68F3iRyRFMUYejBPw?= =?us-ascii?Q?qM6xjFdbqaAKS/tKOYud9IZBDKYLT2XtCcbKzhiRKItnO6BXl9N1Bx9yaAob?= =?us-ascii?Q?iXB7jrTVnb6nqLE6wMahIAATtksSZkaUcyaJYSS5Yh0JWDvM?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: caa403a5-3d86-4320-c30d-08def3d74310 X-MS-Exchange-CrossTenant-AuthSource: IA0PR12MB8374.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Aug 2026 16:25:00.3304 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Liq7/IQD0F0wmRZ2Z6SAty9WuZx0zD6xJ/8bGssDvqEqSrzFcdAfLu1Yuturk+Kq X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR12MB6799 On 4 Aug 2026, at 15:24, Nico Pache (Red Hat) wrote: > Extract the repeated clearing of node_load, alloc_nmask, and > mthp_present_ptes into a helper to reduce duplication in > collapse_scan_pmd() and collapse_scan_file(). Althought file scans do not > current use the bitmap, they will in the future, and clearing it now is > harmless. > > Reviewed-by: Baolin Wang > Acked-by: Usama Arif > Acked-by: David Hildenbrand (Arm) > Reviewed-by: Lorenzo Stoakes (ARM) > Signed-off-by: Nico Pache (Red Hat) > --- > mm/khugepaged.c | 14 +++++++++----- > 1 file changed, 9 insertions(+), 5 deletions(-) > LGTM. Reviewed-by: Zi Yan Best Regards, Yan, Zi