From: Marcel Holtmann <marcel@holtmann.org>
To: Paul Bolle <pebolle@tiscali.nl>
Cc: Stanislav Yakovlev <stas.yakovlev@gmail.com>,
Kalle Valo <kvalo@codeaurora.org>, Jiri Kosina <jkosina@suse.cz>,
Linus Torvalds <torvalds@linux-foundation.org>,
linux-wireless <linux-wireless@vger.kernel.org>,
Network Development <netdev@vger.kernel.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Revert "ipw2200: select CFG80211_WEXT"
Date: Sat, 3 Jan 2015 10:02:00 -0800 [thread overview]
Message-ID: <CD467A59-F563-439B-BA82-954AB27AD9CC@holtmann.org> (raw)
In-Reply-To: <1420297188.2397.3.camel@tiscali.nl>
Hi Paul,
> This reverts commit dddd60220f41775e634258efd1b54c6fa81ce706.
>
> The raison d'être of commit dddd60220f41 ("ipw2200: select
> CFG80211_WEXT") was reverted in commit 2d36e008739e ("Revert "cfg80211:
> make WEXT compatibility unselectable""). So revert this commit too.
>
> Signed-off-by: Paul Bolle <pebolle@tiscali.nl>
> ---
> drivers/net/wireless/ipw2x00/Kconfig | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/net/wireless/ipw2x00/Kconfig b/drivers/net/wireless/ipw2x00/Kconfig
> index 21de4fe6cf2d..91c0cb3c368e 100644
> --- a/drivers/net/wireless/ipw2x00/Kconfig
> +++ b/drivers/net/wireless/ipw2x00/Kconfig
> @@ -65,8 +65,7 @@ config IPW2100_DEBUG
>
> config IPW2200
> tristate "Intel PRO/Wireless 2200BG and 2915ABG Network Connection"
> - depends on PCI && CFG80211
> - select CFG80211_WEXT
> + depends on PCI && CFG80211 && CFG80211_WEXT
> select WIRELESS_EXT
> select WEXT_SPY
> select WEXT_PRIV
why would you revert this? It is obviously the correct change to actually select CFG80211_WEXT.
Regards
Marcel
next prev parent reply other threads:[~2015-01-03 18:02 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-03 14:59 Paul Bolle
2015-01-03 18:02 ` Marcel Holtmann [this message]
2015-01-03 18:07 ` Linus Torvalds
2015-01-03 22:28 ` Paul Bolle
2015-01-05 10:05 ` Johannes Berg
2015-01-05 10:12 ` Jiri Kosina
2015-01-05 10:20 ` Johannes Berg
2015-01-05 10:14 ` Arend van Spriel
2015-01-05 17:38 ` Paul Bolle
2015-01-05 18:22 ` Arend van Spriel
2015-01-05 18:57 ` Johannes Berg
2015-01-05 22:05 ` Paul Bolle
2015-01-05 22:13 ` Arend van Spriel
2015-01-06 8:19 ` Johannes Berg
2015-01-06 8:23 ` Johannes Berg
2015-01-06 13:26 ` Johannes Berg
2015-01-06 8:03 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CD467A59-F563-439B-BA82-954AB27AD9CC@holtmann.org \
--to=marcel@holtmann.org \
--cc=jkosina@suse.cz \
--cc=kvalo@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pebolle@tiscali.nl \
--cc=stas.yakovlev@gmail.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®