From: Andreas Dilger <adilger@sun.com>
To: Jan Blunck <jblunck@suse.de>
Cc: Linux-Kernel Mailinglist <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Jan Kara <jack@suse.cz>
Subject: Re: [PATCH] ext2: Explicitly assign values to on-disk enum of filetypes
Date: Wed, 18 Nov 2009 23:34:46 -0800 [thread overview]
Message-ID: <CE98E2AD-F6E2-4AC7-B43A-BE2893E384F8@sun.com> (raw)
In-Reply-To: <20091118162550.GP21750@bolzano.suse.de>
On 2009-11-18, at 08:25, Jan Blunck wrote:
> Here is an old patch that I found in my tree. Andreas, it seems that
> this is something you proposed.
>
> Comments?
This is definitely my preferred coding style for constants that form a
permanent part of the API/ABI/disk format.
The enum is useful because some debuggers can display the symbolic
name of a constant if a named enum is present (though in this case it
isn't), but it avoids the risk of someone accidentally inserting or
removing a value in the middle of the enum.
For in-memory-only enums that isn't important at all, but for some
developers it isn't always clear what is in-memory and what is on-disk
or part of an API. Also, the compiler will warn if the same value is
assigned multiple times, which isn't necessarily a worry with the few
values here, but for large lists of #defines like e.g.
EXT2_FEATURE_INCOMPAT_* it is a real risk, and I've seen a few cases
where the same value was #defined multiple times accidentally (e.g.
with patches vs. upstream merges).
> From 290d3d969850ff9555bc213035b1c4e401ea9ada Mon Sep 17 00:00:00 2001
> From: Jan Blunck <jblunck@suse.de>
> Date: Wed, 18 Nov 2009 17:10:56 +0100
> Subject: [PATCH] ext2: Explicitly assign values to on-disk enum of
> filetypes
>
> It is somewhat dangerous to use a straight enum here, because this
> will
> reassign values of later variables if one of the earlier ones is
> removed.
>
> Signed-off-by: Jan Blunck <jblunck@suse.de>
> Cc: Andreas Dilger <adilger@sun.com>
> ---
> include/linux/ext2_fs.h | 16 ++++++++--------
> 1 files changed, 8 insertions(+), 8 deletions(-)
>
> diff --git a/include/linux/ext2_fs.h b/include/linux/ext2_fs.h
> index 121720d..2dfa707 100644
> --- a/include/linux/ext2_fs.h
> +++ b/include/linux/ext2_fs.h
> @@ -565,14 +565,14 @@ struct ext2_dir_entry_2 {
> * other bits are reserved for now.
> */
> enum {
> - EXT2_FT_UNKNOWN,
> - EXT2_FT_REG_FILE,
> - EXT2_FT_DIR,
> - EXT2_FT_CHRDEV,
> - EXT2_FT_BLKDEV,
> - EXT2_FT_FIFO,
> - EXT2_FT_SOCK,
> - EXT2_FT_SYMLINK,
> + EXT2_FT_UNKNOWN = 0,
> + EXT2_FT_REG_FILE = 1,
> + EXT2_FT_DIR = 2,
> + EXT2_FT_CHRDEV = 3,
> + EXT2_FT_BLKDEV = 4,
> + EXT2_FT_FIFO = 5,
> + EXT2_FT_SOCK = 6,
> + EXT2_FT_SYMLINK = 7,
> EXT2_FT_MAX
> };
>
> --
> 1.6.4.2
>
Cheers, Andreas
--
Andreas Dilger
Sr. Staff Engineer, Lustre Group
Sun Microsystems of Canada, Inc.
next prev parent reply other threads:[~2009-11-19 7:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-18 16:25 Jan Blunck
2009-11-19 7:34 ` Andreas Dilger [this message]
2009-11-19 14:38 ` Jan Kara
-- strict thread matches above, loose matches on Subject: below --
2009-05-19 10:00 Jan Blunck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CE98E2AD-F6E2-4AC7-B43A-BE2893E384F8@sun.com \
--to=adilger@sun.com \
--cc=akpm@linux-foundation.org \
--cc=jack@suse.cz \
--cc=jblunck@suse.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®