mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Nadav Amit <namit@vmware.com>
To: Andy Lutomirski <luto@amacapital.net>
Cc: Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>,
	LKML <linux-kernel@vger.kernel.org>, X86 ML <x86@kernel.org>,
	David Woodhouse <dwmw@amazon.co.uk>,
	Peter Zijlstra <peterz@infradead.org>,
	Andy Lutomirski <luto@kernel.org>
Subject: Re: [RFC] x86/cpu_entry_area: move part of it back to fixmap
Date: Thu, 4 Oct 2018 16:30:57 +0000	[thread overview]
Message-ID: <CE9C4B9C-3B11-45D0-812A-F074D687084D@vmware.com> (raw)
In-Reply-To: <72B0B378-9515-47C4-8937-9F1E823DD236@amacapital.net>

at 7:11 AM, Andy Lutomirski <luto@amacapital.net> wrote:

> 
> 
> On Oct 3, 2018, at 9:59 PM, Nadav Amit <namit@vmware.com> wrote:
> 
>> This RFC proposes to return part of the entry-area back to the fixmap to
>> improve system-call performance. Currently, since the entry-area is
>> mapped far (more than 2GB) away from the kernel text, an indirect branch
>> is needed to jump from the trampoline into the kernel. Due to Spectre
>> v2, vulnerable CPUs need to use a retpoline, which introduces an
>> overhead of >20 cycles.
> 
> That retpoline is gone in -tip. Can you see how your code stacks up against -tip?  If it’s enough of a win to justify the added complexity, we can try it. 
> 
> You can see some pros and cons in the changelog:
> 
> https://git.kernel.org/tip/bf904d2762ee6fc1e4acfcb0772bbfb4a27ad8a6

Err.. That’s what I get for not following lkml. Very nice discussion.
Based on it, I may be able to do an additional micro-optimizations or
two. Let me give it a try.


  parent reply	other threads:[~2018-10-04 16:31 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-04  4:59 Nadav Amit
2018-10-04  7:37 ` Peter Zijlstra
2018-10-04  9:41   ` Nadav Amit
     [not found] ` <72B0B378-9515-47C4-8937-9F1E823DD236@amacapital.net>
2018-10-04 16:30   ` Nadav Amit [this message]
2018-10-04 17:02     ` Andy Lutomirski
2018-10-05 18:35       ` Nadav Amit
2018-10-05 22:10         ` Andy Lutomirski
2018-10-05 22:17           ` Nadav Amit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CE9C4B9C-3B11-45D0-812A-F074D687084D@vmware.com \
    --to=namit@vmware.com \
    --cc=dwmw@amazon.co.uk \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luto@amacapital.net \
    --cc=luto@kernel.org \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®