From: Kumar Gala <galak@kernel.crashing.org>
To: Segher Boessenkool <segher@kernel.crashing.org>
Cc: "Zhang Wei-r63237" <Wei.Zhang@freescale.com>,
<linux-kernel@vger.kernel.org>, <mporter@kernel.crashing.org>,
<paulus@samba.org>, <linuxppc-dev@ozlabs.org>
Subject: Re: [PATCH 1/5] Add the explanation and sample of RapidIO DTS sector to the document of booting-without-of.txt file.
Date: Thu, 14 Jun 2007 00:53:11 -0500 [thread overview]
Message-ID: <CF39A363-25C6-4780-96EC-6750D77C287F@kernel.crashing.org> (raw)
In-Reply-To: <59453d80f2f111b72e8f24e7b489c23e@kernel.crashing.org>
>> Some silicons of Freescale processor are the same RapidIO controller,
>> such as mpc8540/mpc8560 are the same (v0.0), mpc8548/mpc8641 are the
>> same (v1.0). For v1.0 RapidIO controller, should we use mpc8548 or
>> mpc8641? Those will make people confused.
>
> Not at all. On an 8641 it could be
>
> compatible = "fsl,mpc8641-rapidio" "fsl,mpc8548-rapidio";
>
> which states "this is the 8641 thing and it is compatible
> to the 8548 thing". Perfectly clear.
The concern is this isn't just compatible = "..8641.." "..8548.." but
something like:
"..8641.." "..8641d.." "..8548.." "..8548e.." "..8543.." "..8543e.."
"..8572.." "..8572e.." "..8567.." "..8567e.." "..8568.." "..8568e.."
>> Using IP Block Revision is a
>> clear choice.
>
> I don't think so. For one thing, it describes a version of
> a cell design, not a version of an actual device. For another
> thing, if I hear "8641" I know what you're talking about (sort
> of, anyway), but I draw a blank stare if you say "v1.0". I'm
> sure I'm not the only one. Concrete names are good.
While I agree concrete names are good, we put these 'blocks' in so
many devices that using the device to match on is pointless.
I'm all for making up a name like 'Grande', 'Del', 'Janeiro'. This
is effective what we did with gianfar. The name gets picked up
pretty quickly by people.
- k
next prev parent reply other threads:[~2007-06-14 5:53 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-12 9:02 [PATCH 0/5] Porting RapidIO driver from ppc to powerpc architecture and adding memory mapped RapidIO driver Zhang Wei
2007-06-12 9:02 ` [PATCH 1/5] Add the explanation and sample of RapidIO DTS sector to the document of booting-without-of.txt file Zhang Wei
2007-06-12 9:02 ` [PATCH 2/5] Add RapidIO sector to MPC8641HPCN board dts file Zhang Wei
2007-06-12 9:02 ` [PATCH 3/5] Add the platform device support with RapidIO to MPC8641HPCN platform Zhang Wei
2007-06-12 9:02 ` [PATCH 4/5] Add RapidIO support to powerpc architecture Zhang Wei
2007-06-12 22:58 ` [PATCH 2/5] Add RapidIO sector to MPC8641HPCN board dts file Phil Terry
2007-06-13 2:49 ` Zhang Wei-r63237
2007-06-13 5:02 ` [PATCH 1/5] Add the explanation and sample of RapidIO DTS sector to the document of booting-without-of.txt file Segher Boessenkool
2007-06-13 8:14 ` Zhang Wei-r63237
2007-06-13 8:28 ` Segher Boessenkool
2007-06-13 9:37 ` Zhang Wei-r63237
2007-06-13 9:48 ` Segher Boessenkool
2007-06-14 5:53 ` Kumar Gala [this message]
2007-06-14 7:52 ` Segher Boessenkool
2007-06-18 3:27 ` Zhang Wei-r63237
2007-06-18 12:43 ` Segher Boessenkool
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CF39A363-25C6-4780-96EC-6750D77C287F@kernel.crashing.org \
--to=galak@kernel.crashing.org \
--cc=Wei.Zhang@freescale.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=mporter@kernel.crashing.org \
--cc=paulus@samba.org \
--cc=segher@kernel.crashing.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®