From: Avri Altman <Avri.Altman@wdc.com>
To: "daejun7.park@samsung.com" <daejun7.park@samsung.com>,
"James E . J . Bottomley" <jejb@linux.vnet.ibm.com>,
"Martin K . Petersen" <martin.petersen@oracle.com>
Cc: "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Bart Van Assche <bvanassche@acm.org>,
Adrian Hunter <adrian.hunter@intel.com>,
Bean Huo <beanhuo@micron.com>,
James Bottomley <James.Bottomley@HansenPartnership.com>
Subject: RE: [PATCH v2] scsi: ufshpb: Opt out pre-reqs from HPB2.0 flows
Date: Fri, 29 Oct 2021 23:47:49 +0000 [thread overview]
Message-ID: <CH2PR04MB657022BFB9D32FAD8472B68CFC879@CH2PR04MB6570.namprd04.prod.outlook.com> (raw)
In-Reply-To: <1891546521.01635546902168.JavaMail.epsvc@epcpadp3>
> Hi Avri,
>
> > @@ -1841,13 +1575,7 @@ static void ufshpb_lu_parameter_init(struct
> ufs_hba *hba,
> > u32 entries_per_rgn;
> > u64 rgn_mem_size, tmp;
> >
> > - /* for pre_req */
> > - hpb->pre_req_min_tr_len = hpb_dev_info->max_hpb_single_cmd + 1;
> > -
> > - if (ufshpb_is_legacy(hba))
> > - hpb->pre_req_max_tr_len = HPB_LEGACY_CHUNK_HIGH;
> > - else
> > - hpb->pre_req_max_tr_len = HPB_MULTI_CHUNK_HIGH;
> > + hpb->pre_req_max_tr_len = HPB_LEGACY_CHUNK_HIGH;
>
> They are should be not changed, because it makes
> ufshpb_is_supported_chunk() determine to non-HPB READ when the its size
> is bigger than 4KB.
Yes, this patch downgrades HPB to support single block only as if HPB1.0.
But You are correct.
the spec only _recommend_ to use pre-req commands if transfer length > bMAX_DATA_SIZE_FOR_HPB_SINGLE_CMD.
Meaning, it is ok to use HPB-READ with hpb-read-id = 0x0 and transfer length <= bMAX_DATA_SIZE_FOR_HPB_SINGLE_CMD.
Will re-insert those pieces of code in v3.
While at it, I noticed that I didn't removed ufshpb_get_read_id - will remove it as well.
Thanks,
Avri
prev parent reply other threads:[~2021-10-29 23:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-29 19:30 Avri Altman
[not found] ` <CGME20211029193014epcas2p10300c03ccf0337f9dd3653f29e2057d1@epcms2p1>
2021-10-29 22:30 ` Daejun Park
2021-10-29 23:47 ` Avri Altman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CH2PR04MB657022BFB9D32FAD8472B68CFC879@CH2PR04MB6570.namprd04.prod.outlook.com \
--to=avri.altman@wdc.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=adrian.hunter@intel.com \
--cc=beanhuo@micron.com \
--cc=bvanassche@acm.org \
--cc=daejun7.park@samsung.com \
--cc=jejb@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®