From: "Nicholas Piggin" <npiggin@gmail.com>
To: "Laurent Dufour" <ldufour@linux.ibm.com>, <mpe@ellerman.id.au>,
<christophe.leroy@csgroup.eu>
Cc: <linuxppc-dev@lists.ozlabs.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/2] powerpc: export the CPU node count
Date: Mon, 07 Nov 2022 22:11:17 +1000 [thread overview]
Message-ID: <CO61XSIISI9G.PHZVHP50ZWUU@bobo> (raw)
In-Reply-To: <20221028160034.44400-2-ldufour@linux.ibm.com>
On Sat Oct 29, 2022 at 2:00 AM AEST, Laurent Dufour wrote:
> At boot time, the FDT is parsed to compute the number of CPUs.
> In addition count the number of CPU nodes and export it.
>
> This is useful when building the FDT for a kexeced kernel since we need to
> take in account the CPU node added since the boot time during CPU hotplug
> operations.
It would be nice if it just realloced memory in this case, but that
looks like a bigger change.
But these patches look okay to me, if you can solve the compile bug.
Thanks,
Nick
>
> Signed-off-by: Laurent Dufour <ldufour@linux.ibm.com>
> ---
> arch/powerpc/include/asm/kexec_ranges.h | 2 ++
> arch/powerpc/kernel/prom.c | 4 ++++
> 2 files changed, 6 insertions(+)
>
> diff --git a/arch/powerpc/include/asm/kexec_ranges.h b/arch/powerpc/include/asm/kexec_ranges.h
> index f83866a19e87..bf35d00ddd09 100644
> --- a/arch/powerpc/include/asm/kexec_ranges.h
> +++ b/arch/powerpc/include/asm/kexec_ranges.h
> @@ -22,4 +22,6 @@ int add_rtas_mem_range(struct crash_mem **mem_ranges);
> int add_opal_mem_range(struct crash_mem **mem_ranges);
> int add_reserved_mem_ranges(struct crash_mem **mem_ranges);
>
> +extern unsigned int boot_cpu_node_count;
> +
> #endif /* _ASM_POWERPC_KEXEC_RANGES_H */
> diff --git a/arch/powerpc/kernel/prom.c b/arch/powerpc/kernel/prom.c
> index 1eed87d954ba..d326148fd5a4 100644
> --- a/arch/powerpc/kernel/prom.c
> +++ b/arch/powerpc/kernel/prom.c
> @@ -56,6 +56,7 @@
> #include <asm/drmem.h>
> #include <asm/ultravisor.h>
> #include <asm/prom.h>
> +#include <asm/kexec_ranges.h>
>
> #include <mm/mmu_decl.h>
>
> @@ -72,6 +73,7 @@ int __initdata iommu_is_off;
> int __initdata iommu_force_on;
> unsigned long tce_alloc_start, tce_alloc_end;
> u64 ppc64_rma_size;
> +unsigned int boot_cpu_node_count __ro_after_init;
> #endif
> static phys_addr_t first_memblock_size;
> static int __initdata boot_cpu_count;
> @@ -335,6 +337,8 @@ static int __init early_init_dt_scan_cpus(unsigned long node,
> if (type == NULL || strcmp(type, "cpu") != 0)
> return 0;
>
> + boot_cpu_node_count++;
> +
> /* Get physical cpuid */
> intserv = of_get_flat_dt_prop(node, "ibm,ppc-interrupt-server#s", &len);
> if (!intserv)
> --
> 2.38.1
next prev parent reply other threads:[~2022-11-07 12:11 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-28 16:00 [PATCH 0/2] Consider the size of the added CPU nodes in the kexec FDT Laurent Dufour
2022-10-28 16:00 ` [PATCH 1/2] powerpc: export the CPU node count Laurent Dufour
2022-10-28 18:02 ` kernel test robot
2022-10-29 23:31 ` kernel test robot
2022-11-07 12:11 ` Nicholas Piggin [this message]
2022-11-07 16:06 ` Laurent Dufour
2022-10-28 16:00 ` [PATCH 2/2] powerpc: Take in account addition CPU node when building kexec FDT Laurent Dufour
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CO61XSIISI9G.PHZVHP50ZWUU@bobo \
--to=npiggin@gmail.com \
--cc=christophe.leroy@csgroup.eu \
--cc=ldufour@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®