mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Adam Turk <bofh1234@hotmail.com>
To: <linux-kernel@vger.kernel.org>
Subject: recommended programming practices for writing (was Linux 2.6.29)
Date: Thu, 26 Mar 2009 15:03:28 -0400	[thread overview]
Message-ID: <COL112-W81AF4A8C222B9941D8295FC8910@phx.gbl> (raw)


I have been reading the Linux 2.6.29 thread with interest.  I have written several (10 or so) C programs that write large amounts of data (between 1 and 2 GB file sizes are common).  A snippet of code looks like this:

if((fptr = fopen(outfilename,"w")) == NULL) {
  printf("File %s could not be created\n", outfilename);
}
else {
  fprintf(fptr,"%s\n",datablock);
  while(!writeouput(datablock,amount,tax)) {
    getnext(dtablock)
    fprintf(fptr,"%s\n",datablock);
  }
  fclose(fptr);
}

I learned C about 15 years ago and there was no mention of a fsync.  My C book doesn't mention fsync either.  Granted I have written only 25-30 applications in the last 15 years or so so I am not an expert C programmer. 

>From what Linus posted about git and checking the return from fclose I think I going to start doing that.  I also think I am going to start checking the return from fprintf and maybe write to a /tmp/file and then rename it.

So is there a C fsync that I should add before my fclose?
What is the proper way to write to files?

Is what I am thinking about doing something that would be good or is it just a lack of my understanding the problem?

Thanks,
Adam

_________________________________________________________________
Hotmail® is up to 70% faster. Now good news travels really fast.
http://windowslive.com/online/hotmail?ocid=TXT_TAGLM_WL_HM_70faster_032009

             reply	other threads:[~2009-03-26 19:04 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-03-26 19:03 Adam Turk [this message]
2009-03-26 19:34 ` Bernd Petrovitsch
2009-03-26 22:33   ` Adam Turk
2009-03-26 19:35 ` Leon Woestenberg
2009-03-26 22:32   ` Adam Turk
2009-03-26 22:40 ` J.A. Magallón

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=COL112-W81AF4A8C222B9941D8295FC8910@phx.gbl \
    --to=bofh1234@hotmail.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®