From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753571AbbGBMi5 (ORCPT ); Thu, 2 Jul 2015 08:38:57 -0400 Received: from col004-omc1s17.hotmail.com ([65.55.34.27]:58294 "EHLO COL004-OMC1S17.hotmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753835AbbGBMin (ORCPT ); Thu, 2 Jul 2015 08:38:43 -0400 X-TMN: [XGEGPVSjUOIWHou4KB4b4g0v7B8wUe3w] X-Originating-Email: [yuchaochina@hotmail.com] Message-ID: From: Chao Yu To: "'Jaegeuk Kim'" , , , References: <1435603176-63219-1-git-send-email-jaegeuk@kernel.org> <1435603176-63219-11-git-send-email-jaegeuk@kernel.org> In-Reply-To: <1435603176-63219-11-git-send-email-jaegeuk@kernel.org> Subject: RE: [f2fs-dev] [PATCH 11/12] f2fs: add noextent_cache mount option Date: Thu, 2 Jul 2015 20:35:34 +0800 MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Outlook 15.0 Thread-index: AQABAgMEaSjnKR6c23t3vCvP0rA2RKFnMTlw Content-Language: zh-cn X-OriginalArrivalTime: 02 Jul 2015 12:35:42.0451 (UTC) FILETIME=[9C1CF430:01D0B4C3] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > -----Original Message----- > From: Jaegeuk Kim [mailto:jaegeuk@kernel.org] > Sent: Tuesday, June 30, 2015 2:40 AM > To: linux-kernel@vger.kernel.org; linux-fsdevel@vger.kernel.org; > linux-f2fs-devel@lists.sourceforge.net > Cc: Jaegeuk Kim > Subject: [f2fs-dev] [PATCH 11/12] f2fs: add noextent_cache mount option > > This patch adds noextent_cache mount option. How about adding some descriptions in Documentation to help our user? The other thing is we'd better to show 'noextent_cache' option when user lookups the mount options. How about adding codes as below? if (test_opt(sbi, EXTENT_CACHE)) seq_puts(seq, ",extent_cache"); +else + seq_puts(seq, ",noextent_cache"); > > Signed-off-by: Jaegeuk Kim The other looks good to me, so please add: Reviewed-by: Chao Yu